Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128790,
    "url": "http://patchwork.dpdk.org/api/patches/128790/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230619124528.3967275-2-ktejasree@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230619124528.3967275-2-ktejasree@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230619124528.3967275-2-ktejasree@marvell.com",
    "date": "2023-06-19T12:45:21",
    "name": "[1/8] crypto/cnxk: check for null pointer",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "28d1763f803534fab1b867648ec17948c602453b",
    "submitter": {
        "id": 1789,
        "url": "http://patchwork.dpdk.org/api/people/1789/?format=api",
        "name": "Tejasree Kondoj",
        "email": "ktejasree@marvell.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230619124528.3967275-2-ktejasree@marvell.com/mbox/",
    "series": [
        {
            "id": 28566,
            "url": "http://patchwork.dpdk.org/api/series/28566/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28566",
            "date": "2023-06-19T12:45:20",
            "name": "fixes and improvements to CNXK crypto PMD",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/28566/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/128790/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/128790/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 541BD42CFA;\n\tMon, 19 Jun 2023 14:45:42 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0BBA42BC9;\n\tMon, 19 Jun 2023 14:45:38 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 428AD410E4\n for <dev@dpdk.org>; Mon, 19 Jun 2023 14:45:37 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 35JBcNof017112 for <dev@dpdk.org>; Mon, 19 Jun 2023 05:45:36 -0700",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3r9a6n5hkk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 19 Jun 2023 05:45:36 -0700",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Mon, 19 Jun 2023 05:45:34 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Mon, 19 Jun 2023 05:45:34 -0700",
            "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 87E595C68F0;\n Mon, 19 Jun 2023 05:45:32 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=aG+WGALFaxK/aJlcpwpHhoRCGwk7lCUoKOHO+vUh2mc=;\n b=KbABh48R/U6HmiPhxZGwZhUF/E2vxqZq12EyTilLevc5Bu/BaahmgFygSo3hYzLXI3H/\n RUbIQqwmJO5fVVYXj4yX25aLDYfWDvXBJs55uZ6Qffry+0vowp+LmzIoX/R+J1htATWx\n ytDVNXAgbDgyXi8O1rJ31uJFKYU9D9L8ZHSG6pzG+vSMyVhQUh2SDYRvSMQCqzdzSclC\n qh6y4b0i6x5JC3+odhKhXvTJbISMZRWD98ZZ3F5V70g1HOUcGKdJ0/br2JoLopVITx/6\n Hyc4pxB2zIM+29EoL5ailZQuemcVb7q/7lszGk/GcF1ZIL8w+g0+eo7y4DsAwSe3JQ4L kg==",
        "From": "Tejasree Kondoj <ktejasree@marvell.com>",
        "To": "Akhil Goyal <gakhil@marvell.com>",
        "CC": "Anoob Joseph <anoobj@marvell.com>, Aakash Sasidharan\n <asasidharan@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>,\n Vidya Sagar Velumuri <vvelumuri@marvell.com>, <dev@dpdk.org>",
        "Subject": "[PATCH 1/8] crypto/cnxk: check for null pointer",
        "Date": "Mon, 19 Jun 2023 18:15:21 +0530",
        "Message-ID": "<20230619124528.3967275-2-ktejasree@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230619124528.3967275-1-ktejasree@marvell.com>",
        "References": "<20230619124528.3967275-1-ktejasree@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "hLQhkvxPezLYrjyjDi_wDo291W8M4GE7",
        "X-Proofpoint-GUID": "hLQhkvxPezLYrjyjDi_wDo291W8M4GE7",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-06-19_09,2023-06-16_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Checking for NULL pointer dereference.\n\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex c66ab80749..a85e4c5170 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -2185,12 +2185,14 @@ fill_sess_auth(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess)\n \n \tif (zsk_flag && sess->roc_se_ctx.auth_then_ciph) {\n \t\tstruct rte_crypto_cipher_xform *c_form;\n-\t\tc_form = &xform->next->cipher;\n-\t\tif (c_form->op != RTE_CRYPTO_CIPHER_OP_ENCRYPT &&\n-\t\t    a_form->op != RTE_CRYPTO_AUTH_OP_GENERATE) {\n-\t\t\tplt_dp_err(\"Crypto: PDCP auth then cipher must use\"\n-\t\t\t\t   \" options: encrypt and generate\");\n-\t\t\treturn -EINVAL;\n+\t\tif (xform->next != NULL) {\n+\t\t\tc_form = &xform->next->cipher;\n+\t\t\tif ((c_form != NULL) && (c_form->op != RTE_CRYPTO_CIPHER_OP_ENCRYPT) &&\n+\t\t\t    a_form->op != RTE_CRYPTO_AUTH_OP_GENERATE) {\n+\t\t\t\tplt_dp_err(\"Crypto: PDCP auth then cipher must use\"\n+\t\t\t\t\t   \" options: encrypt and generate\");\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n \t\t}\n \t}\n \n",
    "prefixes": [
        "1/8"
    ]
}