Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128828/?format=api
{ "id": 128828, "url": "http://patchwork.dpdk.org/api/patches/128828/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230620075251.103491-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230620075251.103491-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230620075251.103491-6-maxime.coquelin@redhat.com", "date": "2023-06-20T07:52:50", "name": "[v2,5/6] crypto/ipsec_mb: remove security lib presence checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f64314e344019385a294f9b85b9336a6152dd43b", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230620075251.103491-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28572, "url": "http://patchwork.dpdk.org/api/series/28572/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28572", "date": "2023-06-20T07:52:45", "name": "Trivial crypto PMDs cleanup", "version": 2, "mbox": "http://patchwork.dpdk.org/series/28572/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128828/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DBE7E42D04;\n\tTue, 20 Jun 2023 09:53:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5975F42D2C;\n\tTue, 20 Jun 2023 09:53:14 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 7628D42D3C\n for <dev@dpdk.org>; Tue, 20 Jun 2023 09:53:12 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-356-fhdW2rtrMWCU-MJ9qzqMxQ-1; Tue, 20 Jun 2023 03:53:06 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 578C73802AE7;\n Tue, 20 Jun 2023 07:53:06 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.22])\n by smtp.corp.redhat.com (Postfix) with ESMTP id ACFE5200A398;\n Tue, 20 Jun 2023 07:53:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687247592;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N5rOi7Q3HudaP0BcIiFioyBXaBSGu7PxnsyP/oDqsPE=;\n b=RPjKzCzOJrCHYzJzTODhzqy7AjHi1iycbU80oNWLOa5ls1qMRnqbfr0VtaxmtPHGZyWloY\n 4i207iSWrZKeEPzPva1zeU3uFlmaKhZR7AF78eRHH/NBkWTkoxgeaElDfErAV8peWEPbsx\n oZ6RbcVoKOsPNEVVvzdxvgv9V+q7lC8=", "X-MC-Unique": "fhdW2rtrMWCU-MJ9qzqMxQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, kai.ji@intel.com, g.singh@nxp.com, hemant.agrawal@nxp.com,\n pablo.de.lara.guarch@intel.com, fanzhang.oss@gmail.com,\n roretzla@linux.microsoft.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v2 5/6] crypto/ipsec_mb: remove security lib presence checks", "Date": "Tue, 20 Jun 2023 09:52:50 +0200", "Message-ID": "<20230620075251.103491-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230620075251.103491-1-maxime.coquelin@redhat.com>", "References": "<20230620075251.103491-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Since security library is a required dependency for\nbuilding ipsec_mb crypto PMD, remove useless check before\nsecurity lib headers inclusion.\n\nThe patch also takes the opportunity to remove unused\nrelated defines.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/crypto/ipsec_mb/ipsec_mb_private.h | 3 ---\n drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 4 ----\n 2 files changed, 7 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h\nindex ab27214f2c..52722f94a0 100644\n--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h\n+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h\n@@ -13,11 +13,8 @@\n #include <cryptodev_pmd.h>\n #include <bus_vdev_driver.h>\n \n-#if defined(RTE_LIB_SECURITY)\n-#define IPSEC_MB_DOCSIS_SEC_ENABLED 1\n #include <rte_security.h>\n #include <rte_security_driver.h>\n-#endif\n \n /* Maximum length for digest */\n #define DIGEST_LENGTH_MAX 64\ndiff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\nindex 9b7c9edb6d..4ffbe4b282 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\n@@ -5,12 +5,10 @@\n #ifndef _PMD_AESNI_MB_PRIV_H_\n #define _PMD_AESNI_MB_PRIV_H_\n \n-#if defined(RTE_LIB_SECURITY)\n #define AESNI_MB_DOCSIS_SEC_ENABLED 1\n #include <rte_security.h>\n #include <rte_security_driver.h>\n #include <rte_ether.h>\n-#endif\n \n #include \"ipsec_mb_private.h\"\n \n@@ -950,7 +948,6 @@ typedef void (*hash_one_block_t)(const void *data, void *digest);\n typedef void (*aes_keyexp_t)(const void *key, void *enc_exp_keys,\n \t\t\tvoid *dec_exp_keys);\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n static const struct rte_cryptodev_capabilities\n \t\t\t\t\taesni_mb_pmd_security_crypto_cap[] = {\n \t{\t/* AES DOCSIS BPI */\n@@ -998,6 +995,5 @@ static const struct rte_security_capability aesni_mb_pmd_security_cap[] = {\n \t\t.action = RTE_SECURITY_ACTION_TYPE_NONE\n \t}\n };\n-#endif\n \n #endif /* _PMD_AESNI_MB_PRIV_H_ */\n", "prefixes": [ "v2", "5/6" ] }