Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128829,
    "url": "http://patchwork.dpdk.org/api/patches/128829/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230620075251.103491-7-maxime.coquelin@redhat.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230620075251.103491-7-maxime.coquelin@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230620075251.103491-7-maxime.coquelin@redhat.com",
    "date": "2023-06-20T07:52:51",
    "name": "[v2,6/6] crypto/qat: remove useless log level checks",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fbb1be3afae282a618673985968c00476990893d",
    "submitter": {
        "id": 512,
        "url": "http://patchwork.dpdk.org/api/people/512/?format=api",
        "name": "Maxime Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patchwork.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230620075251.103491-7-maxime.coquelin@redhat.com/mbox/",
    "series": [
        {
            "id": 28572,
            "url": "http://patchwork.dpdk.org/api/series/28572/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28572",
            "date": "2023-06-20T07:52:45",
            "name": "Trivial crypto PMDs cleanup",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/28572/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/128829/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/128829/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8082742D04;\n\tTue, 20 Jun 2023 09:53:39 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 719E842D29;\n\tTue, 20 Jun 2023 09:53:15 +0200 (CEST)",
            "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id A5B2F42D3E\n for <dev@dpdk.org>; Tue, 20 Jun 2023 09:53:12 +0200 (CEST)",
            "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-448-anxApT7GP627i5e8u8jccQ-1; Tue, 20 Jun 2023 03:53:08 -0400",
            "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 469AB811E9E;\n Tue, 20 Jun 2023 07:53:08 +0000 (UTC)",
            "from max-t490s.redhat.com (unknown [10.39.208.22])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9D231207B2BC;\n Tue, 20 Jun 2023 07:53:06 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687247592;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Sm6MD10oGuNDqvxv5oTnOKFhqCN8Wk1EKG2mBJenXXo=;\n b=W83eB067vSQ1uI/Z4dPcDAwsS//NiPV5ZSMeaMBNePH4eb70ihXh68tKE+0hxTHIcur1yF\n QbdL8bBBoGAEDXWH9B155zk9EbxURhbiK4YHWPns6bZrjgrLN9AuN2f+/Nf8FETab70cVF\n J56m1X1Vplk4I3+qght8FevArP5d2Q4=",
        "X-MC-Unique": "anxApT7GP627i5e8u8jccQ-1",
        "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
        "To": "dev@dpdk.org, kai.ji@intel.com, g.singh@nxp.com, hemant.agrawal@nxp.com,\n pablo.de.lara.guarch@intel.com, fanzhang.oss@gmail.com,\n roretzla@linux.microsoft.com",
        "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>",
        "Subject": "[PATCH v2 6/6] crypto/qat: remove useless log level checks",
        "Date": "Tue, 20 Jun 2023 09:52:51 +0200",
        "Message-ID": "<20230620075251.103491-7-maxime.coquelin@redhat.com>",
        "In-Reply-To": "<20230620075251.103491-1-maxime.coquelin@redhat.com>",
        "References": "<20230620075251.103491-1-maxime.coquelin@redhat.com>",
        "MIME-Version": "1.0",
        "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4",
        "X-Mimecast-Spam-Score": "0",
        "X-Mimecast-Originator": "redhat.com",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "qat_sym_debug_log_dump() being stubbed if log level\nis less than debug, it is not necessary to check the log\nlevel before calling it.\n\nAcked-by: Fan Zhang <fanzhang.oss@gmail.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c |  9 +------\n drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c |  7 +----\n drivers/crypto/qat/dev/qat_sym_pmd_gen1.c    | 27 +++-----------------\n 3 files changed, 5 insertions(+), 38 deletions(-)",
    "diff": "diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\nindex 93b1327e22..57f247be28 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c\n@@ -389,10 +389,8 @@ qat_sym_build_op_aead_gen3(void *in_op, struct qat_sym_session *ctx,\n \tenqueue_one_aead_job_gen3(ctx, req, &cipher_iv, &digest, &aad, ofs,\n \t\ttotal_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, &cipher_iv,\n \t\t\tNULL, &aad, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -435,10 +433,8 @@ qat_sym_build_op_auth_gen3(void *in_op, struct qat_sym_session *ctx,\n \tenqueue_one_auth_job_gen3(ctx, cookie, req, &digest, &auth_iv,\n \t\t\tofs, total_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, NULL,\n \t\t\t&auth_iv, NULL, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -525,10 +521,9 @@ qat_sym_dp_enqueue_single_aead_gen3(void *qp_data, uint8_t *drv_ctx,\n \tdp_ctx->tail = tail;\n \tdp_ctx->cached_enqueue++;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, iv,\n \t\t\tNULL, aad, digest);\n-#endif\n+\n \treturn 0;\n }\n \n@@ -584,11 +579,9 @@ qat_sym_dp_enqueue_aead_jobs_gen3(void *qp_data, uint8_t *drv_ctx,\n \n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, &vec->iv[i], NULL,\n \t\t\t\t&vec->aad[i], &vec->digest[i]);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\ndiff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\nindex ab87ac2461..8da3e760f4 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c\n@@ -215,10 +215,8 @@ qat_sym_build_op_aead_gen4(void *in_op, struct qat_sym_session *ctx,\n \tenqueue_one_aead_job_gen4(ctx, qat_req, &cipher_iv, &digest, &aad, ofs,\n \t\ttotal_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(qat_req, ctx, in_sgl.vec, in_sgl.num, &cipher_iv,\n \t\t\tNULL, &aad, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -303,10 +301,9 @@ qat_sym_dp_enqueue_single_aead_gen4(void *qp_data, uint8_t *drv_ctx,\n \tdp_ctx->tail = tail;\n \tdp_ctx->cached_enqueue++;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, iv,\n \t\t\tNULL, aad, digest);\n-#endif\n+\n \treturn 0;\n }\n \n@@ -362,11 +359,9 @@ qat_sym_dp_enqueue_aead_jobs_gen4(void *qp_data, uint8_t *drv_ctx,\n \n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, &vec->iv[i], NULL,\n \t\t\t\t&vec->aad[i], &vec->digest[i]);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\ndiff --git a/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c b/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c\nindex db463b71e0..d44c155be5 100644\n--- a/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c\n+++ b/drivers/crypto/qat/dev/qat_sym_pmd_gen1.c\n@@ -242,10 +242,8 @@ qat_sym_build_op_cipher_gen1(void *in_op, struct qat_sym_session *ctx,\n \n \tenqueue_one_cipher_job_gen1(ctx, req, &cipher_iv, ofs, total_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, &cipher_iv,\n \t\t\tNULL, NULL, NULL);\n-#endif\n \n \treturn 0;\n }\n@@ -288,10 +286,8 @@ qat_sym_build_op_auth_gen1(void *in_op, struct qat_sym_session *ctx,\n \tenqueue_one_auth_job_gen1(ctx, req, &digest, &auth_iv, ofs,\n \t\t\ttotal_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, NULL,\n \t\t\t&auth_iv, NULL, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -335,10 +331,8 @@ qat_sym_build_op_aead_gen1(void *in_op, struct qat_sym_session *ctx,\n \tenqueue_one_aead_job_gen1(ctx, req, &cipher_iv, &digest, &aad, ofs,\n \t\ttotal_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, &cipher_iv,\n \t\t\tNULL, &aad, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -383,10 +377,8 @@ qat_sym_build_op_chain_gen1(void *in_op, struct qat_sym_session *ctx,\n \t\t\tout_sgl.vec, out_sgl.num, &cipher_iv, &digest, &auth_iv,\n \t\t\tofs, total_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, in_sgl.vec, in_sgl.num, &cipher_iv,\n \t\t\t&auth_iv, NULL, &digest);\n-#endif\n \n \treturn 0;\n }\n@@ -509,10 +501,8 @@ qat_sym_dp_enqueue_single_cipher_gen1(void *qp_data, uint8_t *drv_ctx,\n \n \tenqueue_one_cipher_job_gen1(ctx, req, iv, ofs, (uint32_t)data_len);\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, iv,\n \t\t\tNULL, NULL, NULL);\n-#endif\n \n \tdp_ctx->tail = tail;\n \tdp_ctx->cached_enqueue++;\n@@ -569,11 +559,9 @@ qat_sym_dp_enqueue_cipher_jobs_gen1(void *qp_data, uint8_t *drv_ctx,\n \t\t\t(uint32_t)data_len);\n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, &vec->iv[i],\n \t\t\t\tNULL, NULL, NULL);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\n@@ -621,10 +609,9 @@ qat_sym_dp_enqueue_single_auth_gen1(void *qp_data, uint8_t *drv_ctx,\n \tdp_ctx->tail = tail;\n \tdp_ctx->cached_enqueue++;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, NULL,\n \t\t\tauth_iv, NULL, digest);\n-#endif\n+\n \treturn 0;\n }\n \n@@ -677,11 +664,9 @@ qat_sym_dp_enqueue_auth_jobs_gen1(void *qp_data, uint8_t *drv_ctx,\n \t\t\t&vec->auth_iv[i], ofs, (uint32_t)data_len);\n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, NULL, &vec->auth_iv[i],\n \t\t\t\tNULL, &vec->digest[i]);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\n@@ -731,10 +716,9 @@ qat_sym_dp_enqueue_single_chain_gen1(void *qp_data, uint8_t *drv_ctx,\n \tdp_ctx->cached_enqueue++;\n \n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, cipher_iv,\n \t\t\tauth_iv, NULL, digest);\n-#endif\n+\n \treturn 0;\n }\n \n@@ -793,12 +777,10 @@ qat_sym_dp_enqueue_chain_jobs_gen1(void *qp_data, uint8_t *drv_ctx,\n \n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, &vec->iv[i],\n \t\t\t\t&vec->auth_iv[i],\n \t\t\t\tNULL, &vec->digest[i]);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\n@@ -846,10 +828,9 @@ qat_sym_dp_enqueue_single_aead_gen1(void *qp_data, uint8_t *drv_ctx,\n \tdp_ctx->tail = tail;\n \tdp_ctx->cached_enqueue++;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tqat_sym_debug_log_dump(req, ctx, data, n_data_vecs, iv,\n \t\t\tNULL, aad, digest);\n-#endif\n+\n \treturn 0;\n }\n \n@@ -905,11 +886,9 @@ qat_sym_dp_enqueue_aead_jobs_gen1(void *qp_data, uint8_t *drv_ctx,\n \n \t\ttail = (tail + tx_queue->msg_size) & tx_queue->modulo_mask;\n \n-#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \t\tqat_sym_debug_log_dump(req, ctx, vec->src_sgl[i].vec,\n \t\t\t\tvec->src_sgl[i].num, &vec->iv[i], NULL,\n \t\t\t\t&vec->aad[i], &vec->digest[i]);\n-#endif\n \t}\n \n \tif (unlikely(i < n))\n",
    "prefixes": [
        "v2",
        "6/6"
    ]
}