Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128838/?format=api
{ "id": 128838, "url": "http://patchwork.dpdk.org/api/patches/128838/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230620102106.3970544-3-ktejasree@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230620102106.3970544-3-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230620102106.3970544-3-ktejasree@marvell.com", "date": "2023-06-20T10:21:00", "name": "[v3,2/8] crypto/cnxk: remove packet length checks in crypto offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "082633c1b356e0815725d923c16347a8ea36e2ee", "submitter": { "id": 1789, "url": "http://patchwork.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230620102106.3970544-3-ktejasree@marvell.com/mbox/", "series": [ { "id": 28579, "url": "http://patchwork.dpdk.org/api/series/28579/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28579", "date": "2023-06-20T10:20:58", "name": "fixes and improvements to CNXK crypto PMD", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28579/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128838/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128838/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2394342D07;\n\tTue, 20 Jun 2023 12:21:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 87D5742C54;\n\tTue, 20 Jun 2023 12:21:18 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id DEA034113F\n for <dev@dpdk.org>; Tue, 20 Jun 2023 12:21:16 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 35K9wt5N024228 for <dev@dpdk.org>; Tue, 20 Jun 2023 03:21:16 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3r9cbkfd3b-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 20 Jun 2023 03:21:16 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 20 Jun 2023 03:21:14 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 20 Jun 2023 03:21:14 -0700", "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 4E8AA3F707A;\n Tue, 20 Jun 2023 03:21:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=VqH42p6BgQsUFHix2v6rh1BZV4LfWPBhmzbFqKCpAjo=;\n b=Y4vINa+frPO8vkNhK0Jb/i87q52Aad+TYkL642vwrdobEldaP0gGjE81OkbovM1SFHZK\n q6T5z1/RaXNUHf3DoTQn77QW/ANy2NrhEzyA9U4nEQUoQ8PeXBl3fbJsxkc+rGyinsun\n Pg0nn7I+pqLaymskdX1qe7DSQFldrkhk38fBNRtiIXGg6E7HjBSjbXdZq+biltGBU7Vf\n ETgQKtCw98c2wvWJ8Vns2gY7fanFbzH5Mdp5414WuhUi5lUDA3tGAs1sKEEd2FIDxiI8\n VLqcqgQ1YcvBsUXWKYPf0qT+6Evj8s4/1ysnZ4z/s2lLB59rl3ZKg3UMpguy0ha05vD2 Qw==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Aakash Sasidharan\n <asasidharan@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>,\n Vidya Sagar Velumuri <vvelumuri@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH v3 2/8] crypto/cnxk: remove packet length checks in crypto\n offload", "Date": "Tue, 20 Jun 2023 15:51:00 +0530", "Message-ID": "<20230620102106.3970544-3-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230620102106.3970544-1-ktejasree@marvell.com>", "References": "<20230620102106.3970544-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "NHhV1obLejg-ote-XlmiPOhtNBP9NEWa", "X-Proofpoint-ORIG-GUID": "NHhV1obLejg-ote-XlmiPOhtNBP9NEWa", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-06-20_06,2023-06-16_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Anoob Joseph <anoobj@marvell.com>\n\nWhen performing crypto offload, the packet length of the input/output\nbuffer does not matter. The length that matters is the\ncipher/authentication range specified in crypto_op. Since application\ncan request for ciphering of a small portion of the buffer, the extra\ncomparison of buffer lengths may result in false failures during\nenqueue of OOP operations.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 54 +++--------------------------------\n 1 file changed, 4 insertions(+), 50 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex a85e4c5170..87414eb131 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -2539,23 +2539,6 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t}\n \n \t\tif (unlikely(m_dst != NULL)) {\n-\t\t\tuint32_t pkt_len;\n-\n-\t\t\t/* Try to make room as much as src has */\n-\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_dst);\n-\n-\t\t\tif (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) {\n-\t\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len;\n-\t\t\t\tif (!rte_pktmbuf_append(m_dst, pkt_len)) {\n-\t\t\t\t\tplt_dp_err(\"Not enough space in \"\n-\t\t\t\t\t\t \"m_dst %p, need %u\"\n-\t\t\t\t\t\t \" more\",\n-\t\t\t\t\t\t m_dst, pkt_len);\n-\t\t\t\t\tret = -EINVAL;\n-\t\t\t\t\tgoto err_exit;\n-\t\t\t\t}\n-\t\t\t}\n-\n \t\t\tif (prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0)) {\n \t\t\t\tplt_dp_err(\"Prepare dst iov failed for \"\n \t\t\t\t\t \"m_dst %p\",\n@@ -2650,32 +2633,18 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\tfc_params.dst_iov = fc_params.src_iov = (void *)src;\n \t\tprepare_iov_from_pkt_inplace(m_src, &fc_params, &flags);\n \t} else {\n-\t\tuint32_t pkt_len;\n-\n \t\t/* Out of place processing */\n+\n \t\tfc_params.src_iov = (void *)src;\n \t\tfc_params.dst_iov = (void *)dst;\n \n \t\t/* Store SG I/O in the api for reuse */\n-\t\tif (prepare_iov_from_pkt(m_src, fc_params.src_iov, 0)) {\n+\t\tif (unlikely(prepare_iov_from_pkt(m_src, fc_params.src_iov, 0))) {\n \t\t\tplt_dp_err(\"Prepare src iov failed\");\n \t\t\tret = -EINVAL;\n \t\t\tgoto err_exit;\n \t\t}\n \n-\t\t/* Try to make room as much as src has */\n-\t\tpkt_len = rte_pktmbuf_pkt_len(m_dst);\n-\n-\t\tif (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) {\n-\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len;\n-\t\t\tif (unlikely(rte_pktmbuf_append(m_dst, pkt_len) == NULL)) {\n-\t\t\t\tplt_dp_err(\"Not enough space in m_dst %p, need %u more\", m_dst,\n-\t\t\t\t\t pkt_len);\n-\t\t\t\tret = -EINVAL;\n-\t\t\t\tgoto err_exit;\n-\t\t\t}\n-\t\t}\n-\n \t\tif (unlikely(prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0))) {\n \t\t\tplt_dp_err(\"Prepare dst iov failed for m_dst %p\", m_dst);\n \t\t\tret = -EINVAL;\n@@ -2689,7 +2658,8 @@ fill_pdcp_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\tmdata = alloc_op_meta(&fc_params.meta_buf, m_info->mlen, m_info->pool, infl_req);\n \t\tif (mdata == NULL) {\n \t\t\tplt_dp_err(\"Could not allocate meta buffer\");\n-\t\t\treturn -ENOMEM;\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto err_exit;\n \t\t}\n \t}\n \n@@ -2798,22 +2768,6 @@ fill_pdcp_chain_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t}\n \n \t\tif (unlikely(m_dst != NULL)) {\n-\t\t\tuint32_t pkt_len;\n-\n-\t\t\t/* Try to make room as much as src has */\n-\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_dst);\n-\n-\t\t\tif (unlikely(pkt_len < rte_pktmbuf_pkt_len(m_src))) {\n-\t\t\t\tpkt_len = rte_pktmbuf_pkt_len(m_src) - pkt_len;\n-\t\t\t\tif (!rte_pktmbuf_append(m_dst, pkt_len)) {\n-\t\t\t\t\tplt_dp_err(\"Not enough space in m_dst \"\n-\t\t\t\t\t\t \"%p, need %u more\",\n-\t\t\t\t\t\t m_dst, pkt_len);\n-\t\t\t\t\tret = -EINVAL;\n-\t\t\t\t\tgoto err_exit;\n-\t\t\t\t}\n-\t\t\t}\n-\n \t\t\tif (unlikely(prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0))) {\n \t\t\t\tplt_dp_err(\"Could not prepare m_dst iov %p\", m_dst);\n \t\t\t\tret = -EINVAL;\n", "prefixes": [ "v3", "2/8" ] }