Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128855/?format=api
{ "id": 128855, "url": "http://patchwork.dpdk.org/api/patches/128855/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230620140704.171667-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230620140704.171667-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230620140704.171667-3-david.marchand@redhat.com", "date": "2023-06-20T14:07:02", "name": "[v3,2/4] examples/server_node_efd: simplify build configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "22c009124a904bcd001770c17fe296fc9b3578f4", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230620140704.171667-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 28585, "url": "http://patchwork.dpdk.org/api/series/28585/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28585", "date": "2023-06-20T14:07:04", "name": "Test examples compilation externally", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28585/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128855/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128855/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 52E7942D09;\n\tTue, 20 Jun 2023 16:10:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4021E406BC;\n\tTue, 20 Jun 2023 16:10:04 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 7DAF24068E\n for <dev@dpdk.org>; Tue, 20 Jun 2023 16:10:02 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-606-QzzE1ncVMmm6fo9d1ELrqA-1; Tue, 20 Jun 2023 10:08:50 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98DF6382C98C;\n Tue, 20 Jun 2023 14:07:40 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.210])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8B50A200A398;\n Tue, 20 Jun 2023 14:07:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687270202;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tvU6qbYAw3YkVvlgJ4mqWSaoabVk6dY+uHlqeoEWIBQ=;\n b=VSYBVnTjQvERSr0nW5wf0JzI+2/TPuM3O5aSmTQj8I7DbeWS4eVxzDAVlQqW54mdFnPWfP\n RCoVpa8OMc3qrDg7p7Om7H2mKaufJ1dJ2CXb4EsFR/UDzdMIwlsqSOOHB9fFKkNh3aMQn9\n nwr/tHnoc8EnJqhj0sEbnfs9b16RCiI=", "X-MC-Unique": "QzzE1ncVMmm6fo9d1ELrqA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n Byron Marohn <byron.marohn@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>", "Subject": "[PATCH v3 2/4] examples/server_node_efd: simplify build configuration", "Date": "Tue, 20 Jun 2023 16:07:02 +0200", "Message-Id": "<20230620140704.171667-3-david.marchand@redhat.com>", "In-Reply-To": "<20230620140704.171667-1-david.marchand@redhat.com>", "References": "<20230613081741.4083273-1-david.marchand@redhat.com>\n <20230620140704.171667-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The server_node_efd example contains various binaries whose sources are\nin sub directories that do not match their name.\n\nRename sub directories in this example and stop overriding the binaries\nnames in meson.build.\nThis makes a next change easier in the build scripts used by CI.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nChanges since v2:\n- updated commitlog,\n\n---\n doc/guides/sample_app_ug/server_node_efd.rst | 14 +++++++-------\n examples/meson.build | 4 ++--\n examples/server_node_efd/Makefile | 2 +-\n .../server_node_efd/{node => efd_node}/Makefile | 0\n .../server_node_efd/{node => efd_node}/meson.build | 2 --\n examples/server_node_efd/{node => efd_node}/node.c | 0\n .../{server => efd_server}/Makefile | 0\n .../server_node_efd/{server => efd_server}/args.c | 0\n .../server_node_efd/{server => efd_server}/args.h | 0\n .../server_node_efd/{server => efd_server}/init.c | 0\n .../server_node_efd/{server => efd_server}/init.h | 0\n .../server_node_efd/{server => efd_server}/main.c | 0\n .../{server => efd_server}/meson.build | 2 --\n 13 files changed, 10 insertions(+), 14 deletions(-)\n rename examples/server_node_efd/{node => efd_node}/Makefile (100%)\n rename examples/server_node_efd/{node => efd_node}/meson.build (95%)\n rename examples/server_node_efd/{node => efd_node}/node.c (100%)\n rename examples/server_node_efd/{server => efd_server}/Makefile (100%)\n rename examples/server_node_efd/{server => efd_server}/args.c (100%)\n rename examples/server_node_efd/{server => efd_server}/args.h (100%)\n rename examples/server_node_efd/{server => efd_server}/init.c (100%)\n rename examples/server_node_efd/{server => efd_server}/init.h (100%)\n rename examples/server_node_efd/{server => efd_server}/main.c (100%)\n rename examples/server_node_efd/{server => efd_server}/meson.build (94%)", "diff": "diff --git a/doc/guides/sample_app_ug/server_node_efd.rst b/doc/guides/sample_app_ug/server_node_efd.rst\nindex c6cbc3def6..7253b38da7 100644\n--- a/doc/guides/sample_app_ug/server_node_efd.rst\n+++ b/doc/guides/sample_app_ug/server_node_efd.rst\n@@ -137,7 +137,7 @@ which is used to distribute packets to nodes, which the number of flows\n specified in the command line (1 million, by default).\n \n \n-.. literalinclude:: ../../../examples/server_node_efd/server/init.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_server/init.c\n :language: c\n :start-after: Create EFD table. 8<\n :end-before: >8 End of creation EFD table.\n@@ -146,7 +146,7 @@ After initialization, packets are received from the enabled ports, and the IPv4\n address from the packets is used as a key to look up in the EFD table,\n which tells the node where the packet has to be distributed.\n \n-.. literalinclude:: ../../../examples/server_node_efd/server/main.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_server/main.c\n :language: c\n :start-after: Processing packets. 8<\n :end-before: >8 End of process_packets.\n@@ -156,7 +156,7 @@ and enqueued in the shared ring between the server and the node.\n After this, a new burst of packets is received and this process is\n repeated infinitely.\n \n-.. literalinclude:: ../../../examples/server_node_efd/server/main.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_server/main.c\n :language: c\n :start-after: Flush rx queue. 8<\n :end-before: >8 End of sending a burst of traffic to a node.\n@@ -167,7 +167,7 @@ ring with the server and send them out, if they belong to the node.\n At initialization, it attaches to the server process memory, to have\n access to the shared ring, parameters and statistics.\n \n-.. literalinclude:: ../../../examples/server_node_efd/node/node.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_node/node.c\n :language: c\n :start-after: Attaching to the server process memory. 8<\n :end-before: >8 End of attaching to the server process memory.\n@@ -176,7 +176,7 @@ access to the shared ring, parameters and statistics.\n Then, the hash table that contains the flows that will be handled\n by the node is created and populated.\n \n-.. literalinclude:: ../../../examples/server_node_efd/node/node.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_node/node.c\n :language: c\n :start-after: Creation of hash table. 8<\n :end-before: >8 End of creation of hash table.\n@@ -188,7 +188,7 @@ If there is a hit, packet is stored in a buffer, to be eventually transmitted\n in one of the enabled ports. If key is not there, packet is dropped, since the\n flow is not handled by the node.\n \n-.. literalinclude:: ../../../examples/server_node_efd/node/node.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_node/node.c\n :language: c\n :start-after: Packets dequeued from the shared ring. 8<\n :end-before: >8 End of packets dequeuing.\n@@ -196,7 +196,7 @@ flow is not handled by the node.\n Finally, note that both processes updates statistics, such as transmitted, received\n and dropped packets, which are shown and refreshed by the server app.\n \n-.. literalinclude:: ../../../examples/server_node_efd/server/main.c\n+.. literalinclude:: ../../../examples/server_node_efd/efd_server/main.c\n :language: c\n :start-after: Display recorded statistics. 8<\n :end-before: >8 End of displaying the recorded statistics.\ndiff --git a/examples/meson.build b/examples/meson.build\nindex 6968c09252..55ba8847a0 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -46,8 +46,8 @@ all_examples = [\n 'qos_meter',\n 'qos_sched',\n 'rxtx_callbacks',\n- 'server_node_efd/node',\n- 'server_node_efd/server',\n+ 'server_node_efd/efd_node',\n+ 'server_node_efd/efd_server',\n 'service_cores',\n 'skeleton',\n 'timer',\ndiff --git a/examples/server_node_efd/Makefile b/examples/server_node_efd/Makefile\nindex e4a4a94a79..6d61c93dac 100644\n--- a/examples/server_node_efd/Makefile\n+++ b/examples/server_node_efd/Makefile\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2016-2020 Intel Corporation\n \n-subdirs := node server\n+subdirs := efd_node efd_server\n \n .PHONY: all static shared clean $(subdirs)\n all static shared clean: $(subdirs)\ndiff --git a/examples/server_node_efd/node/Makefile b/examples/server_node_efd/efd_node/Makefile\nsimilarity index 100%\nrename from examples/server_node_efd/node/Makefile\nrename to examples/server_node_efd/efd_node/Makefile\ndiff --git a/examples/server_node_efd/node/meson.build b/examples/server_node_efd/efd_node/meson.build\nsimilarity index 95%\nrename from examples/server_node_efd/node/meson.build\nrename to examples/server_node_efd/efd_node/meson.build\nindex 1c720968af..b03e65f266 100644\n--- a/examples/server_node_efd/node/meson.build\n+++ b/examples/server_node_efd/efd_node/meson.build\n@@ -6,8 +6,6 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n-name = 'efd_node'\n-\n allow_experimental_apis = true\n deps += ['hash']\n sources += files('node.c')\ndiff --git a/examples/server_node_efd/node/node.c b/examples/server_node_efd/efd_node/node.c\nsimilarity index 100%\nrename from examples/server_node_efd/node/node.c\nrename to examples/server_node_efd/efd_node/node.c\ndiff --git a/examples/server_node_efd/server/Makefile b/examples/server_node_efd/efd_server/Makefile\nsimilarity index 100%\nrename from examples/server_node_efd/server/Makefile\nrename to examples/server_node_efd/efd_server/Makefile\ndiff --git a/examples/server_node_efd/server/args.c b/examples/server_node_efd/efd_server/args.c\nsimilarity index 100%\nrename from examples/server_node_efd/server/args.c\nrename to examples/server_node_efd/efd_server/args.c\ndiff --git a/examples/server_node_efd/server/args.h b/examples/server_node_efd/efd_server/args.h\nsimilarity index 100%\nrename from examples/server_node_efd/server/args.h\nrename to examples/server_node_efd/efd_server/args.h\ndiff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/efd_server/init.c\nsimilarity index 100%\nrename from examples/server_node_efd/server/init.c\nrename to examples/server_node_efd/efd_server/init.c\ndiff --git a/examples/server_node_efd/server/init.h b/examples/server_node_efd/efd_server/init.h\nsimilarity index 100%\nrename from examples/server_node_efd/server/init.h\nrename to examples/server_node_efd/efd_server/init.h\ndiff --git a/examples/server_node_efd/server/main.c b/examples/server_node_efd/efd_server/main.c\nsimilarity index 100%\nrename from examples/server_node_efd/server/main.c\nrename to examples/server_node_efd/efd_server/main.c\ndiff --git a/examples/server_node_efd/server/meson.build b/examples/server_node_efd/efd_server/meson.build\nsimilarity index 94%\nrename from examples/server_node_efd/server/meson.build\nrename to examples/server_node_efd/efd_server/meson.build\nindex 7abc333e1d..f1a6616738 100644\n--- a/examples/server_node_efd/server/meson.build\n+++ b/examples/server_node_efd/efd_server/meson.build\n@@ -6,8 +6,6 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n-name = 'efd_server'\n-\n allow_experimental_apis = true\n deps += 'efd'\n sources += files('args.c', 'init.c', 'main.c')\n", "prefixes": [ "v3", "2/4" ] }