Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128897/?format=api
{ "id": 128897, "url": "http://patchwork.dpdk.org/api/patches/128897/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230621170058.2740340-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230621170058.2740340-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230621170058.2740340-5-david.marchand@redhat.com", "date": "2023-06-21T17:00:58", "name": "[v4,4/4] build: select optional libraries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "699c9bbc85ece92e6740844c178dc918704cf0a4", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230621170058.2740340-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 28608, "url": "http://patchwork.dpdk.org/api/series/28608/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28608", "date": "2023-06-21T17:00:54", "name": "Select optional libraries", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28608/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128897/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/128897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 691EC42D16;\n\tWed, 21 Jun 2023 19:01:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2892042D20;\n\tWed, 21 Jun 2023 19:01:30 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 028A242D17\n for <dev@dpdk.org>; Wed, 21 Jun 2023 19:01:28 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-98-TYQHZJm5MEe9EDUQOw-8sQ-1; Wed, 21 Jun 2023 13:01:25 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 65D428C5862;\n Wed, 21 Jun 2023 17:01:22 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.210])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D51552166B32;\n Wed, 21 Jun 2023 17:01:20 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1687366888;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ECcuUp0eX0i37ZYWdTvx/gUJP84tFuyCnva1kptr3Rw=;\n b=NxUWJhT5wCW9rBkIyNT6p9pUy0inPM0b2N8S90jO1wTeoChAzHM4z401/qRJLz2dcEeZp2\n JJUQrJhvALcI7820NoKIzPMyVPw0TSiZuN/napjXp3BupcUxWGnhNVBkbKKiDewBkLZLSi\n hw02DQAox6STnq8Bn0W4JmuP7GZ72wg=", "X-MC-Unique": "TYQHZJm5MEe9EDUQOw-8sQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com,\n i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v4 4/4] build: select optional libraries", "Date": "Wed, 21 Jun 2023 19:00:58 +0200", "Message-Id": "<20230621170058.2740340-5-david.marchand@redhat.com>", "In-Reply-To": "<20230621170058.2740340-1-david.marchand@redhat.com>", "References": "<20211117112847.7362-6-david.marchand@redhat.com>\n <20230621170058.2740340-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is currently no way to know which libraries are optional.\nIntroduce a enable_libs option (close to what we have for drivers) so\nthat packagers or projects consuming DPDK can more easily select the\noptional libraries that matter to them and disable other optional\nlibraries.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nChanges since v3:\n- split non related cleanup changes,\n- fixed false positive complaints about disabling mandatory libs by\n building the list of always enabled libs, appending this list to\n enable_list and checking the disable side,\n- updated enable/disable_libs descriptions,\n\nChanges since v2:\n- moved the IOVA check for kni build in lib/kni/meson.build,\n- reworked deprecated libraries handling by only considering them when\n no enable_libs option is set. With this, no need for a default value\n in meson_options.txt, yet configurations in the CI must be adjusted,\n- moved mandatory libraries check after enable/disable_libs evaluation,\n\n---\n lib/meson.build | 33 +++++++++++++++++++++++----------\n meson_options.txt | 4 +++-\n 2 files changed, 26 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/meson.build b/lib/meson.build\nindex a6e9e19b42..407769b270 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -92,17 +92,20 @@ dpdk_libs_deprecated += [\n 'kni',\n ]\n \n-disabled_libs = []\n-opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),\n- check: true).stdout().split()\n-foreach l:opt_disabled_libs\n+disable_libs = run_command(list_dir_globs, get_option('disable_libs'), check: true).stdout().split()\n+\n+enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true).stdout().split()\n+if enable_libs.length() == 0\n+ enable_libs += optional_libs\n+endif\n+\n+always_enable = []\n+foreach l:libraries\n if not optional_libs.contains(l)\n- warning('Cannot disable mandatory library \"@0@\"'.format(l))\n- continue\n+ always_enable += l\n endif\n- disabled_libs += l\n endforeach\n-\n+enable_libs += always_enable\n \n default_cflags = machine_args\n default_cflags += ['-DALLOW_EXPERIMENTAL_API']\n@@ -139,12 +142,22 @@ foreach l:libraries\n if dpdk_libs_deprecated.contains(l) and not get_option('enable_deprecated_libs')\n build = false\n reason = 'deprecated libraries disabled via build config'\n- elif disabled_libs.contains(l)\n+ elif not enable_libs.contains(l)\n build = false\n- reason = 'explicitly disabled via build config'\n+ reason = 'not in enabled libraries build config'\n if dpdk_libs_deprecated.contains(l)\n reason += ' (deprecated lib)'\n endif\n+ elif disable_libs.contains(l)\n+ if always_enable.contains(l)\n+ warning('Cannot disable mandatory library \"@0@\"'.format(l))\n+ else\n+ build = false\n+ reason = 'explicitly disabled via build config'\n+ if dpdk_libs_deprecated.contains(l)\n+ reason += ' (deprecated lib)'\n+ endif\n+ endif\n endif\n \n if build\ndiff --git a/meson_options.txt b/meson_options.txt\nindex f959015e46..9951563146 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -11,7 +11,7 @@ option('disable_apps', type: 'string', value: '', description:\n option('disable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to explicitly disable.')\n option('disable_libs', type: 'string', value: '', description:\n- 'Comma-separated list of libraries to explicitly disable. [NOTE: not all libs can be disabled]')\n+ 'Comma-separated list of optional libraries to explicitly disable. [NOTE: mandatory libs cannot be disabled]')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', description:\n 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n option('enable_docs', type: 'boolean', value: false, description:\n@@ -26,6 +26,8 @@ option('enable_driver_sdk', type: 'boolean', value: false, description:\n 'Install headers to build drivers.')\n option('enable_kmods', type: 'boolean', value: false, description:\n 'build kernel modules')\n+option('enable_libs', type: 'string', value: '', description:\n+ 'Comma-separated list of optional libraries to explicitly enable. [NOTE: mandatory libs are always enabled]')\n option('examples', type: 'string', value: '', description:\n 'Comma-separated list of examples to build by default')\n option('ibverbs_link', type: 'combo', choices : ['static', 'shared', 'dlopen'], value: 'shared', description:\n", "prefixes": [ "v4", "4/4" ] }