Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129004/?format=api
{ "id": 129004, "url": "http://patchwork.dpdk.org/api/patches/129004/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230626184223.155390-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230626184223.155390-2-stephen@networkplumber.org", "date": "2023-06-26T18:42:12", "name": "[v4,1/5] eal: unify logging code for FreeBsd and Linux", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "faff756e5618e4db0f73abad5de0c9a30b6c74df", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 28655, "url": "http://patchwork.dpdk.org/api/series/28655/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28655", "date": "2023-06-26T18:42:11", "name": "Logging related patchs", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28655/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129004/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129004/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C9D9242D5F;\n\tMon, 26 Jun 2023 20:42:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 717EE4282D;\n\tMon, 26 Jun 2023 20:42:54 +0200 (CEST)", "from mail-pj1-f43.google.com (mail-pj1-f43.google.com\n [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 7A7A84013F\n for <dev@dpdk.org>; Mon, 26 Jun 2023 20:42:52 +0200 (CEST)", "by mail-pj1-f43.google.com with SMTP id\n 98e67ed59e1d1-263036d54b9so579899a91.0\n for <dev@dpdk.org>; Mon, 26 Jun 2023 11:42:52 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h17-20020a17090adb9100b0024e37e0a67dsm4846577pjv.20.2023.06.26.11.42.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 26 Jun 2023 11:42:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687804971;\n x=1690396971;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=c9U9tE8eQy1k4qcUEU4AcbFdTUvpWcsxv69ky9xBapE=;\n b=uW0hwNlxf2vdvgQfKwJtJdaxv9XAIYGAObq9sw1Vvqlh4Viwjsdb54ajMFJGoFWaMH\n bv2dZe1arCZMhGBnVpeb+y+HCs/TffoxTXMwjA/l158/dLCPrQdF93ZGKj8gH+WSe67i\n G2ZFAPQi/LfKudzwPS2Pp9V+Fiyk12xIjcfnhbpVQf6INS4Xr9H1ilHIJoMgLBoo28Ta\n iOOt/676TWDDoBYlzNV77GFxy50TpGsbv3LiTigJyrC/fpEbA60uZN2MMKl2WzAgBg8Y\n uqWy0Q+MFqMx3TNnDrouODvfmIbRCDqScHhXOO2AgyJ12LvCH5X94Wo/qM2d8LcdoRof\n HSSg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687804971; x=1690396971;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=c9U9tE8eQy1k4qcUEU4AcbFdTUvpWcsxv69ky9xBapE=;\n b=jewwou4TDxRmvB2fP4Q4ln9yWD+ebSThRfaVPYMeCOcnY/9bjxLZVbstPXRLxCOs9q\n NYkMnPm+/TQdLgXbCzWDeoFzTadJjiWrofFIWYPNytaLgqt7UoRy/Ohl3DntTn1m/llC\n twxhl+95CB1LwBm4W5g6v6GYsWdZKDTagMub9x2y7Y3V3X1YVKwdG7JPhdmnVeXOvanz\n v+jbuR3AnbLTkqE5YPsw2r3sBt0VqONwOBxPA0fQHGHXZwMqATpSPUezvFNScJWvJAos\n CYPt0B0YMG4nmC8B6dMk/Y8VhRynVyTGnL2hecY5HuJ9KsS0odqEF4+1LQkFbCEs8kWq\n Da/w==", "X-Gm-Message-State": "AC+VfDwZ1gJGD+XyQJfxwhVfGz1keBbAz50z8d1PURqez2XG8UWD98+B\n RYPV2xXgu/6rD/4xmITmY7m+EpoxaQEIsfKp0x/YFg==", "X-Google-Smtp-Source": "\n ACHHUZ6lpWXw6fZ+MN5uKbxk/snPMQk7C0yTYuPOjrIru6V1y4Q8CJnyzgF87DHC2zua1EsoTmXvUA==", "X-Received": "by 2002:a17:90b:e8d:b0:262:e598:6046 with SMTP id\n fv13-20020a17090b0e8d00b00262e5986046mr5662110pjb.28.1687804971389;\n Mon, 26 Jun 2023 11:42:51 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v4 1/5] eal: unify logging code for FreeBsd and Linux", "Date": "Mon, 26 Jun 2023 11:42:12 -0700", "Message-Id": "<20230626184223.155390-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230626184223.155390-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230626184223.155390-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "FreeBSD logging code was not using syslog and did not have\nthe same options as Linux. Move the log writing code to common\nsource tree.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n .../freebsd_gsg/freebsd_eal_parameters.rst | 27 +++++++++++++++++++\n lib/eal/freebsd/eal.c | 7 +++++\n lib/eal/linux/meson.build | 1 -\n lib/eal/{linux => unix}/eal_log.c | 0\n lib/eal/unix/meson.build | 1 +\n 5 files changed, 35 insertions(+), 1 deletion(-)\n rename lib/eal/{linux => unix}/eal_log.c (100%)", "diff": "diff --git a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst\nindex fba467a2ce92..9270d9fa3bfc 100644\n--- a/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst\n+++ b/doc/guides/freebsd_gsg/freebsd_eal_parameters.rst\n@@ -18,3 +18,30 @@ FreeBSD-specific EAL parameters\n -------------------------------\n \n There are currently no FreeBSD-specific EAL command-line parameters available.\n+\n+Other options\n+~~~~~~~~~~~~~\n+\n+* ``--syslog <syslog facility>``\n+\n+ Set syslog facility. Valid syslog facilities are::\n+\n+ auth\n+ cron\n+ daemon\n+ ftp\n+ kern\n+ lpr\n+ mail\n+ news\n+ syslog\n+ user\n+ uucp\n+ local0\n+ local1\n+ local2\n+ local3\n+ local4\n+ local5\n+ local6\n+ local7\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 7008303e112a..6df6873e3889 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -52,6 +52,7 @@\n #include \"eal_hugepages.h\"\n #include \"eal_options.h\"\n #include \"eal_memcfg.h\"\n+#include \"eal_log.h\"\n #include \"eal_trace.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n@@ -759,6 +760,12 @@ rte_eal_init(int argc, char **argv)\n #endif\n \t}\n \n+\tif (eal_log_init(getprogname(), internal_conf->syslog_facility) < 0) {\n+\t\trte_eal_init_alert(\"Cannot init logging.\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn -1;\n+\t}\n+\n \t/* in secondary processes, memory init may allocate additional fbarrays\n \t * not present in primary processes, so to avoid any potential issues,\n \t * initialize memzones first.\ndiff --git a/lib/eal/linux/meson.build b/lib/eal/linux/meson.build\nindex 5af456db9edb..e99ebed25692 100644\n--- a/lib/eal/linux/meson.build\n+++ b/lib/eal/linux/meson.build\n@@ -11,7 +11,6 @@ sources += files(\n 'eal_hugepage_info.c',\n 'eal_interrupts.c',\n 'eal_lcore.c',\n- 'eal_log.c',\n 'eal_memalloc.c',\n 'eal_memory.c',\n 'eal_thread.c',\ndiff --git a/lib/eal/linux/eal_log.c b/lib/eal/unix/eal_log.c\nsimilarity index 100%\nrename from lib/eal/linux/eal_log.c\nrename to lib/eal/unix/eal_log.c\ndiff --git a/lib/eal/unix/meson.build b/lib/eal/unix/meson.build\nindex cc7d67dd321d..37d07594df29 100644\n--- a/lib/eal/unix/meson.build\n+++ b/lib/eal/unix/meson.build\n@@ -6,6 +6,7 @@ sources += files(\n 'eal_file.c',\n 'eal_filesystem.c',\n 'eal_firmware.c',\n+ 'eal_log.c',\n 'eal_unix_memory.c',\n 'eal_unix_thread.c',\n 'eal_unix_timer.c',\n", "prefixes": [ "v4", "1/5" ] }