Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129005/?format=api
http://patchwork.dpdk.org/api/patches/129005/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230626184223.155390-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230626184223.155390-3-stephen@networkplumber.org", "date": "2023-06-26T18:42:13", "name": "[v4,2/5] eal: turn off getopt_long error message during eal_log_level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "51265746dbf3d957cebf7f01a7bd460630c58f35", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28655, "url": "http://patchwork.dpdk.org/api/series/28655/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28655", "date": "2023-06-26T18:42:11", "name": "Logging related patchs", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28655/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129005/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F9B942D5F;\n\tMon, 26 Jun 2023 20:43:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 82E5542BDA;\n\tMon, 26 Jun 2023 20:42:55 +0200 (CEST)", "from mail-oi1-f173.google.com (mail-oi1-f173.google.com\n [209.85.167.173])\n by mails.dpdk.org (Postfix) with ESMTP id 94EE841148\n for <dev@dpdk.org>; Mon, 26 Jun 2023 20:42:53 +0200 (CEST)", "by mail-oi1-f173.google.com with SMTP id\n 5614622812f47-39eab4bbe8aso2590099b6e.1\n for <dev@dpdk.org>; Mon, 26 Jun 2023 11:42:53 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h17-20020a17090adb9100b0024e37e0a67dsm4846577pjv.20.2023.06.26.11.42.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 26 Jun 2023 11:42:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687804972;\n x=1690396972;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BXFQnhgwaB8ReFX0BeRWCGxQKFeLEqIvzBfOxM7c12w=;\n b=OeV+BfJ2J6Ub/9ldy/L3GIMtuANeTsxX7Tz2lDObTvrvuqBJSpQRIvklry8bT3DDMm\n DXpcS9Um4v+Taot2/InEBE0KIuaPi6a0ARGEzP5Klc1rmDkvpaVX1oxfvU70p7ZbWC6/\n 2No99xP37zQqHpAUBnz80iCo3UZK9Xd71t7E94iXUq+Np43bkMcPGM0q5xIe5FJ22FZ6\n /6BQwDd/3uY2oexDy1Rz9Q9QX8bTVw33KkSb5kGAGGQgl/yP3ew6CwGxYZrdLk374sCc\n nfPeOq0zBaaycGL8RmIndLo5uzXD7R8FupfGK53OEeqtafD0RWN8L+E/eL7laTtICO8+\n Jm7A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687804972; x=1690396972;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=BXFQnhgwaB8ReFX0BeRWCGxQKFeLEqIvzBfOxM7c12w=;\n b=F7QZm+7N95GqeVi0GPJIt1pHL3qiroASKKw7blyXXscAAv3BInvoxF5AeemoqiRV0x\n WMUXtmJW3o+JHfSebAyS8N86kKfMo5ZDembqDYzG53v9jX4C4ODTUf1buFoRHhqGYpoF\n 0n5KHcu0YYPV9VjPq7EI7jH/9aiMmYGutkuMjyQcowJIKb01mEVCxNxPHZmBVM6N06XN\n CcSxM9Au7DS/ySg3Xot5RfDbiGwFcNKBkQKldn6wDP0NaATghmtL02S1AGwOMUv5x58/\n RPA1i7iT8LC3M2oA1XWYo30H8BF50DxsEO0wcFchnBrFlk9Y10kU7fje+QcdhGxZpDUS\n LAiQ==", "X-Gm-Message-State": "AC+VfDwtc1UEWA0BDzGHSjnCrfZtCiQjCTf+G9Ag22UpucEaMDYTCPxr\n F1z9vw8fO3sQLsO1WVlhb0bosBz5jHH8EgOo9E9psg==", "X-Google-Smtp-Source": "\n ACHHUZ7R1MFyirV/G/ovPyL/KcKR2XKbFVoN1B2+O0L9MBurR1TNJFDcB2a4IWpRIMdkd2Ie9LgCEA==", "X-Received": "by 2002:a05:6808:1392:b0:3a1:b2d4:5f64 with SMTP id\n c18-20020a056808139200b003a1b2d45f64mr12868303oiw.54.1687804972496;\n Mon, 26 Jun 2023 11:42:52 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Keith Wiles <keith.wiles@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v4 2/5] eal: turn off getopt_long error message during\n eal_log_level", "Date": "Mon, 26 Jun 2023 11:42:13 -0700", "Message-Id": "<20230626184223.155390-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230626184223.155390-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230626184223.155390-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If DPDK application is given a bogus option, the error message\nwould get printed twice. Once during scan for log level and\nagain during parsing of arguments.\n\nExample:\n\t# ./build/app/dpdk-testpmd --bogus\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\tEAL: Detected CPU lcores: 16\n\tEAL: Detected NUMA nodes: 1\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\n\tUsage: ./build/app/dpdk-testpmd [options]\n\nFix by suppressing printing error message on first pass.\n\nSigned-off-by: Keith Wiles <keith.wiles@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/freebsd/eal.c | 2 ++\n lib/eal/linux/eal.c | 2 ++\n lib/eal/windows/eal.c | 3 +++\n 3 files changed, 7 insertions(+)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 6df6873e3889..70087837da18 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -381,6 +381,7 @@ eal_log_level_parse(int argc, char **argv)\n \targvopt = argv;\n \toptind = 1;\n \toptreset = 1;\n+\topterr = 0;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\n@@ -424,6 +425,7 @@ eal_parse_args(int argc, char **argv)\n \targvopt = argv;\n \toptind = 1;\n \toptreset = 1;\n+\topterr = 1;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 145afafde234..60bb130aea15 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -561,6 +561,7 @@ eal_log_level_parse(int argc, char **argv)\n \n \targvopt = argv;\n \toptind = 1;\n+\topterr = 0;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\n@@ -638,6 +639,7 @@ eal_parse_args(int argc, char **argv)\n \n \targvopt = argv;\n \toptind = 1;\n+\topterr = 1;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 2d7a0e9ab27e..0800a9e5c2d2 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -106,6 +106,8 @@ eal_log_level_parse(int argc, char **argv)\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n \n+\topterr = 0;\n+\n \targvopt = argv;\n \n \teal_reset_internal_config(internal_conf);\n@@ -143,6 +145,7 @@ eal_parse_args(int argc, char **argv)\n \t\teal_get_internal_configuration();\n \n \targvopt = argv;\n+\topterr = 1;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\teal_long_options, &option_index)) != EOF) {\n", "prefixes": [ "v4", "2/5" ] }{ "id": 129005, "url": "