Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129006/?format=api
{ "id": 129006, "url": "http://patchwork.dpdk.org/api/patches/129006/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230626184223.155390-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230626184223.155390-4-stephen@networkplumber.org", "date": "2023-06-26T18:42:14", "name": "[v4,3/5] eal: skip stdio on console logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5722afb4dc2cf10d07933e7e5712ba482bc5ea4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230626184223.155390-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 28655, "url": "http://patchwork.dpdk.org/api/series/28655/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28655", "date": "2023-06-26T18:42:11", "name": "Logging related patchs", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28655/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129006/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E85F742D5F;\n\tMon, 26 Jun 2023 20:43:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AAEE842D10;\n\tMon, 26 Jun 2023 20:42:57 +0200 (CEST)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id 83C2542B8C\n for <dev@dpdk.org>; Mon, 26 Jun 2023 20:42:54 +0200 (CEST)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-66f3fc56ef4so1256370b3a.0\n for <dev@dpdk.org>; Mon, 26 Jun 2023 11:42:54 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h17-20020a17090adb9100b0024e37e0a67dsm4846577pjv.20.2023.06.26.11.42.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 26 Jun 2023 11:42:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687804973;\n x=1690396973;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vVW03ARTqWY9Do/0GxaVPJKlzSZSxWklKq2PkjbpES4=;\n b=qEvpYTmTfrKECiCN0IvpceXWT7oBMJyNb8HnKdet8q92cafWlUvXs0eK9B6ZCgNnkV\n tmiu60es/FTMizVTMt7pRACBvPXRN9nd0ZvHInEKiw5AMDvoAG6wMpvSGgCWKesi2U6c\n M48cZ1dCf16Nmnv+y7bU9Hv9tQi3JzkZm3kF1+E8eQawfQ4ZcX5LRoaJ++ltRbmGH3Ai\n uFwBEZfVTA4Ssll9j+OR9j77AHFXMe0nuyDR4TkMUl/rmRzfkhwNdTe5Hw9QQqdGq7nK\n 5ZhhZuFB3kZU38RXXhJ/rccB55Ib1dlENJjcSFyCo91awTRhuNtrp6v6YhGZ0HTiKvpe\n 2pUg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687804973; x=1690396973;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vVW03ARTqWY9Do/0GxaVPJKlzSZSxWklKq2PkjbpES4=;\n b=YjW1Aj1qiAfhlSVQg6RxOIoEWfR24BJ0W0qk2UEEI5VOBb7n2VoSi4JYK0GJKjOaf1\n tpUVLVHWgOnroPma8Exrh2rga1jgH+RouT9yt6nU2XoQVXZCh2yWncr/3mgZYuEde/rR\n 0kp1bAMaYTMK8f/oFgUF6+pTxL3RK4X2OaKoZPrmR2FU4AkQg6BplALIV2WeIDwMi0Qo\n uNIF71MViiDP1v5yOTSECoNUzG/VnFGb4TXbNsOlp8d+UVGJWOR1dWjhZ1VbHetFJYNN\n N92tS7+2Y932jR32Q5SeEPPbKDBn8+2hM/DKi/+kUDXT4c3GgeApb+RxRPdzIYTT8W2X\n QA7Q==", "X-Gm-Message-State": "AC+VfDyzijelktd4SfyCuBehFEoGpOe3gcN2aUaV7DGdgj0VSGABNMfx\n GfFd0/vu3RZQwNLzL8yqodZFR1PyFV5NRTmXZHvUpQ==", "X-Google-Smtp-Source": "\n ACHHUZ5sei8yL/enBNSLTtcGQFbLLTeKksvKKfbwHsCdn9fMQt4tAQ2tdDffJvup9Ow/O0qTTuHgEA==", "X-Received": "by 2002:a17:90b:350e:b0:262:eb20:2dd8 with SMTP id\n ls14-20020a17090b350e00b00262eb202dd8mr5702704pjb.20.1687804973455;\n Mon, 26 Jun 2023 11:42:53 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v4 3/5] eal: skip stdio on console logging", "Date": "Mon, 26 Jun 2023 11:42:14 -0700", "Message-Id": "<20230626184223.155390-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230626184223.155390-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230626184223.155390-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is no need to use stdio when logging to console.\nUsing the write system call directly avoids unnecessary copy\nto stdio output buffer.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/unix/eal_log.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex d44416fd6570..baa721021991 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -5,6 +5,7 @@\n #include <stdio.h>\n #include <sys/types.h>\n #include <syslog.h>\n+#include <unistd.h>\n \n #include <rte_log.h>\n \n@@ -19,8 +20,7 @@ console_log_write(__rte_unused void *c, const char *buf, size_t size)\n \tssize_t ret;\n \n \t/* write on stderr */\n-\tret = fwrite(buf, 1, size, stderr);\n-\tfflush(stderr);\n+\tret = write(STDERR_FILENO, buf, size);\n \n \t/* Syslog error levels are from 0 to 7, so subtract 1 to convert */\n \tsyslog(rte_log_cur_msg_loglevel() - 1, \"%.*s\", (int)size, buf);\n", "prefixes": [ "v4", "3/5" ] }