Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129044/?format=api
{ "id": 129044, "url": "http://patchwork.dpdk.org/api/patches/129044/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230628091218.32292-1-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230628091218.32292-1-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230628091218.32292-1-junfeng.guo@intel.com", "date": "2023-06-28T09:12:18", "name": "[v2] raw/ntb: add check for disabling interrupt in dev close ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b624c62ca92285fee2b1e75312183e1b565ac0b1", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230628091218.32292-1-junfeng.guo@intel.com/mbox/", "series": [ { "id": 28684, "url": "http://patchwork.dpdk.org/api/series/28684/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28684", "date": "2023-06-28T09:12:18", "name": "[v2] raw/ntb: add check for disabling interrupt in dev close ops", "version": 2, "mbox": "http://patchwork.dpdk.org/series/28684/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129044/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B762C42D7E;\n\tWed, 28 Jun 2023 11:12:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A3D2F40151;\n\tWed, 28 Jun 2023 11:12:33 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 4A55E400EF;\n Wed, 28 Jun 2023 11:12:31 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jun 2023 02:12:28 -0700", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.149])\n by FMSMGA003.fm.intel.com with ESMTP; 28 Jun 2023 02:12:24 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1687943552; x=1719479552;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Iul6MbfnEnWqwaK58IwT5UNz5tLNu7KeWCPzp0K81gw=;\n b=PZyUobacZcyW+4z/RFlyrBMDiDSt/xPvhB8WOe1MxjP8Me7sgQbwV3hn\n wZKRFF6RqBRxUeRIbis0RSSDq125XeWkTRnxtkzicAxVvBP/DA7I1J4aw\n XzskgpAuaZriLVLBM4mdVg8iysXk5QqD++9HU30DsSswDHJ3HJ/frNSD4\n 04shG/VOF2LDhOSaluu7WEnVa5AoXMYZmvGSyNmDdRLAywVXx1CgU+Yqx\n NJJYPNqWEjXFhzCz6FTj890B7QOcKLr9kJgHV3KYKqSfBqOGpDG5lnc0C\n dL9hbveVYd6+kZCESjclO2NsEBY0emaQiIcsCNDI4bhRSd/5xLV2hh8uZ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10754\"; a=\"448179250\"", "E=Sophos;i=\"6.01,165,1684825200\"; d=\"scan'208\";a=\"448179250\"", "E=McAfee;i=\"6600,9927,10754\"; a=\"806826490\"", "E=Sophos;i=\"6.01,165,1684825200\"; d=\"scan'208\";a=\"806826490\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org, stable@dpdk.org, xingguang.he@intel.com,\n kevin.laatz@intel.com, Junfeng Guo <junfeng.guo@intel.com>", "Subject": "[PATCH v2] raw/ntb: add check for disabling interrupt in dev close\n ops", "Date": "Wed, 28 Jun 2023 17:12:18 +0800", "Message-Id": "<20230628091218.32292-1-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230614051423.176572-1-junfeng.guo@intel.com>", "References": "<20230614051423.176572-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "During EAL cleanup stage, all bus devices are cleaned up properly.\nIn the meantime, the ntb example app will also do the device cleanup\nprocess, which may call the dev ops '*dev->dev_ops->dev_close' twice.\n\nIf this dev ops for ntb was called twice, the interrupt handle for\nEAL will be disabled twice and will lead to error for the seconde\ntime. Like this: \"EAL: Error disabling MSI-X interrupts for fd xx\"\n\nThus, this patch added the check process for disabling interrupt in\ndev_close ops, to ensure that interrupt only be disabled once.\n\nFixes: 1cab1a40ea9b (\"bus: cleanup devices on shutdown\")\nCc: stable@dpdk.org\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/raw/ntb/ntb.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c\nindex 76e98fe515..0ed4c14592 100644\n--- a/drivers/raw/ntb/ntb.c\n+++ b/drivers/raw/ntb/ntb.c\n@@ -1045,6 +1045,11 @@ ntb_dev_close(struct rte_rawdev *dev)\n \thw->queue_pairs = 0;\n \n \tintr_handle = hw->pci_dev->intr_handle;\n+\t/* Disable interrupt only once */\n+\tif (!rte_intr_nb_efd_get(intr_handle) &&\n+\t !rte_intr_max_intr_get(intr_handle))\n+\t\treturn 0;\n+\n \t/* Clean datapath event and vec mapping */\n \trte_intr_efd_disable(intr_handle);\n \trte_intr_vec_list_free(intr_handle);\n", "prefixes": [ "v2" ] }