Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129079/?format=api
{ "id": 129079, "url": "http://patchwork.dpdk.org/api/patches/129079/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230628175827.471909-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230628175827.471909-3-stephen@networkplumber.org", "date": "2023-06-28T17:58:23", "name": "[v5,2/6] eal: turn off getopt_long error message during eal_log_level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fcf27fa254f70cc5605391e9e3f62c8c61ed26f3", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28695, "url": "http://patchwork.dpdk.org/api/series/28695/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28695", "date": "2023-06-28T17:58:21", "name": "Logging related patches", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28695/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129079/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7382342D82;\n\tWed, 28 Jun 2023 19:58:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 373E742BC9;\n\tWed, 28 Jun 2023 19:58:37 +0200 (CEST)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 7B68C40E2D\n for <dev@dpdk.org>; Wed, 28 Jun 2023 19:58:33 +0200 (CEST)", "by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-1b809354a15so1358885ad.1\n for <dev@dpdk.org>; Wed, 28 Jun 2023 10:58:33 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n g11-20020a170902868b00b001b80d399730sm5047875plo.242.2023.06.28.10.58.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 28 Jun 2023 10:58:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687975112;\n x=1690567112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aFjKo6J4vWeRRCmVV+Rnr9f2wmRMmQKTwPLzfJX+Zig=;\n b=QoAH45mZWwwHJNldwyjBElKlRc/eYcVVaunhTg7D86NtWQwLcth65peFRa9U/u7Uoa\n cxv7uiEILXO8GLd3ntAxaSesGX2aQ6yHHaFI/HDYFrgEE/Deg2NTcog0LxkZQQ2STAjg\n AiMFyFHCZtoQx6ux76kZUEwXHxMWfk8vMg6hwPZUI/Aaq8j2vKytbxFE73UKlxV0Tvdd\n RmGiioEh3XQ2XEsWoej+01CggDp/K9JmReiojNqX0/t8fablaeOQtSZ7nL0RzHk62vmA\n RT+r+y8bc1PetWSVUi8eVeNvWm1/vrupabqiSQI6+DD49FCd8kwWdFau7Kip/+HPC4cH\n QbdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687975112; x=1690567112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=aFjKo6J4vWeRRCmVV+Rnr9f2wmRMmQKTwPLzfJX+Zig=;\n b=mGdgDds0pIpfdShltowhpvZECLmo1Za9gHqxhEUPIRyp6vevtJB8BmluSKDgHUK0at\n EBJ7tLi6yLpBvxEAVVauDc1n2IORC15yGNb37//1EFEQasLIAfW9BPdWcGNDa+2rd2ny\n JGiAh0bYTFa19v/MK22q/X1c+Bgu0bHcjL2s8Zd/OacDGyEsZqlnmpdnuLHRCi+yy4ib\n 6t0AX0DsF04VJAaj9jM01OGw/m27EbhXRSqvRC66Bk0N5fP7zSqGBpjuLLfDWEY0bbmc\n gP5SNnEjRRJPf4BQzH4vvnhCnoTL6tBSgcBCiOWFhUgmMnzl3y5riGM2JaITON5Tkzye\n 8mNQ==", "X-Gm-Message-State": "AC+VfDwpOdQ/jskWqJH4YQ67nTEKh7LzrR4gKxMx1UBKgxupi4fRyeIo\n ujusp0pa7IZuMIy5S6fzQKRsz2kEjtL73SXI0cQXeA==", "X-Google-Smtp-Source": "\n ACHHUZ6tMonIqY9rBnBaj7pQcYjapvHcPWgVciry/yc0SdbUdQkyZ2+Z0eroBRmIju9AsNnMR7n46Q==", "X-Received": "by 2002:a17:902:c1c5:b0:1b8:11b9:d40a with SMTP id\n c5-20020a170902c1c500b001b811b9d40amr5652148plc.69.1687975112237;\n Wed, 28 Jun 2023 10:58:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Keith Wiles <keith.wiles@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v5 2/6] eal: turn off getopt_long error message during\n eal_log_level", "Date": "Wed, 28 Jun 2023 10:58:23 -0700", "Message-Id": "<20230628175827.471909-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230628175827.471909-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230628175827.471909-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If DPDK application is given a bogus option, the error message\nwould get printed twice. Once during scan for log level and\nagain during parsing of arguments.\n\nExample:\n\t# ./build/app/dpdk-testpmd --bogus\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\tEAL: Detected CPU lcores: 16\n\tEAL: Detected NUMA nodes: 1\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\n\tUsage: ./build/app/dpdk-testpmd [options]\n\nFix by suppressing printing error message on first pass.\n\nSigned-off-by: Keith Wiles <keith.wiles@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/unix/eal_log.c | 3 +++\n lib/eal/windows/eal.c | 3 +++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex f8a5c853f2df..3f54284494d7 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -64,12 +64,14 @@ eal_log_level_parse(int argc, char *const argv[])\n \tint option_index, opt;\n \tconst int old_optind = optind;\n \tconst int old_optopt = optopt;\n+\tconst int old_opterr = opterr;\n \tchar * const old_optarg = optarg;\n #ifdef RTE_EXEC_ENV_FREEBSD\n \tconst int old_optrset = optreset;\n #endif\n \n \toptind = 1;\n+\topterr = 0;\n #ifdef RTE_EXEC_ENV_FREEBSD\n \toptreset = 1;\n #endif\n@@ -94,6 +96,7 @@ eal_log_level_parse(int argc, char *const argv[])\n \toptind = old_optind;\n \toptopt = old_optopt;\n \toptarg = old_optarg;\n+\topterr = old_opterr;\n #ifdef RTE_EXEC_ENV_FREEBSD\n \toptreset = old_optreset;\n #endif\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 2d7a0e9ab27e..0800a9e5c2d2 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -106,6 +106,8 @@ eal_log_level_parse(int argc, char **argv)\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\n \n+\topterr = 0;\n+\n \targvopt = argv;\n \n \teal_reset_internal_config(internal_conf);\n@@ -143,6 +145,7 @@ eal_parse_args(int argc, char **argv)\n \t\teal_get_internal_configuration();\n \n \targvopt = argv;\n+\topterr = 1;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\teal_long_options, &option_index)) != EOF) {\n", "prefixes": [ "v5", "2/6" ] }