Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129080/?format=api
http://patchwork.dpdk.org/api/patches/129080/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230628175827.471909-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230628175827.471909-4-stephen@networkplumber.org", "date": "2023-06-28T17:58:24", "name": "[v5,3/6] eal: fix handling of syslog facility", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "634e82f35f112118606a390098427897681aee6a", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 28695, "url": "http://patchwork.dpdk.org/api/series/28695/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28695", "date": "2023-06-28T17:58:21", "name": "Logging related patches", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28695/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129080/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129080/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F7B742D82;\n\tWed, 28 Jun 2023 19:58:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7ADD342D0D;\n\tWed, 28 Jun 2023 19:58:38 +0200 (CEST)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 7D43B42B8B\n for <dev@dpdk.org>; Wed, 28 Jun 2023 19:58:34 +0200 (CEST)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1b8033987baso8744235ad.0\n for <dev@dpdk.org>; Wed, 28 Jun 2023 10:58:34 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n g11-20020a170902868b00b001b80d399730sm5047875plo.242.2023.06.28.10.58.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 28 Jun 2023 10:58:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687975113;\n x=1690567113;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=l2wLPETSatqrqW/abs51daUJaAiV13v3uq1MS6O1kj0=;\n b=i23g3MIU9GT+09ze/klAwfoeLajYVDD992iIT7hX7tvbrIKm3iyxmJQKJk3kR+mtKl\n ToEZu1mD+0RrJEJdK3u4X2yC0QV9TdNfZTW5YexvFyWaw8LrLjQ07/qZpw6yKAruRvhm\n ENvIvGoIa6yzocnShsjzmAvf0azPK7gDIUKTb/E5mOf6XBjt5NTRl93ezsvjE7xL9508\n XyEtlWZEvqSsQzdw0oPjJPm2yNr/1Fyu/vJB9Gw7uP7ScS4pVrNDd1vtSJgK9WghBmSe\n JzKCNi+ERuaQiLVEL/1CESJnsjFVntkFHtOApUIZd5cld+tgzz5uWo0OxaYBqtZG3UCA\n r4AA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687975113; x=1690567113;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=l2wLPETSatqrqW/abs51daUJaAiV13v3uq1MS6O1kj0=;\n b=ercc5cE45m7XveloYFse4z3k8x/k+yPwVoQPofoeLEAcNGywZL1rIfQi1mBzAJNUu1\n tUyg2kEOL0IJYpMzYaayHc4AW0ckghotPfITfnqi7s/F88BKqFli0KYS9NhDV5jKJKSI\n Q7gFnGYgkkmbcRRz2/J3LGVrImQ5PQvKr/kCh1W9i5GRowOpDpqJM3yWdmtGV72Lj6a+\n UU/BX5m1ki1V5lppaabt5XGlZuarkPxP1vqbwHA5boDwFPaskrcr++8gafRf7k9O2wLv\n v9z6CJo3EJgTnEFkwsITX/IO3RlrXrSMGiFIc7t6Mo0mxonsnE8pQce42MIYf4dA3tWu\n pAnQ==", "X-Gm-Message-State": "AC+VfDw5ictSMRbsg7Ve1Osf5axpDN6yCY+hhTkgQe4Jw6X3T7h0YVqX\n 2vIs32wUL69r8ALsWyAmWXqsbV/inBlP3o/rsEkgzw==", "X-Google-Smtp-Source": "\n ACHHUZ43TwWKvckvjfhAl1NsgVr0iC/BmqbE02EpLWbIQq0+oK60Yj3qASL//uuO7J/Owft7slvLRg==", "X-Received": "by 2002:a17:902:e888:b0:1b0:4c6c:716 with SMTP id\n w8-20020a170902e88800b001b04c6c0716mr2485143plg.4.1687975113479;\n Wed, 28 Jun 2023 10:58:33 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v5 3/6] eal: fix handling of syslog facility", "Date": "Wed, 28 Jun 2023 10:58:24 -0700", "Message-Id": "<20230628175827.471909-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230628175827.471909-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230628175827.471909-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The syslog facility option needs to be parsed before log_init\nis called. Also help message whas missing the required argument.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_options.c | 2 +-\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/linux/eal.c | 2 +-\n lib/eal/unix/eal_log.c | 1 +\n 4 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex 03059336987d..005da4d12001 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -2193,7 +2193,7 @@ eal_common_usage(void)\n \t \" --\"OPT_VMWARE_TSC_MAP\" Use VMware TSC map instead of native RDTSC\\n\"\n \t \" --\"OPT_PROC_TYPE\" Type of this process (primary|secondary|auto)\\n\"\n #ifndef RTE_EXEC_ENV_WINDOWS\n-\t \" --\"OPT_SYSLOG\" Set syslog facility\\n\"\n+\t \" --\"OPT_SYSLOG\"=<facility> Set syslog facility\\n\"\n #endif\n \t \" --\"OPT_LOG_LEVEL\"=<level> Set global log level\\n\"\n \t \" --\"OPT_LOG_LEVEL\"=<type-match>:<level>\\n\"\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex bb9a2b1653d9..104507b61514 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -394,7 +394,7 @@ eal_parse_args(int argc, char **argv)\n \t\t}\n \n \t\t/* eal_log_level_parse() already handled this option */\n-\t\tif (opt == OPT_LOG_LEVEL_NUM)\n+\t\tif (opt == OPT_LOG_LEVEL_NUM || opt == OPT_SYSLOG_NUM)\n \t\t\tcontinue;\n \n \t\tret = eal_parse_common_option(opt, optarg, internal_conf);\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex d7f268fc8116..e30c44380e30 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -611,7 +611,7 @@ eal_parse_args(int argc, char **argv)\n \t\t}\n \n \t\t/* eal_log_level_parse() already handled these */\n-\t\tif (opt == OPT_LOG_LEVEL_NUM)\n+\t\tif (opt == OPT_LOG_LEVEL_NUM || opt == OPT_SYSLOG_NUM)\n \t\t\tcontinue;\n \n \t\tret = eal_parse_common_option(opt, optarg, internal_conf);\ndiff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex 3f54284494d7..93cf04fae043 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -80,6 +80,7 @@ eal_log_level_parse(int argc, char *const argv[])\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\n \n \t\tswitch (opt) {\n+\t\tcase OPT_SYSLOG_NUM:\n \t\tcase OPT_LOG_LEVEL_NUM:\n \t\t\tif (eal_parse_common_option(opt, optarg, internal_conf) < 0)\n \t\t\t\treturn -1;\n", "prefixes": [ "v5", "3/6" ] }{ "id": 129080, "url": "