Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129081/?format=api
{ "id": 129081, "url": "http://patchwork.dpdk.org/api/patches/129081/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230628175827.471909-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230628175827.471909-5-stephen@networkplumber.org", "date": "2023-06-28T17:58:25", "name": "[v5,4/6] eal: skip stdio on console logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5722afb4dc2cf10d07933e7e5712ba482bc5ea4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230628175827.471909-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 28695, "url": "http://patchwork.dpdk.org/api/series/28695/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28695", "date": "2023-06-28T17:58:21", "name": "Logging related patches", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28695/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129081/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7ED6F42D82;\n\tWed, 28 Jun 2023 19:58:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A92CE42D1D;\n\tWed, 28 Jun 2023 19:58:39 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 75B9F42B8B\n for <dev@dpdk.org>; Wed, 28 Jun 2023 19:58:35 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1b852785a65so5035ad.0\n for <dev@dpdk.org>; Wed, 28 Jun 2023 10:58:35 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n g11-20020a170902868b00b001b80d399730sm5047875plo.242.2023.06.28.10.58.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 28 Jun 2023 10:58:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687975114;\n x=1690567114;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=q5LcU2GuyWyfjdj1xNxQ3NqciqeusB9CJaomlTrvuhs=;\n b=Gb42C8uMGzQJjUHkIDz2KMa4kHrZTCBZezP00DJojlwrktFB9u4/5WABxIwS44XDRV\n ac/6FvsblnfJj2+wjbKAJ12YsUtiV+jucVdiyV3WBUtavcxjpSDMARfIOtfLJokg0vOu\n YDiCrRKpJ6lIzV6HWXCh0yG2J5Per6GQGoGg4JUuBAWvdURT5kSlJtvRoQGdow500sbF\n jKteYGqjcOJbS+VuwpFOWPJ+myyJ/qR3CuicaykEK2+JQ4NtJQvA8sSNZqcwi+UL/FuL\n LE1nkI06NA+yVXAHGRkDHKe/UqSjLoAr5mH+OMARWGUyOngGCCBKkctqr6Fvw4W2tKZP\n keZg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1687975114; x=1690567114;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=q5LcU2GuyWyfjdj1xNxQ3NqciqeusB9CJaomlTrvuhs=;\n b=gY/kxCCYjovrV/DLtaN6omzM2zvDB5lAENcJQZ17gi14BlgUL8pVr5UtLOy1TYiQyw\n N+2fwn/1Uh2SeN5lX7K2BUfzL5d9+Ohfx3VjSGtq2uFcPMayqy4qxompsKeibm7ghnXY\n e9U9kHM74rxXkiNB0v1YQZEJki9kR9mXlCvMDAivxJc+j8RWYgvpE6pHmHB1fzGbP8hN\n iurUkuO2jDQziKS4GZh1HX4xrnaGL7tOlpfYBxUrdLFryYFUBittOEpaAwgekURl5FIX\n ePeagj31P+CFFQ/OIjKr1B4vCqpuabVpTZy+tBckOzoVwRFNrsbXqPlLBwVkXl+Ce882\n GAwg==", "X-Gm-Message-State": "AC+VfDzYdsC+KqwaUjc4IxYIl5HxaIzxAOBV7MaAx+CMgohdzlbpiGss\n aI9HuWr5YVjLF0InwgYyCRXOA/IjlchM5KorYpSdkQ==", "X-Google-Smtp-Source": "\n ACHHUZ7vk/YdIkDFrkzZwPeTDfy58QrGXNGQih+oIaryoXiE9IZRFY9y15NmOWVkq3X4hpmxVyUUFw==", "X-Received": "by 2002:a17:903:1cf:b0:1b6:a91d:bd1f with SMTP id\n e15-20020a17090301cf00b001b6a91dbd1fmr2412884plh.6.1687975114482;\n Wed, 28 Jun 2023 10:58:34 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v5 4/6] eal: skip stdio on console logging", "Date": "Wed, 28 Jun 2023 10:58:25 -0700", "Message-Id": "<20230628175827.471909-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230628175827.471909-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230628175827.471909-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is no need to use stdio when logging to console.\nUsing the write system call directly avoids unnecessary copy\nto stdio output buffer.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/unix/eal_log.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex 93cf04fae043..7921417b050a 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -6,6 +6,7 @@\n #include <stdio.h>\n #include <sys/types.h>\n #include <syslog.h>\n+#include <unistd.h>\n \n #include <rte_log.h>\n \n@@ -23,8 +24,7 @@ console_log_write(__rte_unused void *c, const char *buf, size_t size)\n \tssize_t ret;\n \n \t/* write on stderr */\n-\tret = fwrite(buf, 1, size, stderr);\n-\tfflush(stderr);\n+\tret = write(STDERR_FILENO, buf, size);\n \n \t/* Syslog error levels are from 0 to 7, so subtract 1 to convert */\n \tsyslog(rte_log_cur_msg_loglevel() - 1, \"%.*s\", (int)size, buf);\n", "prefixes": [ "v5", "4/6" ] }