Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129120/?format=api
http://patchwork.dpdk.org/api/patches/129120/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230629155858.75668-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230629155858.75668-3-stephen@networkplumber.org", "date": "2023-06-29T15:58:39", "name": "[v6,2/6] eal: turn off getopt_long error message during eal_log_level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c457ae653cbdcb2ecb46503dc7bd8c7be5325f96", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28717, "url": "http://patchwork.dpdk.org/api/series/28717/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28717", "date": "2023-06-29T15:58:37", "name": "Logging related patches", "version": 6, "mbox": "http://patchwork.dpdk.org/series/28717/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129120/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CAA3142D8D;\n\tThu, 29 Jun 2023 17:59:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5D8E442BAC;\n\tThu, 29 Jun 2023 17:59:21 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 64989410E4\n for <dev@dpdk.org>; Thu, 29 Jun 2023 17:59:18 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id\n d2e1a72fcca58-668704a5b5bso804188b3a.0\n for <dev@dpdk.org>; Thu, 29 Jun 2023 08:59:18 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n c6-20020a63ea06000000b0055b553157a5sm471716pgi.71.2023.06.29.08.59.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Jun 2023 08:59:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688054357;\n x=1690646357;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=y3fHgsR0tPxSTSC5fciugWqXet9+wOwAz2x0F1wMyv0=;\n b=ruGHCNgQzA0oybSV/d1jXJrAnB1VZ5G8pjouQ4xXP+eF5uTSHfOEDnLFFCmUZbhlNL\n qReS5HUy2Vdsic7HAqRZj64ZOScfr4iYOKUM8/DO1rW+pGPKZQc/kcnCaLswAtNVU9Iz\n djb2rvPGvz7ewqmdvX1UJTD20iaXx4N4sVMm4ykBDQS15I4ikb+QOBjx7Sy7kGyzizH1\n 2GsSTQFbBaQ4qezs3HhaUW4Oz7gPxa02mmVleIpVWhA1zpk5Mqz3Mn/Ki2EdFBhPQ2Dm\n Zq4kQ7U3d59tnkMEW/8Oup+FiN1MivGN1QogC3uzk+VBCqMaWICXA2DZZyONruZ4k89Z\n sa1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688054357; x=1690646357;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=y3fHgsR0tPxSTSC5fciugWqXet9+wOwAz2x0F1wMyv0=;\n b=e6x3slIiSCnTbV1Bhi+rIvTwt9S4uYD2bo098VeihREGqQuOzN0gx0RohDHGAE4XrQ\n gkpoPdnBzIr82/82XvB/q3dY9X/T75m7MpDGtiXZ6gBqMJDINe8PhevdOr+qfwGBqU5E\n JLUX+KbaLMg7/nIZDDdxwA13laceUemqlIPSVbiwW44HXggFX4tau7UvFo4E1m8Yw8yD\n Zjh1Pp35KfiBMOiRv4OaP9dCwhhGoI5HTEap3gf96mYMUbyG3IOM2J+VclCbOptV/o6o\n YBM2iNcwykiVkgYwD+2oEufKhkTNZ7Ra0j5lmDH5xja2P7rKwDJpDnm4epd04H40Lo8Z\n P8wA==", "X-Gm-Message-State": "AC+VfDy+hXkclDLtzwiHDMz8ReE3mgNEtNbutOxlLed77meBH000e37n\n MOnGkeSSouOvrhgxoakYxdWCbYY9TMTUhbjIHJ2Y8Q==", "X-Google-Smtp-Source": "\n ACHHUZ5FG4lJ/wQaSRlMU41HuW9hSIMekTbqHbAJ1Fz66Vwg2220HS1h1gWTs8qgUDkIWZ2PEJd42w==", "X-Received": "by 2002:a05:6a20:488:b0:126:3c08:77fa with SMTP id\n 8-20020a056a20048800b001263c0877famr16916pzc.48.1688054357325;\n Thu, 29 Jun 2023 08:59:17 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Keith Wiles <keith.wiles@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v6 2/6] eal: turn off getopt_long error message during\n eal_log_level", "Date": "Thu, 29 Jun 2023 08:58:39 -0700", "Message-Id": "<20230629155858.75668-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230629155858.75668-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230629155858.75668-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If DPDK application is given a bogus option, the error message\nwould get printed twice. Once during scan for log level and\nagain during parsing of arguments.\n\nExample:\n\t# ./build/app/dpdk-testpmd --bogus\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\tEAL: Detected CPU lcores: 16\n\tEAL: Detected NUMA nodes: 1\n\t./build/app/dpdk-testpmd: unrecognized option '--bogus'\n\n\tUsage: ./build/app/dpdk-testpmd [options]\n\nFix by suppressing printing error message on first pass.\n\nSigned-off-by: Keith Wiles <keith.wiles@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_log.c | 3 +++\n lib/eal/windows/eal.c | 1 +\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex 7e2f010fa371..ada3ed5ebec9 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -235,6 +235,7 @@ eal_log_level_parse(int argc, char *const argv[])\n \tint option_index, opt;\n \tconst int old_optind = optind;\n \tconst int old_optopt = optopt;\n+\tconst int old_opterr = opterr;\n \tchar * const old_optarg = optarg;\n #ifdef RTE_EXEC_ENV_FREEBSD\n \tconst int old_optreset = optreset;\n@@ -242,6 +243,7 @@ eal_log_level_parse(int argc, char *const argv[])\n #endif\n \n \toptind = 1;\n+\topterr = 0;\n \n \twhile ((opt = getopt_long(argc, argv, eal_short_options,\n \t\t\t\t eal_long_options, &option_index)) != EOF) {\n@@ -263,6 +265,7 @@ eal_log_level_parse(int argc, char *const argv[])\n \toptind = old_optind;\n \toptopt = old_optopt;\n \toptarg = old_optarg;\n+\topterr = old_opterr;\n #ifdef RTE_EXEC_ENV_FREEBSD\n \toptreset = old_optreset;\n #endif\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 240d5b8ad3e4..c6006c48ddef 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -108,6 +108,7 @@ eal_parse_args(int argc, char **argv)\n \t\teal_get_internal_configuration();\n \n \targvopt = argv;\n+\topterr = 1;\n \n \twhile ((opt = getopt_long(argc, argvopt, eal_short_options,\n \t\teal_long_options, &option_index)) != EOF) {\n", "prefixes": [ "v6", "2/6" ] }{ "id": 129120, "url": "