Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129122/?format=api
{ "id": 129122, "url": "http://patchwork.dpdk.org/api/patches/129122/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230629155858.75668-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230629155858.75668-5-stephen@networkplumber.org", "date": "2023-06-29T15:58:41", "name": "[v6,4/6] eal: skip stdio on console logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5722afb4dc2cf10d07933e7e5712ba482bc5ea4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 28717, "url": "http://patchwork.dpdk.org/api/series/28717/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28717", "date": "2023-06-29T15:58:37", "name": "Logging related patches", "version": 6, "mbox": "http://patchwork.dpdk.org/series/28717/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129122/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B176C42D8D;\n\tThu, 29 Jun 2023 17:59:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A531A42D12;\n\tThu, 29 Jun 2023 17:59:23 +0200 (CEST)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id 02BC7427EE\n for <dev@dpdk.org>; Thu, 29 Jun 2023 17:59:21 +0200 (CEST)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-66f5faba829so614346b3a.3\n for <dev@dpdk.org>; Thu, 29 Jun 2023 08:59:20 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n c6-20020a63ea06000000b0055b553157a5sm471716pgi.71.2023.06.29.08.59.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Jun 2023 08:59:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688054360;\n x=1690646360;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IPVc1lS3Y2TP5Wbd8OIZTKngZ1wvW69emU7an/lir2g=;\n b=BE1XC8u5dGo7hoOi8NQAvehf+qJ0yxTXYU8Rev+Xrc67R9rcyKFGJBz+j0YXaLqGN5\n gwo0xTwro6RytzYiv9SFIkWTiehCm9yuoL4dhtfo0QBLurtrYMya/dsspdr0d76DsJJN\n rPWmODXP473Umd45N0kpmhWAinUKJV0D/R6Qy1lAnN90uFuuv34eGmN5/Y8VB3VMUVmV\n gaaqyGciSwuFVPiQQoCT/MPps82YpJ9/Onc0ILqYFNr+ut2oCPZHHevDMekpMyPtqwlP\n aEYdSEt87SyKifspK2nvHpWe7B1zW+lFZPqAWEHd+OCYZ4IzQAjbLoz6S5p8AAlN+/Lo\n XdBg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688054360; x=1690646360;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IPVc1lS3Y2TP5Wbd8OIZTKngZ1wvW69emU7an/lir2g=;\n b=l6/pWbi7kG/WngV1mwjKW7ckq1ieNnhzAgIYVlAfvVxIoKgMIxosdw82grWavKRYFM\n /0ZomAcjsZ9Ge1FR+ufQmb1FaclMkvsFRMCncbjK4zmtB7karloNxJaTTTUxEqDMJt+O\n 0BWqP68ltKIoJna2omjI+kMJJLwbEAsWYyLTG8tubqtBimysgZOkABpPfPASU4G/WwH1\n cBtFQYmLD8TAxFiHnqQq3ulJU2kxIAIOo8nODfZShIxSJRDLy8wPuhZIpBbKAFY6yV7n\n UJYFZ/FOqwYJeHfMRIEkw4gBIxMrbf4S3YZuCKI5DAIZt/8M1H2rB2aqHIMqQmuibigj\n LMow==", "X-Gm-Message-State": "AC+VfDwyawxxAbZEuEK5jsH7D120fgTGhFjcOj8SQLBRx8EFTGRp7LPt\n f/6HeJjwGBYgp+lhWom3XXNKYU2FsFWWGvaYN8kNmA==", "X-Google-Smtp-Source": "\n ACHHUZ56P8fO57ptaxZ7uG50PvOQa6Y4hRg9ybYTTTgt4jnD+D98mLQuLS/ztc8hzSJwodp3DGviOA==", "X-Received": "by 2002:a05:6a20:8f0b:b0:123:21f9:625e with SMTP id\n b11-20020a056a208f0b00b0012321f9625emr276256pzk.0.1688054359846;\n Thu, 29 Jun 2023 08:59:19 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v6 4/6] eal: skip stdio on console logging", "Date": "Thu, 29 Jun 2023 08:58:41 -0700", "Message-Id": "<20230629155858.75668-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230629155858.75668-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230629155858.75668-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is no need to use stdio when logging to console.\nUsing the write system call directly avoids unnecessary copy\nto stdio output buffer.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/unix/eal_log.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex 85d817c2d31e..151f30eb6071 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -5,6 +5,7 @@\n #include <stdio.h>\n #include <sys/types.h>\n #include <syslog.h>\n+#include <unistd.h>\n \n #include <rte_log.h>\n \n@@ -21,8 +22,7 @@ console_log_write(__rte_unused void *c, const char *buf, size_t size)\n \tssize_t ret;\n \n \t/* write on stderr */\n-\tret = fwrite(buf, 1, size, stderr);\n-\tfflush(stderr);\n+\tret = write(STDERR_FILENO, buf, size);\n \n \t/* Syslog error levels are from 0 to 7, so subtract 1 to convert */\n \tsyslog(rte_log_cur_msg_loglevel() - 1, \"%.*s\", (int)size, buf);\n", "prefixes": [ "v6", "4/6" ] }