Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129123/?format=api
{ "id": 129123, "url": "http://patchwork.dpdk.org/api/patches/129123/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230629155858.75668-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230629155858.75668-6-stephen@networkplumber.org", "date": "2023-06-29T15:58:42", "name": "[v6,5/6] eal: allow user to set default log stream before init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "042a3c78b665c03ff2711749db00e361518bbe05", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230629155858.75668-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 28717, "url": "http://patchwork.dpdk.org/api/series/28717/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28717", "date": "2023-06-29T15:58:37", "name": "Logging related patches", "version": 6, "mbox": "http://patchwork.dpdk.org/series/28717/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129123/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129123/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DBA7142D8D;\n\tThu, 29 Jun 2023 17:59:48 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 32F9B42D3B;\n\tThu, 29 Jun 2023 17:59:26 +0200 (CEST)", "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n by mails.dpdk.org (Postfix) with ESMTP id 2EEE142BFE\n for <dev@dpdk.org>; Thu, 29 Jun 2023 17:59:22 +0200 (CEST)", "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-66869feb7d1so551538b3a.3\n for <dev@dpdk.org>; Thu, 29 Jun 2023 08:59:22 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n c6-20020a63ea06000000b0055b553157a5sm471716pgi.71.2023.06.29.08.59.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Jun 2023 08:59:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688054361;\n x=1690646361;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2REMwfqBNFQRsvdAmxlcKkjoRSmPem4p2WHk4M7Y314=;\n b=fGmeOgAVCRnP/iMTJALcntq50GwM2USRxQUJ7yRH3DdwJeJliD6m1sYRtl/BnC/fdR\n Ws/aKeXsmqiF+dj2Xrfqm3GuqVJUT94GkDZ5tElicCMTdcqrLzgmB/v85967saq297+a\n 0Z3dE9v+nWR5DqNoc/UcDsrqCIjRVFDpcj7h1VajiJ5eEBxQRQHMilRhEuU3sbR1ySWg\n PIrM2BAK4wXWEGDJQLa7Znv+UKRk3+TdQTjOmbjelYRia/m+9gEtaLHciYNRcUiTrFE/\n GeBgOXodukDLaf5riffXCWBA7TI9i4fsclF8+0hmLqMgBjHiaknE4eA4uvbLELXOE1SM\n hj2A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688054361; x=1690646361;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2REMwfqBNFQRsvdAmxlcKkjoRSmPem4p2WHk4M7Y314=;\n b=TzGPGHidsH57maUSyIfxqVa96MWDpXjbf98VWEppRhmxlhwui9TGPrRlcqqGuZgsLV\n twpYU9Pg6UDmSl5UM7NWrea/8j4kwvNMEsBbqQgvtbwiew8GKMYCNs6bAR4vEyYTFsOO\n s8LDo3kKE6waW+MBg3XdNCFL3Xviccxx4pGN7KHLWMZwSmH69yK/bvOHqDJ4aaeoydSo\n FU4MpHAdynjPTWV49ijy8eAo2woaAu44iRy+C2aEjSOyA1oAWChjMUiOjq45rNC3krZE\n V27p3thIrup5op6Jg8EEJt3m6il/uTan4ktNklEwYKjcJ6fIauYGBpiS0U8tDr5S6WlZ\n 1A0A==", "X-Gm-Message-State": "ABy/qLa7p+kucvMvoJLs0yHeaTf3lfzvv/mvkvv7lS4LarjMDFYZbC12\n w0kWR6NLnJph+2A6LikipZqcV34Cl7IUbpn2vi+q9A==", "X-Google-Smtp-Source": "\n APBJJlGHCVtUiA+/l5GLa4Xpo/5PynBq/owmG/M+XxW5G9hNtHycEOrR/c6gd6g7158+vYiAFrk/zQ==", "X-Received": "by 2002:a62:1850:0:b0:67a:31b7:456c with SMTP id\n 77-20020a621850000000b0067a31b7456cmr363553pfy.9.1688054361144;\n Thu, 29 Jun 2023 08:59:21 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Maryam Tahhan <maryam.tahhan@intel.com>", "Subject": "[PATCH v6 5/6] eal: allow user to set default log stream before init", "Date": "Thu, 29 Jun 2023 08:58:42 -0700", "Message-Id": "<20230629155858.75668-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230629155858.75668-1-stephen@networkplumber.org>", "References": "<20200814173441.23086-1-stephen@networkplumber.org>\n <20230629155858.75668-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "It is useful for application to be able to set the default log\nstream before call rte_eal_init(). This makes all messages go\nto the new default.\n\nFor example, to skip using syslog; just doing\n\trte_openlog_stream(stderr);\n\nThere is no reason for helper command line applications to clutter\nsyslog with messages.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 3 +++\n app/pdump/main.c | 3 +++\n app/proc-info/main.c | 3 +++\n lib/eal/common/eal_common_log.c | 6 ++++++\n lib/eal/common/eal_log.h | 1 +\n lib/eal/unix/eal_log.c | 4 ++++\n 6 files changed, 20 insertions(+)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex 64294bbfb3e6..bf31eef13cf4 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -639,6 +639,9 @@ static void dpdk_init(void)\n \t\teal_argv[i++] = strdup(file_prefix);\n \t}\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tif (rte_eal_init(eal_argc, eal_argv) < 0)\n \t\trte_exit(EXIT_FAILURE, \"EAL init failed: is primary process running?\\n\");\n }\ndiff --git a/app/pdump/main.c b/app/pdump/main.c\nindex c94606275b28..82c67350e4ab 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -989,6 +989,9 @@ main(int argc, char **argv)\n \n \targc += 2;\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tdiag = rte_eal_init(argc, argp);\n \tif (diag < 0)\n \t\trte_panic(\"Cannot init EAL\\n\");\ndiff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex 53e852a07c14..371b1f382d66 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -1774,6 +1774,9 @@ main(int argc, char **argv)\n \n \targc += 4;\n \n+\t/* keep any logging away from syslog. */\n+\trte_openlog_stream(stderr);\n+\n \tret = rte_eal_init(argc, argp);\n \tif (ret < 0)\n \t\trte_panic(\"Cannot init EAL\\n\");\ndiff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex ada3ed5ebec9..827830916eb7 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -584,6 +584,12 @@ eal_log_set_default(FILE *default_log)\n #endif\n }\n \n+FILE *\n+eal_log_get_default(void)\n+{\n+\treturn default_log_stream;\n+}\n+\n /*\n * Called by eal_cleanup\n */\ndiff --git a/lib/eal/common/eal_log.h b/lib/eal/common/eal_log.h\nindex 31dc489350f6..268c2a264382 100644\n--- a/lib/eal/common/eal_log.h\n+++ b/lib/eal/common/eal_log.h\n@@ -22,6 +22,7 @@ int eal_log_level_parse(int argc, char * const argv[]);\n * Determine where log data is written when no call to rte_openlog_stream.\n */\n void eal_log_set_default(FILE *default_log);\n+FILE *eal_log_get_default(void);\n \n /*\n * Save a log option for later.\ndiff --git a/lib/eal/unix/eal_log.c b/lib/eal/unix/eal_log.c\nindex 151f30eb6071..98753cb52e09 100644\n--- a/lib/eal/unix/eal_log.c\n+++ b/lib/eal/unix/eal_log.c\n@@ -60,6 +60,10 @@ eal_log_init(const char *id, int facility)\n {\n \tFILE *log_stream;\n \n+\t/* has user has already setup a log stream */\n+\tif (eal_log_get_default())\n+\t\treturn 0;\n+\n \tlog_stream = fopencookie(NULL, \"w+\", console_log_func);\n \tif (log_stream == NULL)\n \t\treturn -1;\n", "prefixes": [ "v6", "5/6" ] }