Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129277/?format=api
{ "id": 129277, "url": "http://patchwork.dpdk.org/api/patches/129277/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230705092511.362484-2-wenjun1.wu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230705092511.362484-2-wenjun1.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230705092511.362484-2-wenjun1.wu@intel.com", "date": "2023-07-05T09:25:10", "name": "[v1,1/2] bus/vdev: fix memory leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a9a96b6d4c005020cfcc337d6ece731b3929c21", "submitter": { "id": 2083, "url": "http://patchwork.dpdk.org/api/people/2083/?format=api", "name": "Wenjun Wu", "email": "wenjun1.wu@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230705092511.362484-2-wenjun1.wu@intel.com/mbox/", "series": [ { "id": 28823, "url": "http://patchwork.dpdk.org/api/series/28823/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28823", "date": "2023-07-05T09:25:09", "name": "fix memory leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28823/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129277/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129277/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EFDB542DCC;\n\tWed, 5 Jul 2023 11:23:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EEF2340FAE;\n\tWed, 5 Jul 2023 11:22:59 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id A274B40FAE;\n Wed, 5 Jul 2023 11:22:57 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Jul 2023 02:22:57 -0700", "from dpdk-wuwenjun-icelake-ii.sh.intel.com ([10.67.110.188])\n by orsmga003.jf.intel.com with ESMTP; 05 Jul 2023 02:22:55 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688548978; x=1720084978;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=5oufmE4eyZnV6LisqjY+exu9skdq/K5qpe3iT7gArus=;\n b=PJl/XvN58X9rOcc3NWFjuUiN9vvfhY5UlJN1+hMSbeBwYPsexTSTPYB7\n AIP8WE5XbDT9utW/AQAS8ewNY8UCYVEIJgvOO4DHtAhZlvOjl4isKPQHp\n PSnU/Ylwq8y+p3cayv1J4UoyeVQLIQVLxl4buie3EDcLCm6z8IuInwuL2\n OxTw2rFx/Np38gZh2moKcVcMGYqvUY22gGencAFOBRk7ibJsBX1oFM8KV\n 5kvSSTXyzXHN+dZMl2j7sMVjONRHhNA0N26HU5TbkPYi5URO+62bnukWB\n 9Ox5beP4tFTQypYEhPTZWZztlsipg/v+pV63rQvtDex6vAR6IAFTBoU6z Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10761\"; a=\"353122495\"", "E=Sophos;i=\"6.01,182,1684825200\"; d=\"scan'208\";a=\"353122495\"", "E=McAfee;i=\"6600,9927,10761\"; a=\"669340944\"", "E=Sophos;i=\"6.01,182,1684825200\"; d=\"scan'208\";a=\"669340944\"" ], "X-ExtLoop1": "1", "From": "Wenjun Wu <wenjun1.wu@intel.com>", "To": "dev@dpdk.org,\n\tanatoly.burakov@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "simei.su@intel.com,\n\tWenjun Wu <wenjun1.wu@intel.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v1 1/2] bus/vdev: fix memory leak", "Date": "Wed, 5 Jul 2023 17:25:10 +0800", "Message-Id": "<20230705092511.362484-2-wenjun1.wu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230705092511.362484-1-wenjun1.wu@intel.com>", "References": "<20230705092511.362484-1-wenjun1.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In hotplug usecase, devargs will be allocated in secondary process\nin the function alloc_devargs. Since it will not be insert into the\ndevarg_list, it will have no chance to be freed.\n\nThis patch adds additional memory free for device structure member devargs\nin the secondary process in rte_vdev_uninit.\n\nFixes: f5b2eff0847d (\"bus/vdev: fix devargs after multi-process bus scan\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenjun Wu <wenjun1.wu@intel.com>\n---\n drivers/bus/vdev/vdev.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 7974b27295..3f4e6a1b55 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -373,6 +373,11 @@ rte_vdev_uninit(const char *name)\n \n \tTAILQ_REMOVE(&vdev_device_list, dev, next);\n \trte_devargs_remove(dev->device.devargs);\n+\tif (rte_eal_process_type() == RTE_PROC_SECONDARY &&\n+\t dev->device.devargs != NULL) {\n+\t\trte_devargs_reset(dev->device.devargs);\n+\t\tfree(dev->device.devargs);\n+\t}\n \tfree(dev);\n \n unlock:\n", "prefixes": [ "v1", "1/2" ] }