Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129278/?format=api
{ "id": 129278, "url": "http://patchwork.dpdk.org/api/patches/129278/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230705092511.362484-3-wenjun1.wu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230705092511.362484-3-wenjun1.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230705092511.362484-3-wenjun1.wu@intel.com", "date": "2023-07-05T09:25:11", "name": "[v1,2/2] examples/multi_process: fix memory leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "583c7c90629f4be5f4adafe6d0ebc0992a332c20", "submitter": { "id": 2083, "url": "http://patchwork.dpdk.org/api/people/2083/?format=api", "name": "Wenjun Wu", "email": "wenjun1.wu@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230705092511.362484-3-wenjun1.wu@intel.com/mbox/", "series": [ { "id": 28823, "url": "http://patchwork.dpdk.org/api/series/28823/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28823", "date": "2023-07-05T09:25:09", "name": "fix memory leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28823/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129278/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129278/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8415942DCC;\n\tWed, 5 Jul 2023 11:23:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 70C9B42BDA;\n\tWed, 5 Jul 2023 11:23:16 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id EEF4540150;\n Wed, 5 Jul 2023 11:23:13 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Jul 2023 02:23:13 -0700", "from dpdk-wuwenjun-icelake-ii.sh.intel.com ([10.67.110.188])\n by orsmga003.jf.intel.com with ESMTP; 05 Jul 2023 02:23:11 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688548994; x=1720084994;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=LWYgXAhOYkNIE4qVqoANJjnrb9EGKnOvrRfe+x8qssA=;\n b=QSkL2dn8965lTATNetmf3SMLibNbnnVe3CwEhofkEmmCFaEvqba2KvwU\n UvdWNNmEvNL6VMTcovB+pFtycrhd22K9onFNctn+beQVr7watVHjNHiOA\n l+ozu5Delwx8/yeGnAUDyXhWqaoopIhRp5XlytIqifNxe5cZHCZ7RNim5\n /K4uF97JgcPjDOMbV3j/aDAkp5+y9k4ZuqznRdqXNIw2eQNq3klTKq5qj\n Y6/bQ2BkIdrCBtOKjpYWA0JLYxkeqwWWdTGIAkdrPmk1L3IgcTEIfjuLo\n YpAgEBRGZZzo1cKjBP84tJJ6L2Vx0fKQuy0Sr16cw4zOzkTdXWTvoL5zn w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10761\"; a=\"353122550\"", "E=Sophos;i=\"6.01,182,1684825200\"; d=\"scan'208\";a=\"353122550\"", "E=McAfee;i=\"6600,9927,10761\"; a=\"669341067\"", "E=Sophos;i=\"6.01,182,1684825200\"; d=\"scan'208\";a=\"669341067\"" ], "X-ExtLoop1": "1", "From": "Wenjun Wu <wenjun1.wu@intel.com>", "To": "dev@dpdk.org,\n\tanatoly.burakov@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "simei.su@intel.com,\n\tWenjun Wu <wenjun1.wu@intel.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v1 2/2] examples/multi_process: fix memory leak", "Date": "Wed, 5 Jul 2023 17:25:11 +0800", "Message-Id": "<20230705092511.362484-3-wenjun1.wu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230705092511.362484-1-wenjun1.wu@intel.com>", "References": "<20230705092511.362484-1-wenjun1.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The device should be detached before quit, otherwise it will\ncause memory leak.\n\nFixes: 05f1d6842fc3 (\"examples/multi_process: add hotplug sample\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenjun Wu <wenjun1.wu@intel.com>\n---\n examples/multi_process/hotplug_mp/commands.c | 22 ++++++++++++++++++++\n 1 file changed, 22 insertions(+)", "diff": "diff --git a/examples/multi_process/hotplug_mp/commands.c b/examples/multi_process/hotplug_mp/commands.c\nindex 88f44e00a0..143d57eeb6 100644\n--- a/examples/multi_process/hotplug_mp/commands.c\n+++ b/examples/multi_process/hotplug_mp/commands.c\n@@ -52,6 +52,28 @@ static void cmd_quit_parsed(__rte_unused void *parsed_result,\n \t\t\t struct cmdline *cl,\n \t\t\t __rte_unused void *data)\n {\n+\tuint16_t port_id;\n+\tchar dev_name[RTE_DEV_NAME_MAX_LEN];\n+\tstruct rte_devargs da;\n+\n+\tRTE_ETH_FOREACH_DEV(port_id) {\n+\t\trte_eth_dev_get_name_by_port(port_id, dev_name);\n+\t\tmemset(&da, 0, sizeof(da));\n+\n+\t\tif (rte_devargs_parsef(&da, \"%s\", dev_name)) {\n+\t\t\tcmdline_printf(cl,\n+\t\t\t\t \"cannot parse devargs for device %s\\n\",\n+\t\t\t\t dev_name);\n+\t\t}\n+\t\tprintf(\"detaching before quit...\\n\");\n+\t\tif (!rte_eal_hotplug_remove(rte_bus_name(da.bus), da.name))\n+\t\t\tcmdline_printf(cl, \"detached device %s\\n\",\n+\t\t\t\tda.name);\n+\t\telse\n+\t\t\tcmdline_printf(cl, \"failed to detach device %s\\n\",\n+\t\t\t\tda.name);\n+\n+\t}\n \tcmdline_quit(cl);\n }\n \n", "prefixes": [ "v1", "2/2" ] }