Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129348/?format=api
{ "id": 129348, "url": "http://patchwork.dpdk.org/api/patches/129348/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230706162117.481960-2-brian.dooley@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230706162117.481960-2-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230706162117.481960-2-brian.dooley@intel.com", "date": "2023-07-06T16:21:16", "name": "[v3,1/2] crypto/ipsec_mb: remove unused defines", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2304de9e93e26b320cefa74f4618bd886f79b88f", "submitter": { "id": 2520, "url": "http://patchwork.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230706162117.481960-2-brian.dooley@intel.com/mbox/", "series": [ { "id": 28866, "url": "http://patchwork.dpdk.org/api/series/28866/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28866", "date": "2023-07-06T16:21:15", "name": "remove unused defines", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28866/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129348/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4BAA642DEA;\n\tThu, 6 Jul 2023 18:21:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A35EC42FDA;\n\tThu, 6 Jul 2023 18:21:28 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 213A6410FA\n for <dev@dpdk.org>; Thu, 6 Jul 2023 18:21:25 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2023 09:21:25 -0700", "from unknown (HELO silpixa00400883.ir.intel.com) ([10.243.22.155])\n by orsmga003.jf.intel.com with ESMTP; 06 Jul 2023 09:21:23 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688660486; x=1720196486;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=9z0+SbXl1fPRqgTUHxcDG3TEuJgDBi7trhoHiVEhik0=;\n b=Dor4OctLmg9LSsrjCoA55SVu/Ic8CRzAuHsFo4OpMYSTNDSPt3InCZ+A\n 6WLnYXUegmiWfgbBA9Mbn6n8mvLKYUPJTfeliDCQ6V1ctpoK4lfaxiJBD\n 5AEJ9lTiKKRku7j44I5yT50lzo6BUjXL4+Y1r6WuPS+RxIONN+18+y8Rg\n oneE73w76ZvEW7ov4ak0XSaCA23BiBK1GvsuFdM8KqisvW7uXhq2S7lrX\n P56omr26h5nkr5kN0z4088JSDga6Cmo4ZE9HH8wY9J5b0FCsbv5eooWa0\n FN/cWzvMfKOsiz1OQxjUu3/EQJcGXPocrhWRyt+Czkqx9QseQJd/5Hqje w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10763\"; a=\"394409432\"", "E=Sophos;i=\"6.01,185,1684825200\"; d=\"scan'208\";a=\"394409432\"", "E=McAfee;i=\"6600,9927,10763\"; a=\"669789886\"", "E=Sophos;i=\"6.01,185,1684825200\"; d=\"scan'208\";a=\"669789886\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "dev@dpdk.org, gakhil@marvell.com, Brian Dooley <brian.dooley@intel.com>,\n maxime.coquelin@redhat.com", "Subject": "[PATCH v3 1/2] crypto/ipsec_mb: remove unused defines", "Date": "Thu, 6 Jul 2023 16:21:16 +0000", "Message-Id": "<20230706162117.481960-2-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230706162117.481960-1-brian.dooley@intel.com>", "References": "<20230706160454.479229-1-brian.dooley@intel.com>\n <20230706162117.481960-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "removed AESNI_MB_DOCSIS_SEC_ENABLED defines as they are no longer used.\n\nFixes: 798f9d134519 (\"crypto/ipsec_mb: remove security lib presence checks\")\nCc: maxime.coquelin@redhat.com\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\n drivers/crypto/ipsec_mb/ipsec_mb_private.c | 4 ----\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 22 ++-------------------\n drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 1 -\n 3 files changed, 2 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c b/drivers/crypto/ipsec_mb/ipsec_mb_private.c\nindex 64f2b4b604..f485d130b6 100644\n--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c\n+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c\n@@ -205,10 +205,6 @@ ipsec_mb_remove(struct rte_vdev_device *vdev)\n \t\trte_free(cryptodev->security_ctx);\n \t\tcryptodev->security_ctx = NULL;\n \t}\n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n-\trte_free(cryptodev->security_ctx);\n-\tcryptodev->security_ctx = NULL;\n-#endif\n \n \tfor (qp_id = 0; qp_id < cryptodev->data->nb_queue_pairs; qp_id++)\n \t\tipsec_mb_qp_release(cryptodev, qp_id);\ndiff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 7fcb8f99e0..9e298023d7 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -851,7 +851,6 @@ aesni_mb_session_configure(IMB_MGR *mb_mgr,\n \treturn 0;\n }\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n /** Check DOCSIS security session configuration is valid */\n static int\n check_docsis_sec_session(struct rte_security_session_conf *conf)\n@@ -988,7 +987,6 @@ aesni_mb_set_docsis_sec_session_parameters(\n \tfree_mb_mgr(mb_mgr);\n \treturn ret;\n }\n-#endif\n \n static inline uint64_t\n auth_start_offset(struct rte_crypto_op *op, struct aesni_mb_session *session,\n@@ -1762,7 +1760,6 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *qp,\n \treturn 0;\n }\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n /**\n * Process a crypto operation containing a security op and complete a\n * IMB_JOB job structure for submission to the multi buffer library for\n@@ -1853,7 +1850,6 @@ verify_docsis_sec_crc(IMB_JOB *job, uint8_t *status)\n \tif (memcmp(job->auth_tag_output, crc, RTE_ETHER_CRC_LEN) != 0)\n \t\t*status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;\n }\n-#endif\n \n static inline void\n verify_digest(IMB_JOB *job, void *digest, uint16_t len, uint8_t *status)\n@@ -1921,8 +1917,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job)\n \tstruct aesni_mb_session *sess = NULL;\n \tuint8_t *linear_buf = NULL;\n \tint sgl = 0;\n-\n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n \tuint8_t is_docsis_sec = 0;\n \n \tif (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {\n@@ -1933,7 +1927,6 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job)\n \t\tis_docsis_sec = 1;\n \t\tsess = SECURITY_GET_SESS_PRIV(op->sym->session);\n \t} else\n-#endif\n \t\tsess = CRYPTODEV_GET_SYM_SESS_PRIV(op->sym->session);\n \n \tif (likely(op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)) {\n@@ -1961,11 +1954,9 @@ post_process_mb_job(struct ipsec_mb_qp *qp, IMB_JOB *job)\n \t\t\t\t\t\top->sym->aead.digest.data,\n \t\t\t\t\t\tsess->auth.req_digest_len,\n \t\t\t\t\t\t&op->status);\n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n \t\t\t\telse if (is_docsis_sec)\n \t\t\t\t\tverify_docsis_sec_crc(job,\n \t\t\t\t\t\t&op->status);\n-#endif\n \t\t\t\telse\n \t\t\t\t\tverify_digest(job,\n \t\t\t\t\t\top->sym->auth.digest.data,\n@@ -2098,12 +2089,10 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t\tjob = jobs[i];\n \t\t\top = deqd_ops[i];\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n \t\t\tif (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION)\n \t\t\t\tretval = set_sec_mb_job_params(job, qp, op,\n \t\t\t\t\t\t\t &digest_idx);\n \t\t\telse\n-#endif\n \t\t\t\tretval = set_mb_job_params(job, qp, op,\n \t\t\t\t\t\t\t &digest_idx, mb_mgr);\n \n@@ -2259,12 +2248,10 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\tif (retval < 0)\n \t\t\tbreak;\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n \t\tif (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION)\n \t\t\tretval = set_sec_mb_job_params(job, qp, op,\n \t\t\t\t\t\t&digest_idx);\n \t\telse\n-#endif\n \t\t\tretval = set_mb_job_params(job, qp, op,\n \t\t\t\t&digest_idx, mb_mgr);\n \n@@ -2440,7 +2427,6 @@ struct rte_cryptodev_ops aesni_mb_pmd_ops = {\n \t.sym_session_clear = ipsec_mb_sym_session_clear\n };\n \n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n /**\n * Configure a aesni multi-buffer session from a security session\n * configuration\n@@ -2528,8 +2514,6 @@ aesni_mb_configure_dev(struct rte_cryptodev *dev)\n \treturn -ENOMEM;\n }\n \n-#endif\n-\n static int\n aesni_mb_probe(struct rte_vdev_device *vdev)\n {\n@@ -2570,17 +2554,15 @@ RTE_INIT(ipsec_mb_register_aesni_mb)\n \t\t\tRTE_CRYPTODEV_FF_IN_PLACE_SGL |\n \t\t\tRTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |\n-\t\t\tRTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT;\n+\t\t\tRTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |\n+\t\t\tRTE_CRYPTODEV_FF_SECURITY;\n \n \taesni_mb_data->internals_priv_size = 0;\n \taesni_mb_data->ops = &aesni_mb_pmd_ops;\n \taesni_mb_data->qp_priv_size = sizeof(struct aesni_mb_qp_data);\n \taesni_mb_data->queue_pair_configure = NULL;\n-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED\n \taesni_mb_data->security_ops = &aesni_mb_pmd_sec_ops;\n \taesni_mb_data->dev_config = aesni_mb_configure_dev;\n-\taesni_mb_data->feature_flags |= RTE_CRYPTODEV_FF_SECURITY;\n-#endif\n \taesni_mb_data->session_configure = aesni_mb_session_configure;\n \taesni_mb_data->session_priv_size = sizeof(struct aesni_mb_session);\n }\ndiff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\nindex 3f6cf30c39..85994fe5a1 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h\n@@ -5,7 +5,6 @@\n #ifndef _PMD_AESNI_MB_PRIV_H_\n #define _PMD_AESNI_MB_PRIV_H_\n \n-#define AESNI_MB_DOCSIS_SEC_ENABLED 1\n #include <rte_security.h>\n #include <rte_security_driver.h>\n #include <rte_ether.h>\n", "prefixes": [ "v3", "1/2" ] }