Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 129351,
    "url": "http://patchwork.dpdk.org/api/patches/129351/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230706175938.62721-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230706175938.62721-2-stephen@networkplumber.org",
    "date": "2023-07-06T17:59:25",
    "name": "[v3,01/14] gro: use rte_pktmbuf_mtod_offset",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "af8ce6ceb83fa4f9b7904e710edb1a08aceba817",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 28867,
            "url": "http://patchwork.dpdk.org/api/series/28867/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28867",
            "date": "2023-07-06T17:59:24",
            "name": "Use rte_pktmbuf_mtod_offset() where possible",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/28867/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/129351/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/129351/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 785EB42DEC;\n\tThu,  6 Jul 2023 19:59:51 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B46A642FF4;\n\tThu,  6 Jul 2023 19:59:44 +0200 (CEST)",
            "from mail-pj1-f54.google.com (mail-pj1-f54.google.com\n [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 0B1BA40A79\n for <dev@dpdk.org>; Thu,  6 Jul 2023 19:59:42 +0200 (CEST)",
            "by mail-pj1-f54.google.com with SMTP id\n 98e67ed59e1d1-262d33fa37cso605958a91.3\n for <dev@dpdk.org>; Thu, 06 Jul 2023 10:59:42 -0700 (PDT)",
            "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n nh8-20020a17090b364800b00256bbfbabcfsm76464pjb.48.2023.07.06.10.59.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 Jul 2023 10:59:41 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688666382;\n x=1691258382;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uKIPVSHQOjG/aLU05G8kD/J+dkw9l+RFxXIKhjNDK+w=;\n b=SIV2QO3Hnp6uE7wEEXqBMzoN3TKVocVggJthHpNK+AdJsPAFs1w+cWYOjDh1vxbko6\n T+4DmITnZ1NixppPXG43emXVNwvDHLRtJ7kdVpHxf1JWRtvkiIPQS4c06r1kA8dpxRDR\n h7bO4kApv94OuiC01Gv8/GE6rMFuDcH65tuj9cZrhcx2Y4nDrckML8bYUP90nrFtHNq8\n dkuCaHYNr0X7qT1KIfVfUTSJ+KTEHDPz/XVKOtvMCza9QLuhgWE8DS37eTuD4ZHgEcGt\n W5mV1ss3sOI3nzOgpcsygVw5lexx8gvm2m5eFKDMMYGOEfcidDw426RcIOqzYLJMtPVY\n Eo6Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688666382; x=1691258382;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uKIPVSHQOjG/aLU05G8kD/J+dkw9l+RFxXIKhjNDK+w=;\n b=GR4jMQvAQ4tZb8REcn5+CbwKzhHX2PABhkv5OQr9dKfADgQFV3TDTjGhzu4E9W1FXi\n uw4nZMMdHoGutaLrG+lbu67Jq3krMsuouV8I38Q7oIVxxLpZ2VxMpoNB0OqxYu+fYwf+\n bD4rjRiiSAzR4O9vJBAtIy6qjSj3XzuHS6TrsS+rT5AJtkWt7RdmnmoLNl5zlod8WwRq\n 5KDpZKMQ5+Z7SzFBgZrdoQ7eJBlsWggZvfLtu35pqyfB+9YydE8TUeCOzEBpeka6Aa47\n j7FuOBcoNmS3w0LGTV8CC4bGM7jNru4a55piC/bBbRdhxVZEx9POzia/JjUt3rp3CZFf\n cmsA==",
        "X-Gm-Message-State": "ABy/qLZYi+EX9Hr4uS9sZS7Tpv0zcLCjNnzCm0DiHyaxoDarRjruJ9+O\n bprbO5SxcOQJmRYT7xrNgJasE7fMxUMG2Grz6zY=",
        "X-Google-Smtp-Source": "\n APBJJlGxzB8EBoc/yV8aQShCSDYZFeYJnm4hzkXktRw/mGobv23HpkCDFS2omAUNRpbO0Rkmy7a8Vw==",
        "X-Received": "by 2002:a17:90b:1110:b0:263:72c5:9ac6 with SMTP id\n gi16-20020a17090b111000b0026372c59ac6mr1988145pjb.11.1688666381664;\n Thu, 06 Jul 2023 10:59:41 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>",
        "Subject": "[PATCH v3 01/14] gro: use rte_pktmbuf_mtod_offset",
        "Date": "Thu,  6 Jul 2023 10:59:25 -0700",
        "Message-Id": "<20230706175938.62721-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20230706175938.62721-1-stephen@networkplumber.org>",
        "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230706175938.62721-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Use rte_pktmbuf_mtod_offset. Change was automatically generated\nby cocci/mtod-offset.cocci.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gro/gro_tcp.h        | 2 +-\n lib/gro/gro_tcp4.c       | 2 +-\n lib/gro/gro_udp4.c       | 4 ++--\n lib/gro/gro_vxlan_tcp4.c | 4 ++--\n lib/gro/gro_vxlan_udp4.c | 4 ++--\n 5 files changed, 8 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/lib/gro/gro_tcp.h b/lib/gro/gro_tcp.h\nindex d926c4b8cc71..2c825413c261 100644\n--- a/lib/gro/gro_tcp.h\n+++ b/lib/gro/gro_tcp.h\n@@ -150,7 +150,7 @@ check_seq_option(struct gro_tcp_item *item,\n \tstruct rte_tcp_hdr *tcph_orig;\n \tuint16_t len, tcp_hl_orig;\n \n-\tiph_orig = (char *)(rte_pktmbuf_mtod(pkt_orig, char *) +\n+\tiph_orig = rte_pktmbuf_mtod_offset(pkt_orig, char *,\n \t\t\tl2_offset + pkt_orig->l2_len);\n \ttcph_orig = (struct rte_tcp_hdr *)(iph_orig + pkt_orig->l3_len);\n \ttcp_hl_orig = pkt_orig->l4_len;\ndiff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c\nindex 6645de592b63..f8cd92950c63 100644\n--- a/lib/gro/gro_tcp4.c\n+++ b/lib/gro/gro_tcp4.c\n@@ -223,7 +223,7 @@ update_header(struct gro_tcp_item *item)\n \tstruct rte_ipv4_hdr *ipv4_hdr;\n \tstruct rte_mbuf *pkt = item->firstseg;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n \t\t\tpkt->l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -\n \t\t\tpkt->l2_len);\ndiff --git a/lib/gro/gro_udp4.c b/lib/gro/gro_udp4.c\nindex 42596d33b6dc..019e05bcdea5 100644\n--- a/lib/gro/gro_udp4.c\n+++ b/lib/gro/gro_udp4.c\n@@ -179,8 +179,8 @@ update_header(struct gro_udp4_item *item)\n \tstruct rte_mbuf *pkt = item->firstseg;\n \tuint16_t frag_offset;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t   pkt->l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -\n \t\t\tpkt->l2_len);\n \ndiff --git a/lib/gro/gro_vxlan_tcp4.c b/lib/gro/gro_vxlan_tcp4.c\nindex 6ab700192261..2752650389a4 100644\n--- a/lib/gro/gro_vxlan_tcp4.c\n+++ b/lib/gro/gro_vxlan_tcp4.c\n@@ -263,8 +263,8 @@ update_vxlan_header(struct gro_vxlan_tcp4_item *item)\n \n \t/* Update the outer IPv4 header. */\n \tlen = pkt->pkt_len - pkt->outer_l2_len;\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->outer_l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t   pkt->outer_l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(len);\n \n \t/* Update the outer UDP header. */\ndiff --git a/lib/gro/gro_vxlan_udp4.c b/lib/gro/gro_vxlan_udp4.c\nindex b78a7ae89eef..ca8cee270d3d 100644\n--- a/lib/gro/gro_vxlan_udp4.c\n+++ b/lib/gro/gro_vxlan_udp4.c\n@@ -259,8 +259,8 @@ update_vxlan_header(struct gro_vxlan_udp4_item *item)\n \n \t/* Update the outer IPv4 header. */\n \tlen = pkt->pkt_len - pkt->outer_l2_len;\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->outer_l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t   pkt->outer_l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(len);\n \n \t/* Update the outer UDP header. */\n",
    "prefixes": [
        "v3",
        "01/14"
    ]
}