Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129355/?format=api
{ "id": 129355, "url": "http://patchwork.dpdk.org/api/patches/129355/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230706175938.62721-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230706175938.62721-6-stephen@networkplumber.org", "date": "2023-07-06T17:59:29", "name": "[v3,05/14] examples: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "50db909141a0032218296ca614f57d138304ce39", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 28867, "url": "http://patchwork.dpdk.org/api/series/28867/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28867", "date": "2023-07-06T17:59:24", "name": "Use rte_pktmbuf_mtod_offset() where possible", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28867/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129355/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129355/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A3AB42DEC;\n\tThu, 6 Jul 2023 20:00:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EDFB843017;\n\tThu, 6 Jul 2023 19:59:49 +0200 (CEST)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176])\n by mails.dpdk.org (Postfix) with ESMTP id 04C7342FE6\n for <dev@dpdk.org>; Thu, 6 Jul 2023 19:59:47 +0200 (CEST)", "by mail-pg1-f176.google.com with SMTP id\n 41be03b00d2f7-55bac17b442so789723a12.3\n for <dev@dpdk.org>; Thu, 06 Jul 2023 10:59:46 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n nh8-20020a17090b364800b00256bbfbabcfsm76464pjb.48.2023.07.06.10.59.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 Jul 2023 10:59:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688666386;\n x=1691258386;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8qVC3bA2BibKgFfmQilRnT4WLw2Cs5kUTFiZdVZhDJc=;\n b=dn+v69CDJGRt47cESV3KXqciMreyAzXdMDg2appSOqeMVJpeApkuNPdwMgoPIFJd5C\n 5bqBwaKHMJu0BxOwX5tfMfPHRmmfDvaxTKCTlE9vfbhu4ySziifkrBta/SSn7o3E8X3a\n mIZn2XR0OE8zUbUtNY8UdQZH2xpjCX4GVQmwQ82xQw3iYWT9DdBGhk5AGpNek9uEzWnL\n JXwch0HPEtoPakMEJuECr8fWipHSHBDHwn0+aInmz9EDueQqUj4K7/Zoat4db7hXDRGG\n RX1U9VRqsNK2Zmb+jilW9pWyQ++QjIbZQNoUHw9Xl6nX3zZD0venGbGjTGbiby+wbIwX\n aBJA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688666386; x=1691258386;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=8qVC3bA2BibKgFfmQilRnT4WLw2Cs5kUTFiZdVZhDJc=;\n b=F6NTBIkl2AU6n7I0MojORZK7NJYGyoh9YzaTp1cGOf+Ggn5BD1l2L05e93PlIh01ZK\n /uSAhyAB2uPT/qKArdVuKF2s+kS0iVTKmg8gI6wiQX/m8yEEweEs6CLVPZEoMG4ZPqY/\n hG28mtxgwOamo0AhFL0cwU1C8hZU+eVkGCKdol3stZlj/StidxYBpf7OavOOWnxc+S33\n uyveRT1P8owlug5FBNz8z3crjsghV6PVi36EV/Fi8DR1UpnFHm0PjXFyqircmYu2HuY6\n 0t6LyQhnvdEdzDyU66u+sauxlUWordZ9c8IDuHzfV3CaI5JKIiFf9e/Obpl9PsanGSyX\n A6mw==", "X-Gm-Message-State": "ABy/qLbJH3qmeN/MrnRxIPyjLl45LxamL0ftaGjkoTTddJ/PMUQgEfHK\n v3M/pQVJql3Yv9WSFs3YFIoUV7BtTMHEjz64rGU=", "X-Google-Smtp-Source": "\n APBJJlFkduZSnAWQjEYxu8awfu4nGC7ma3t5gPJayDsxC5cd9+c+s8X6PmOQ9ug9w6KaDlqIanOHmg==", "X-Received": "by 2002:a17:90a:4304:b0:263:f3ad:64b0 with SMTP id\n q4-20020a17090a430400b00263f3ad64b0mr2497468pjg.43.1688666385519;\n Thu, 06 Jul 2023 10:59:45 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>", "Subject": "[PATCH v3 05/14] examples: use rte_pktmbuf_mtod_offset", "Date": "Thu, 6 Jul 2023 10:59:29 -0700", "Message-Id": "<20230706175938.62721-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230706175938.62721-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230706175938.62721-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated from cocci/mtod-offset.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/l2fwd-crypto/main.c | 16 +++++++++-------\n examples/ptpclient/ptpclient.c | 18 +++++++++---------\n 2 files changed, 18 insertions(+), 16 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex efe7eea2a768..403ed6b44de9 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -410,8 +410,8 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \n \tipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n-\t\t\tipdata_offset);\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n+\t\t\t\t\t ipdata_offset);\n \n \tipdata_offset += (ip_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK)\n \t\t\t* RTE_IPV4_IHL_MULTIPLIER;\n@@ -479,8 +479,9 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->auth.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\t\t\tuint8_t *,\n+\t\t\t\t\t\t\tipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->auth.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -540,8 +541,9 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->aead.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\t\t\tuint8_t *,\n+\t\t\t\t\t\t\tipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->aead.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -631,7 +633,7 @@ l2fwd_simple_forward(struct rte_mbuf *m, uint16_t portid,\n \tstruct rte_ipv4_hdr *ip_hdr;\n \tuint32_t ipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n \t\t\t\t\t ipdata_offset);\n \tdst_port = l2fwd_dst_ports[portid];\n \ndiff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex cdf2da64dfee..2535d848a1e9 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -354,8 +354,8 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)\n {\n \tstruct ptp_header *ptp_hdr;\n \n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(ptp_data->m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(ptp_data->m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id);\n \n \tif (ptp_data->ptpset == 0) {\n@@ -397,15 +397,15 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \tint ret;\n \n \teth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);\n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tif (memcmp(&ptp_data->master_clock_id,\n \t\t\t&ptp_hdr->source_port_id.clock_id,\n \t\t\tsizeof(struct clock_id)) != 0)\n \t\treturn;\n \n \tptp_data->seqID_FOLLOWUP = rte_be_to_cpu_16(ptp_hdr->seq_id);\n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n \t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \torigin_tstamp = &ptp_msg->follow_up.precise_origin_tstamp;\n@@ -537,8 +537,8 @@ parse_drsp(struct ptpv2_data_slave_ordinary *ptp_data)\n \tstruct tstamp *rx_tstamp;\n \tuint16_t seq_id;\n \n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n-\t\t\t\t\tsizeof(struct rte_ether_hdr));\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tseq_id = rte_be_to_cpu_16(ptp_msg->delay_resp.hdr.seq_id);\n \tif (memcmp(&ptp_data->client_clock_id,\n \t\t &ptp_msg->delay_resp.req_port_id.clock_id,\n@@ -585,8 +585,8 @@ parse_ptp_frames(uint16_t portid, struct rte_mbuf *m) {\n \tif (eth_type == PTP_PROTOCOL) {\n \t\tptp_data.m = m;\n \t\tptp_data.portid = portid;\n-\t\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t\t\t+ sizeof(struct rte_ether_hdr));\n+\t\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \t\tswitch (ptp_hdr->msg_type) {\n \t\tcase SYNC:\n", "prefixes": [ "v3", "05/14" ] }