Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129361/?format=api
{ "id": 129361, "url": "http://patchwork.dpdk.org/api/patches/129361/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230706175938.62721-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230706175938.62721-12-stephen@networkplumber.org", "date": "2023-07-06T17:59:35", "name": "[v3,11/14] common/cpt: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3480627ea37d8e3e1a2efa656e7a5ee86cff343b", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230706175938.62721-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 28867, "url": "http://patchwork.dpdk.org/api/series/28867/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28867", "date": "2023-07-06T17:59:24", "name": "Use rte_pktmbuf_mtod_offset() where possible", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28867/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129361/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4E9E42DEC;\n\tThu, 6 Jul 2023 20:01:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D75643035;\n\tThu, 6 Jul 2023 19:59:57 +0200 (CEST)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id BFF1643010\n for <dev@dpdk.org>; Thu, 6 Jul 2023 19:59:52 +0200 (CEST)", "by mail-pj1-f44.google.com with SMTP id\n 98e67ed59e1d1-263036d54b9so785476a91.0\n for <dev@dpdk.org>; Thu, 06 Jul 2023 10:59:52 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n nh8-20020a17090b364800b00256bbfbabcfsm76464pjb.48.2023.07.06.10.59.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 Jul 2023 10:59:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688666392;\n x=1691258392;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uHOl7ikZRiwr8EvfJO8zGAtsJN8FkKXOFy50FiXm9zE=;\n b=sTYsOswYbss6rQ2Op67E677JuvkEv+uHiezqbZf3rEm/7iFJfBsIDNXZTxGJ9VSkAF\n bFgT2MFvFg0YDsjvOb9JrcUtBM/i+WIFKdHHcJG1aHrSdPGVpD9/fA8FmUNr2+mqBFjt\n 0oXIraZK3jHd3S4Iri0ZlUwtG+daG8CMPFzTmoNMCCj5iicKOJCHixojjzaWe5FE2mz2\n TWIZLKT5pz5SURo3E3UOW561SSjUUr6Knd6yAnzsvdtF2OXtytkLxS/RZV5rYG9gdHE6\n C0bvW99VuGHmktokkW2xmRiKz/7sdX+mNtZsMDqE7HaHEV6waDmkneSWT3a4tNl2ieOu\n I9AQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688666392; x=1691258392;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uHOl7ikZRiwr8EvfJO8zGAtsJN8FkKXOFy50FiXm9zE=;\n b=AMap/1rhKsuw4NIFrxJngzuzo82i3Ob+bD2qZO6kM1jPof21uOtxEYEKAmmvLVhR6S\n JuLhWDnyjNKjZif/vEzG9dItUjIZWxaz4gblIrez+1JYHNVq5HWH+UNezzKVJu0ixDA9\n 8Y1wfRoXvpIvM62QGlZqutBIi13VHZTNL6D6zNYOO0FYt/XqJZRYVkjHu1a4XDRF2gD0\n 3nyydYShC7TNt6S7IIxJE5qQonDRU+3H/SCDZcdMpQ32Vb2j0p1lMBuku6i75KcgfFow\n T75qIOzr+a/OeklDU/8u7gpZ3nnzTL5itgxbvQ9BElB00L1z1aMLFnyex11/43xVxz5q\n nt8w==", "X-Gm-Message-State": "ABy/qLaSbt6hj+v43pETWGH39luV4yQNQWzvxnwCFF/h6Vb4iX29Eb+T\n fpJpjqbanKjghYGVBB+PgzAqh9/S+7R1cMiTii8=", "X-Google-Smtp-Source": "\n APBJJlEwBSDMK6Dqud5s8fELbr9EetjnzjCQYhhBwgfO0Zx32oKwDbcRDFQ+KyWFW2uIyZerzybYAQ==", "X-Received": "by 2002:a17:90b:888:b0:262:fbb0:8737 with SMTP id\n bj8-20020a17090b088800b00262fbb08737mr2389998pjb.33.1688666391783;\n Thu, 06 Jul 2023 10:59:51 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anoob Joseph <anoobj@marvell.com>", "Subject": "[PATCH v3 11/14] common/cpt: use rte_pktmbuf_mtod_offset", "Date": "Thu, 6 Jul 2023 10:59:35 -0700", "Message-Id": "<20230706175938.62721-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230706175938.62721-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230706175938.62721-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Autogenerated with cocci/mtod-offset.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/cpt/cpt_ucode.h | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h\nindex b393be4cf661..87a3ac80b9da 100644\n--- a/drivers/common/cpt/cpt_ucode.h\n+++ b/drivers/common/cpt/cpt_ucode.h\n@@ -3167,9 +3167,8 @@ fill_fc_params(struct rte_crypto_op *cop,\n \t\t\t\tm = m_src;\n \n \t\t\t/* hmac immediately following data is best case */\n-\t\t\tif (unlikely(rte_pktmbuf_mtod(m, uint8_t *) +\n-\t\t\t mc_hash_off !=\n-\t\t\t (uint8_t *)sym_op->aead.digest.data)) {\n+\t\t\tif (unlikely(rte_pktmbuf_mtod_offset(m, uint8_t *, mc_hash_off) !=\n+\t\t\t\t (uint8_t *)sym_op->aead.digest.data)) {\n \t\t\t\tflags |= VALID_MAC_BUF;\n \t\t\t\tfc_params.mac_buf.size = sess_misc->mac_len;\n \t\t\t\tfc_params.mac_buf.vaddr =\n@@ -3211,9 +3210,8 @@ fill_fc_params(struct rte_crypto_op *cop,\n \n \t\t\t/* hmac immediately following data is best case */\n \t\t\tif (!ctx->dec_auth && !ctx->auth_enc &&\n-\t\t\t\t (unlikely(rte_pktmbuf_mtod(m, uint8_t *) +\n-\t\t\t mc_hash_off !=\n-\t\t\t (uint8_t *)sym_op->auth.digest.data))) {\n+\t\t\t\t (unlikely(rte_pktmbuf_mtod_offset(m, uint8_t *, mc_hash_off) !=\n+\t\t\t\t\t (uint8_t *)sym_op->auth.digest.data))) {\n \t\t\t\tflags |= VALID_MAC_BUF;\n \t\t\t\tfc_params.mac_buf.size =\n \t\t\t\t\tsess_misc->mac_len;\n", "prefixes": [ "v3", "11/14" ] }