Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129376/?format=api
{ "id": 129376, "url": "http://patchwork.dpdk.org/api/patches/129376/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230707203908.64371-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230707203908.64371-3-stephen@networkplumber.org", "date": "2023-07-07T20:38:59", "name": "[v4,02/11] gso: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "78c6dda7bd086c0641456f4b68c577cf363348b5", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28877, "url": "http://patchwork.dpdk.org/api/series/28877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28877", "date": "2023-07-07T20:38:57", "name": "Use rte_pktmbuf_mtod_offset", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28877/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129376/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129376/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75D7A42DFC;\n\tFri, 7 Jul 2023 22:39:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 61B0C4114A;\n\tFri, 7 Jul 2023 22:39:15 +0200 (CEST)", "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4B6EA410F2\n for <dev@dpdk.org>; Fri, 7 Jul 2023 22:39:14 +0200 (CEST)", "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1b8bbcfd89aso13075165ad.1\n for <dev@dpdk.org>; Fri, 07 Jul 2023 13:39:14 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n t15-20020a170902b20f00b001b83db0bcf2sm3640493plr.141.2023.07.07.13.39.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 13:39:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688762353;\n x=1691354353;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Fyd9fvDhmU+f9LsoJiKnaY2sIp+gPp8qyRItqoaA58Y=;\n b=ylfMHjzVK3TrytjCFjhnS1ELqj4CU+Vt7p2JG6DxHMB4SGOC7uXASzqLh6Pv0jdL48\n EWn4n4Ufj5nE2+FNZ8kcsThjLAE0rcA0VRvcLMXkhHTV3r4IzdnZ/MBFvpVxDGxc4wdy\n zA1KtfMNJkC7cwvV2gkrFXkI7Hl8r/xAGjVEE08ACpHL+CCM0wOmgWzN0GAqIyt1Dvq8\n OoNdA14S5EHa6KqvnLhoQkggY9okLpivG6AyoxHyGmC4f/KTmyYzfVKAll7Xs6eJk4/K\n o39LnSstouZg6S+SD8c6Xzexdu/Z6g8V/oMfH3uN3XMxY2z7hGSJJRZX4tFYsWemfMZ1\n LhBA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688762353; x=1691354353;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Fyd9fvDhmU+f9LsoJiKnaY2sIp+gPp8qyRItqoaA58Y=;\n b=Tpqc5x942FDGnMYQC+P0Or1hDNKozTNf3D72GgytlC92OmmGzpbp+uo1Sekm/rnEZ3\n aBoXe5DlKnfie89gakoVF06h4YngIPVU+9uY/qEqABcBbUa1Hkqn1NrNAeA/hBgWdYPe\n I0BC66cA1caXOYzpX7TVFzjZCoeeuTrK7sV8NUu9/RJol3kV7rx/u6sMjQCRHbl2hxb9\n tIWzLSIJaK5VyDZVZdPYOAfuFLx/Hqm7d0MruplR5OdAhcTdL7vT6od1ZzGjlUQoc7x7\n o9ILWeHEBuLDzpUURQcPH8EpOj3vnmogTeobq2TBYhEpOEWVu21gii5wQSVsU5VbrGri\n 3ixA==", "X-Gm-Message-State": "ABy/qLZUCWeyv7GDXTulNP9EWJc7dQOePDCvJ0u+UL9gw98VNwmSI/bF\n 4wtRMVOmAz7OVIMmIBQmNXfUBzl9725yL7Vdc/UJF1Cf", "X-Google-Smtp-Source": "\n APBJJlGLQ7VRw7GM56PlY6LmRuxTbMnXSX4FjhWYcrnEyjMybaHJlkZNGuA+B+tV016nkzJV9wTspg==", "X-Received": "by 2002:a17:902:d4ce:b0:1ac:8be5:8787 with SMTP id\n o14-20020a170902d4ce00b001ac8be58787mr5626394plg.21.1688762353225;\n Fri, 07 Jul 2023 13:39:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>", "Subject": "[PATCH v4 02/11] gso: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 13:38:59 -0700", "Message-Id": "<20230707203908.64371-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230707203908.64371-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230707203908.64371-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/gso_common.h | 12 ++++++------\n lib/gso/gso_tcp4.c | 8 ++++----\n lib/gso/gso_tunnel_tcp4.c | 12 ++++++------\n lib/gso/gso_tunnel_udp4.c | 18 +++++++++---------\n 4 files changed, 25 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/gso/gso_common.h b/lib/gso/gso_common.h\nindex 9456d596d3c5..4100765f2355 100644\n--- a/lib/gso/gso_common.h\n+++ b/lib/gso/gso_common.h\n@@ -52,8 +52,8 @@ update_udp_header(struct rte_mbuf *pkt, uint16_t udp_offset)\n {\n \tstruct rte_udp_hdr *udp_hdr;\n \n-\tudp_hdr = (struct rte_udp_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tudp_offset);\n+\tudp_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_udp_hdr *,\n+\t\t\t\t\t udp_offset);\n \tudp_hdr->dgram_len = rte_cpu_to_be_16(pkt->pkt_len - udp_offset);\n }\n \n@@ -77,8 +77,8 @@ update_tcp_header(struct rte_mbuf *pkt, uint16_t l4_offset, uint32_t sent_seq,\n {\n \tstruct rte_tcp_hdr *tcp_hdr;\n \n-\ttcp_hdr = (struct rte_tcp_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tl4_offset);\n+\ttcp_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_tcp_hdr *,\n+\t\t\t\t l4_offset);\n \ttcp_hdr->sent_seq = rte_cpu_to_be_32(sent_seq);\n \tif (likely(non_tail))\n \t\ttcp_hdr->tcp_flags &= (~(TCP_HDR_PSH_MASK |\n@@ -104,8 +104,8 @@ update_ipv4_header(struct rte_mbuf *pkt, uint16_t l3_offset, uint16_t id)\n {\n \tstruct rte_ipv4_hdr *ipv4_hdr;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tl3_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t l3_offset);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len - l3_offset);\n \tipv4_hdr->packet_id = rte_cpu_to_be_16(id);\n }\ndiff --git a/lib/gso/gso_tcp4.c b/lib/gso/gso_tcp4.c\nindex d31feaff95cd..e2ae4aaf6c5a 100644\n--- a/lib/gso/gso_tcp4.c\n+++ b/lib/gso/gso_tcp4.c\n@@ -16,8 +16,8 @@ update_ipv4_tcp_headers(struct rte_mbuf *pkt, uint8_t ipid_delta,\n \tuint16_t l3_offset = pkt->l2_len;\n \tuint16_t l4_offset = l3_offset + pkt->l3_len;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char*) +\n-\t\t\tl3_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t l3_offset);\n \ttcp_hdr = (struct rte_tcp_hdr *)((char *)ipv4_hdr + pkt->l3_len);\n \tid = rte_be_to_cpu_16(ipv4_hdr->packet_id);\n \tsent_seq = rte_be_to_cpu_32(tcp_hdr->sent_seq);\n@@ -46,8 +46,8 @@ gso_tcp4_segment(struct rte_mbuf *pkt,\n \tint ret;\n \n \t/* Don't process the fragmented packet */\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t pkt->l2_len);\n \tfrag_off = rte_be_to_cpu_16(ipv4_hdr->fragment_offset);\n \tif (unlikely(IS_FRAGMENTED(frag_off))) {\n \t\treturn 0;\ndiff --git a/lib/gso/gso_tunnel_tcp4.c b/lib/gso/gso_tunnel_tcp4.c\nindex 1a7ef30ddebf..3a9159774b27 100644\n--- a/lib/gso/gso_tunnel_tcp4.c\n+++ b/lib/gso/gso_tunnel_tcp4.c\n@@ -23,13 +23,13 @@ update_tunnel_ipv4_tcp_headers(struct rte_mbuf *pkt, uint8_t ipid_delta,\n \ttcp_offset = inner_ipv4_offset + pkt->l3_len;\n \n \t/* Outer IPv4 header. */\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\touter_ipv4_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t outer_ipv4_offset);\n \touter_id = rte_be_to_cpu_16(ipv4_hdr->packet_id);\n \n \t/* Inner IPv4 header. */\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tinner_ipv4_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t inner_ipv4_offset);\n \tinner_id = rte_be_to_cpu_16(ipv4_hdr->packet_id);\n \n \ttcp_hdr = (struct rte_tcp_hdr *)((char *)ipv4_hdr + pkt->l3_len);\n@@ -65,8 +65,8 @@ gso_tunnel_tcp4_segment(struct rte_mbuf *pkt,\n \tint ret;\n \n \thdr_offset = pkt->outer_l2_len + pkt->outer_l3_len + pkt->l2_len;\n-\tinner_ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\thdr_offset);\n+\tinner_ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t\t hdr_offset);\n \t/*\n \t * Don't process the packet whose MF bit or offset in the inner\n \t * IPv4 header are non-zero.\ndiff --git a/lib/gso/gso_tunnel_udp4.c b/lib/gso/gso_tunnel_udp4.c\nindex 1fc7a8dbc5aa..4fb275484ca8 100644\n--- a/lib/gso/gso_tunnel_udp4.c\n+++ b/lib/gso/gso_tunnel_udp4.c\n@@ -22,13 +22,13 @@ update_tunnel_ipv4_udp_headers(struct rte_mbuf *pkt, struct rte_mbuf **segs,\n \tinner_ipv4_offset = outer_udp_offset + pkt->l2_len;\n \n \t/* Outer IPv4 header. */\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\touter_ipv4_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t outer_ipv4_offset);\n \touter_id = rte_be_to_cpu_16(ipv4_hdr->packet_id);\n \n \t/* Inner IPv4 header. */\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tinner_ipv4_offset);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t inner_ipv4_offset);\n \tinner_id = rte_be_to_cpu_16(ipv4_hdr->packet_id);\n \n \ttail_idx = nb_segs - 1;\n@@ -42,9 +42,9 @@ update_tunnel_ipv4_udp_headers(struct rte_mbuf *pkt, struct rte_mbuf **segs,\n \t\t *\n \t\t * Set IP fragment offset for inner IP header.\n \t\t */\n-\t\tipv4_hdr = (struct rte_ipv4_hdr *)\n-\t\t\t(rte_pktmbuf_mtod(segs[i], char *) +\n-\t\t\t\tinner_ipv4_offset);\n+\t\tipv4_hdr = rte_pktmbuf_mtod_offset(segs[i],\n+\t\t\t\t\t\t struct rte_ipv4_hdr *,\n+\t\t\t\t\t\t inner_ipv4_offset);\n \t\tis_mf = i < tail_idx ? IPV4_HDR_MF_BIT : 0;\n \t\tipv4_hdr->fragment_offset =\n \t\t\trte_cpu_to_be_16(frag_offset | is_mf);\n@@ -67,8 +67,8 @@ gso_tunnel_udp4_segment(struct rte_mbuf *pkt,\n \tint ret;\n \n \thdr_offset = pkt->outer_l2_len + pkt->outer_l3_len + pkt->l2_len;\n-\tinner_ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\thdr_offset);\n+\tinner_ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t\t hdr_offset);\n \t/*\n \t * Don't process the packet whose MF bit or offset in the inner\n \t * IPv4 header are non-zero.\n", "prefixes": [ "v4", "02/11" ] }