Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129377/?format=api
{ "id": 129377, "url": "http://patchwork.dpdk.org/api/patches/129377/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230707203908.64371-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230707203908.64371-4-stephen@networkplumber.org", "date": "2023-07-07T20:39:00", "name": "[v4,03/11] test: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8f42943931e6659ebd5b9763d6d7e221947d4bc6", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 28877, "url": "http://patchwork.dpdk.org/api/series/28877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28877", "date": "2023-07-07T20:38:57", "name": "Use rte_pktmbuf_mtod_offset", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28877/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129377/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EBD3F42DFC;\n\tFri, 7 Jul 2023 22:39:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E861A41104;\n\tFri, 7 Jul 2023 22:39:17 +0200 (CEST)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 4B90541101\n for <dev@dpdk.org>; Fri, 7 Jul 2023 22:39:15 +0200 (CEST)", "by mail-pl1-f172.google.com with SMTP id\n d9443c01a7336-1b8a8154f9cso16168915ad.1\n for <dev@dpdk.org>; Fri, 07 Jul 2023 13:39:15 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n t15-20020a170902b20f00b001b83db0bcf2sm3640493plr.141.2023.07.07.13.39.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 13:39:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688762354;\n x=1691354354;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9JJH8wAjbmw9YwG+bgmj7mYrFRf9ITchTVYKBx8wiKk=;\n b=EBVVrYbmR3jslAth10RZs+Thie0RUSt+HzztZn9f7gyq7A2yZ0NTjT6z34dKoU9soj\n wfHDNgWkb+pNuDyLLqK7xJJEE0CB4mwiGe7KRYztPLDFhIOGTq1pukDquKVZqq4K4NJj\n 9a2wZK2qsXpGXp4CWlUhxQN70+XBOeGU5kgiTgAlnOJB5QAstUpiEVA4TkCCQ+g43B94\n tSYEI7t9uCgu4KeHvIS6jzi5gDXwEB+DdNkmHAxx2c/d3x+ejIe51maZRTNJBFCwLChJ\n MSgzsdjyaHN5Cku6mlpyRZLuZaVSxOHOdWn3AgfaETLeu+iphbdscR5gzxZvr6hazweU\n tx2w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688762354; x=1691354354;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9JJH8wAjbmw9YwG+bgmj7mYrFRf9ITchTVYKBx8wiKk=;\n b=e3vUXc+bOxxBicW/quX6O86kVgzpGahLNzPK6BFTo+43RtNQHzIcz6nVYXucv3lar6\n FxqcRTAXDMADXu41PNrmikvdytH8Ve9ZAhqtKr5k4U2Y+bqnnOuXGU5G/jtyuTJQV4Bk\n RGI2g5k4N+sUJYUoAJWG8MIA8aa3Vae1UzQ487B5JXzCw54ygzb/ucmIi2wKXFtrJuu/\n YYWli8RhfRWGTuPyH+rmQJtbDAOFYc3aT+BeYLQ+8CUKbO/VUHQy2MvjzakfZEfVmCob\n EUgphQlOYEZlLohOyflEc0VadMqx8YMUB7Wq6/DThcYadwlfEPiPJUVAGnETH+qoiKIn\n Fqyg==", "X-Gm-Message-State": "ABy/qLbo1VJLljzOyrQQLUNnwbzza1gMy8XIrnjr2QznnQIQsBKvMXqT\n WoyAyxRA4s64COjdljIzCDbq+0C8GfqYgxambZw5ajNM", "X-Google-Smtp-Source": "\n APBJJlFj79xT5bl3bKtCA8wLqruG6BBJV0JRWwF/bh2yGeMeUv0UbbL4knppSqFITcsFHKYqocBExQ==", "X-Received": "by 2002:a17:902:a514:b0:1b1:99c9:8ce5 with SMTP id\n s20-20020a170902a51400b001b199c98ce5mr11522241plq.16.1688762354114;\n Fri, 07 Jul 2023 13:39:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH v4 03/11] test: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 13:39:00 -0700", "Message-Id": "<20230707203908.64371-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230707203908.64371-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230707203908.64371-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_cryptodev.c | 66 +++++++++++++++++++++------------------\n 1 file changed, 36 insertions(+), 30 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex fb2af40b99ee..c79681255106 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -3153,8 +3153,9 @@ test_snow3g_authentication(const struct snow3g_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tut_params->obuf = ut_params->op->sym->m_src;\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -3247,8 +3248,9 @@ test_snow3g_authentication_verify(const struct snow3g_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tif (ut_params->op->status == RTE_CRYPTO_OP_STATUS_SUCCESS)\n@@ -3337,8 +3339,9 @@ test_kasumi_authentication(const struct kasumi_hash_test_data *tdata)\n \n \tut_params->obuf = ut_params->op->sym->m_src;\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -3425,8 +3428,9 @@ test_kasumi_authentication_verify(const struct kasumi_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tif (ut_params->op->status == RTE_CRYPTO_OP_STATUS_SUCCESS)\n@@ -4879,8 +4883,9 @@ test_zuc_cipher_auth(const struct wireless_test_data *tdata)\n \t\t\ttdata->validDataLenInBits.len,\n \t\t\t\"ZUC Ciphertext data not as expected\");\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t + plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -4994,8 +4999,9 @@ test_snow3g_cipher_auth(const struct snow3g_test_data *tdata)\n \t\t\ttdata->validDataLenInBits.len,\n \t\t\t\"SNOW 3G Ciphertext data not as expected\");\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t + plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -5163,9 +5169,9 @@ test_snow3g_auth_cipher(const struct snow3g_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ (tdata->digest.offset_bytes == 0 ?\n-\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t (tdata->digest.offset_bytes == 0 ? plaintext_pad_len : tdata->digest.offset_bytes));\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -5577,10 +5583,9 @@ test_kasumi_auth_cipher(const struct kasumi_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(\n-\t\t\tut_params->obuf, uint8_t *) +\n-\t\t\t(tdata->digest.offset_bytes == 0 ?\n-\t\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t (tdata->digest.offset_bytes == 0 ? plaintext_pad_len : tdata->digest.offset_bytes));\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -5924,8 +5929,9 @@ test_kasumi_cipher_auth(const struct kasumi_test_data *tdata)\n \tciphertext = rte_pktmbuf_mtod_offset(ut_params->obuf, uint8_t *,\n \t\t\t\ttdata->validCipherOffsetInBits.len >> 3);\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \tconst uint8_t *reference_ciphertext = tdata->ciphertext.data +\n \t\t\t\t(tdata->validCipherOffsetInBits.len >> 3);\n@@ -6344,8 +6350,9 @@ test_zuc_authentication(const struct wireless_test_data *tdata,\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \tif (auth_op != RTE_CRYPTO_AUTH_OP_VERIFY) {\n \t\t/* Validate obuf */\n@@ -6531,10 +6538,9 @@ test_zuc_auth_cipher(const struct wireless_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(\n-\t\t\tut_params->obuf, uint8_t *) +\n-\t\t\t(tdata->digest.offset_bytes == 0 ?\n-\t\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t (tdata->digest.offset_bytes == 0 ? plaintext_pad_len : tdata->digest.offset_bytes));\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -7959,9 +7965,9 @@ test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data *tdata,\n \t\t\t\ttdata->ciphertext.data,\n \t\t\t\ttdata->ciphertext.len_bits >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ (tdata->digest_enc.offset == 0 ?\n-\t\tplaintext_pad_len : tdata->digest_enc.offset);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t (tdata->digest_enc.offset == 0 ? plaintext_pad_len : tdata->digest_enc.offset));\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\t\ttdata->digest_enc.len);\n", "prefixes": [ "v4", "03/11" ] }