Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129384/?format=api
{ "id": 129384, "url": "http://patchwork.dpdk.org/api/patches/129384/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230707203908.64371-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230707203908.64371-11-stephen@networkplumber.org", "date": "2023-07-07T20:39:07", "name": "[v4,10/11] examples/ptpclient: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e768726953e54cacddcfe8369b519e9a41f8bdfd", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 28877, "url": "http://patchwork.dpdk.org/api/series/28877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28877", "date": "2023-07-07T20:38:57", "name": "Use rte_pktmbuf_mtod_offset", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28877/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129384/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129384/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AAEAC42DFC;\n\tFri, 7 Jul 2023 22:40:15 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 639D842D4B;\n\tFri, 7 Jul 2023 22:39:26 +0200 (CEST)", "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id A17C742D2D\n for <dev@dpdk.org>; Fri, 7 Jul 2023 22:39:21 +0200 (CEST)", "by mail-pl1-f181.google.com with SMTP id\n d9443c01a7336-1b8b318c5a7so16071455ad.3\n for <dev@dpdk.org>; Fri, 07 Jul 2023 13:39:21 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n t15-20020a170902b20f00b001b83db0bcf2sm3640493plr.141.2023.07.07.13.39.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 13:39:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688762360;\n x=1691354360;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kCWRDMcwmvFF9ALe0kl8MmyAQw2GA717TEvW0vvHaVg=;\n b=i0aH8SN+fiL8m9lY9RYvPt+pm1xPMVcmwN6IqkzE53b2ozvl5rY/bfQpanNi1hYTWY\n Gc0GPVXZxxJE6iP+25YmikLCnd65Gc0K7fMHm/T07qMxmU5bdqM0uuQT1rLQpV3EHr2O\n FLkeV8q9qVk+sD1PSi1m9AA9GgT7GCAcql/GmR4tK+xlvhwSoOVGTZQc0PfXrKy/3fN8\n W5mCg9pVFpmL0RwRvP+A9GNVga4myKeufWnUlUrHMujFrYRoyGM77KBXcvUwNkMnFNv3\n yfIeJDK87Ib0kK+bO4qhWZotksIRa9+qUA1ZfRbb1gwiu5US+1eJ83h8BcXszVS2tFQ0\n RQxg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688762360; x=1691354360;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=kCWRDMcwmvFF9ALe0kl8MmyAQw2GA717TEvW0vvHaVg=;\n b=cPmVvQm1yIFrDBxFbWxsOaYYxl2vGIOqZu/jKtmwoQpoaRcgvfznd4HH2jzMO9C3VI\n NuOUEPwheefefqiQoEZqejvXA993s8WN48VdsL3Aeel2KOArupKtdTIOPDsxJhAR/wwl\n fsSRZRbE5Go2H+dPZPnoofpJshxsNCv7U8DQ9da91QEjt+tjxQGK6iyDOVnZ0beJdlDZ\n s1Qakh9kyIxOHDm/JU/qitphCvTc1q4nmOEsEBvyGmw0fj/tcbcfJ0ygmhAzOnyLBKu6\n 72cV2TSthvySVWPKl3AlGr4gDhqtvvBIhnEOG1VEzKADWbEdcaSM8Ni57SL/b9a8JNZD\n Y0uw==", "X-Gm-Message-State": "ABy/qLYXNNGAPZ5GP/ppcPCmfLLJLCES7cNAjBKtxJr+oCn7cXbzoVEy\n uc0r8eId0OnQGiD4EjYUtz5x5Hdo6qmZ6h2/lZ4ghK2O", "X-Google-Smtp-Source": "\n APBJJlG7ENu8E/BdS7VtTlsd7gOTT3iFaQ+rwpOYEjJO0nEMtEX4KWd3vOTI5qOVb6/3aQEydm03Kg==", "X-Received": "by 2002:a17:902:d395:b0:1b9:be2e:2b40 with SMTP id\n e21-20020a170902d39500b001b9be2e2b40mr3934537pld.50.1688762360715;\n Fri, 07 Jul 2023 13:39:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>", "Subject": "[PATCH v4 10/11] examples/ptpclient: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 13:39:07 -0700", "Message-Id": "<20230707203908.64371-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230707203908.64371-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230707203908.64371-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/ptpclient/ptpclient.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex cdf2da64dfee..2535d848a1e9 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -354,8 +354,8 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)\n {\n \tstruct ptp_header *ptp_hdr;\n \n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(ptp_data->m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(ptp_data->m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id);\n \n \tif (ptp_data->ptpset == 0) {\n@@ -397,15 +397,15 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \tint ret;\n \n \teth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);\n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tif (memcmp(&ptp_data->master_clock_id,\n \t\t\t&ptp_hdr->source_port_id.clock_id,\n \t\t\tsizeof(struct clock_id)) != 0)\n \t\treturn;\n \n \tptp_data->seqID_FOLLOWUP = rte_be_to_cpu_16(ptp_hdr->seq_id);\n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n \t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \torigin_tstamp = &ptp_msg->follow_up.precise_origin_tstamp;\n@@ -537,8 +537,8 @@ parse_drsp(struct ptpv2_data_slave_ordinary *ptp_data)\n \tstruct tstamp *rx_tstamp;\n \tuint16_t seq_id;\n \n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n-\t\t\t\t\tsizeof(struct rte_ether_hdr));\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tseq_id = rte_be_to_cpu_16(ptp_msg->delay_resp.hdr.seq_id);\n \tif (memcmp(&ptp_data->client_clock_id,\n \t\t &ptp_msg->delay_resp.req_port_id.clock_id,\n@@ -585,8 +585,8 @@ parse_ptp_frames(uint16_t portid, struct rte_mbuf *m) {\n \tif (eth_type == PTP_PROTOCOL) {\n \t\tptp_data.m = m;\n \t\tptp_data.portid = portid;\n-\t\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t\t\t+ sizeof(struct rte_ether_hdr));\n+\t\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \t\tswitch (ptp_hdr->msg_type) {\n \t\tcase SYNC:\n", "prefixes": [ "v4", "10/11" ] }