Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129385/?format=api
{ "id": 129385, "url": "http://patchwork.dpdk.org/api/patches/129385/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230707203908.64371-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230707203908.64371-12-stephen@networkplumber.org", "date": "2023-07-07T20:39:08", "name": "[v4,11/11] examples/l2fwd-crypto: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4c462da1f62870b451ef3a70b89acff2412fabd4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230707203908.64371-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 28877, "url": "http://patchwork.dpdk.org/api/series/28877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28877", "date": "2023-07-07T20:38:57", "name": "Use rte_pktmbuf_mtod_offset", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28877/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129385/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C5CF42DFC;\n\tFri, 7 Jul 2023 22:40:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 93A9742D52;\n\tFri, 7 Jul 2023 22:39:27 +0200 (CEST)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 8A86042D30\n for <dev@dpdk.org>; Fri, 7 Jul 2023 22:39:22 +0200 (CEST)", "by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-1b89cfb4571so15757695ad.3\n for <dev@dpdk.org>; Fri, 07 Jul 2023 13:39:22 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n t15-20020a170902b20f00b001b83db0bcf2sm3640493plr.141.2023.07.07.13.39.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 13:39:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688762361;\n x=1691354361;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wwS2rmOQ9nJLLKvDK9MXA/E8Oeyws+SFh/8bRR3Jcbs=;\n b=uP1h1dTdXXSrDotYVeuE/s3JimM3BrR5Bcp0myq0ncuqMBFPgWSHdaJU8TrvLVeX08\n JZSQMBHwY/rCB1oyGnPemyXjQbbUkM9fDvqsK6MGqnd+EcS/R3v9iaUFL+/zH0znIFQp\n ccVfOC3vP5eMbjxQlsEbenTUD03hL5wT3+YeMgLFc8bjFkKrb0FUL8xLwO9694UM+KiK\n fjc9dMwe2iHtc7gz3N4XbYH051KyTPZC5bAt6wYVWC370fjWkLG6eRHPppLSJu5zDmrs\n CgezVhEI4qDoqvJLCcqYtl/DCzf+OGsR90He4zlBRrzvu78uxahfDBqpP66qnns2XXwY\n vaFg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688762361; x=1691354361;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=wwS2rmOQ9nJLLKvDK9MXA/E8Oeyws+SFh/8bRR3Jcbs=;\n b=ZrBrXlmNi5GBWK6jFdA4Rsay1MUhbraw1GSmbf8eZLM/rULEemW2yore5ooTB6SFKz\n QlI6G7SpvVNr/Cxmhi3X/OKXJqq6t/zjVxoHvY263wRqo0mq7W9fI3vgcO5Sfn9p5XQj\n rcAWL+57a82uHM8iPbFhZCjJzM7qDN0NMuxpk3gouiCsrNE2SE1AEekHEqzDg2mXvgYP\n bsai70x8izM9ybM3Z+c4dU1BK4bmatKS0f7Q3FKMEyXd00I2H/spHSB6Fs5/qek9/5mk\n FHGBFYui8nWdy3VOBgegl9Zxa2pnzgpI00I3EkP04ZKTJnXHKMbx+QsaBMcxkcWbugsZ\n wO1A==", "X-Gm-Message-State": "ABy/qLYFCUIFJ8/jy85yeldxcGYu1lWxBeNC3ExcCK9QXbJ5smPWIjmm\n lir5vwygAgMLoWLspqHO/ykxZYJ2T1qBwdROwyIGimla", "X-Google-Smtp-Source": "\n APBJJlFiHsUGqe9s0FBejyjR9Qvc7rC2egDCrKZjtO2iKfNe9BF9/zRX3bosQyC/+Y0GTqKKdRIcjw==", "X-Received": "by 2002:a17:902:b691:b0:1b8:987f:3f34 with SMTP id\n c17-20020a170902b69100b001b8987f3f34mr5664266pls.25.1688762361545;\n Fri, 07 Jul 2023 13:39:21 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH v4 11/11] examples/l2fwd-crypto: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 13:39:08 -0700", "Message-Id": "<20230707203908.64371-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230707203908.64371-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230707203908.64371-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/l2fwd-crypto/main.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex efe7eea2a768..981b449710a7 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -410,8 +410,8 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \n \tipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n-\t\t\tipdata_offset);\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n+\t\t\t\t\t ipdata_offset);\n \n \tipdata_offset += (ip_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK)\n \t\t\t* RTE_IPV4_IHL_MULTIPLIER;\n@@ -479,8 +479,9 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->auth.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t\t\t ipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->auth.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -540,8 +541,9 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->aead.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t\t\t\t ipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->aead.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -631,7 +633,7 @@ l2fwd_simple_forward(struct rte_mbuf *m, uint16_t portid,\n \tstruct rte_ipv4_hdr *ip_hdr;\n \tuint32_t ipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n \t\t\t\t\t ipdata_offset);\n \tdst_port = l2fwd_dst_ports[portid];\n \n", "prefixes": [ "v4", "11/11" ] }