Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129387/?format=api
{ "id": 129387, "url": "http://patchwork.dpdk.org/api/patches/129387/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230708015718.75565-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230708015718.75565-2-stephen@networkplumber.org", "date": "2023-07-08T01:57:08", "name": "[v5,01/11] gro: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9a6a3578da86f6a88392ea7bd06ecc59e50a3125", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 28878, "url": "http://patchwork.dpdk.org/api/series/28878/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28878", "date": "2023-07-08T01:57:07", "name": "use rte_pktmbuf_mto_offset", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28878/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129387/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129387/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4356242DFC;\n\tSat, 8 Jul 2023 03:57:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC6604114A;\n\tSat, 8 Jul 2023 03:57:24 +0200 (CEST)", "from mail-ot1-f52.google.com (mail-ot1-f52.google.com\n [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id C4BCB40A8A\n for <dev@dpdk.org>; Sat, 8 Jul 2023 03:57:22 +0200 (CEST)", "by mail-ot1-f52.google.com with SMTP id\n 46e09a7af769-6b8decf09e1so2352213a34.0\n for <dev@dpdk.org>; Fri, 07 Jul 2023 18:57:22 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n 24-20020a17090a035800b00263f5ac814esm2260269pjf.38.2023.07.07.18.57.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 18:57:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688781442;\n x=1691373442;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vObgcPMDzvD/5VxKEhbH2z7+/u+sGbwSbqWVkuVmxZs=;\n b=omB4hFpJpoydz8FPWHufWc0tyBRatRl+4+2eJunbN6Lp6le8XOvOvvvYVf0+raOjvG\n hbn/j14vvbRarELKDg/MEDkt8OPOyx61PGClBYnILqvhDmK7ueo2fT02mBxiypCgywmG\n FUgfnTHEFvP6B+P2RU/LFAMTa07feszIrqe6wvWwXl2oe1be1ktXRxcfLthHBclcAxEf\n LlAtsttRankVFS+OASfOq95fabNHwsxFa9Z1qdopM6iz6im+1tnzMEkmd/SWWrdk8lPk\n L6sCPdyR008a7Isr61rkIJo0v67StL9Cu+J81duFiEpKDW6C8B9P6JnV4nP91Q7A7+ZH\n Fw/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688781442; x=1691373442;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vObgcPMDzvD/5VxKEhbH2z7+/u+sGbwSbqWVkuVmxZs=;\n b=icxspRize6OdMcK9LMfkvi/b2SYXQ0tAerlxpDo7Xys0OtQPpey1CbGJUjdeoCbvOT\n BZghnfuaYQEgUVC+6c13UqsSFtqDMbLJVXckvfCJtlw4M74UNJxvBcpdiQpDvkr2ZeP4\n +o5VPRHytQEovQvKGTZNlSV+KH5qJ2j+e4HqIGEyJtf1pwQsJbHNkBxbMD6Do08KIbwd\n /d8Q40VwyAKhzuosuDKpMznI+wrM6hKXQHlQGcZPQlZJ6d53O4xuw0qtWeexeFytJ+e5\n fIiqHJYNa1X+fySEmQWAYKtJTcFMVprTvl9cM2KxJ+FGx/LLam4hppoEZSNKu1s2A2o2\n ndtg==", "X-Gm-Message-State": "ABy/qLbabSjRjc4A5s0k/d4FRKA38JOBf4+Rk3XSgMB0IEuw4Gx7ny/g\n HANfXJKRVBS7+5xREV403QQSdn72ETKyi7aOssGBzrfA", "X-Google-Smtp-Source": "\n APBJJlEb+y7OZxiifhbmLaOK6vuwHkFtmLmd+Q5SHHAJfHRqV5uaRWhgw7STF2e4z/q30bNHATaTIA==", "X-Received": "by 2002:a05:6870:79e:b0:1b0:22b3:25ff with SMTP id\n en30-20020a056870079e00b001b022b325ffmr7603997oab.47.1688781441763;\n Fri, 07 Jul 2023 18:57:21 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>", "Subject": "[PATCH v5 01/11] gro: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 18:57:08 -0700", "Message-Id": "<20230708015718.75565-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230708015718.75565-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230708015718.75565-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gro/gro_tcp.h | 4 ++--\n lib/gro/gro_tcp4.c | 4 ++--\n lib/gro/gro_tcp6.c | 4 ++--\n lib/gro/gro_udp4.c | 4 ++--\n lib/gro/gro_vxlan_tcp4.c | 4 ++--\n lib/gro/gro_vxlan_udp4.c | 4 ++--\n 6 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/gro/gro_tcp.h b/lib/gro/gro_tcp.h\nindex d926c4b8cc71..bbd2f9c16a00 100644\n--- a/lib/gro/gro_tcp.h\n+++ b/lib/gro/gro_tcp.h\n@@ -150,8 +150,8 @@ check_seq_option(struct gro_tcp_item *item,\n \tstruct rte_tcp_hdr *tcph_orig;\n \tuint16_t len, tcp_hl_orig;\n \n-\tiph_orig = (char *)(rte_pktmbuf_mtod(pkt_orig, char *) +\n-\t\t\tl2_offset + pkt_orig->l2_len);\n+\tiph_orig = rte_pktmbuf_mtod_offset(pkt_orig, char *,\n+\t\t\t\t\t l2_offset + pkt_orig->l2_len);\n \ttcph_orig = (struct rte_tcp_hdr *)(iph_orig + pkt_orig->l3_len);\n \ttcp_hl_orig = pkt_orig->l4_len;\n \ndiff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c\nindex 6645de592b63..d6c0f9182d45 100644\n--- a/lib/gro/gro_tcp4.c\n+++ b/lib/gro/gro_tcp4.c\n@@ -223,8 +223,8 @@ update_header(struct gro_tcp_item *item)\n \tstruct rte_ipv4_hdr *ipv4_hdr;\n \tstruct rte_mbuf *pkt = item->firstseg;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t pkt->l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -\n \t\t\tpkt->l2_len);\n }\ndiff --git a/lib/gro/gro_tcp6.c b/lib/gro/gro_tcp6.c\nindex 5aa39801e132..6edfb6045cf6 100644\n--- a/lib/gro/gro_tcp6.c\n+++ b/lib/gro/gro_tcp6.c\n@@ -118,8 +118,8 @@ update_header(struct gro_tcp_item *item)\n \tstruct rte_ipv6_hdr *ipv6_hdr;\n \tstruct rte_mbuf *pkt = item->firstseg;\n \n-\tipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->l2_len);\n+\tipv6_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv6_hdr *,\n+\t\t\t\t\t pkt->l2_len);\n \tipv6_hdr->payload_len = rte_cpu_to_be_16(pkt->pkt_len -\n \t\t\tpkt->l2_len - pkt->l3_len);\n }\ndiff --git a/lib/gro/gro_udp4.c b/lib/gro/gro_udp4.c\nindex 42596d33b6dc..019e05bcdea5 100644\n--- a/lib/gro/gro_udp4.c\n+++ b/lib/gro/gro_udp4.c\n@@ -179,8 +179,8 @@ update_header(struct gro_udp4_item *item)\n \tstruct rte_mbuf *pkt = item->firstseg;\n \tuint16_t frag_offset;\n \n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t pkt->l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -\n \t\t\tpkt->l2_len);\n \ndiff --git a/lib/gro/gro_vxlan_tcp4.c b/lib/gro/gro_vxlan_tcp4.c\nindex 6ab700192261..2752650389a4 100644\n--- a/lib/gro/gro_vxlan_tcp4.c\n+++ b/lib/gro/gro_vxlan_tcp4.c\n@@ -263,8 +263,8 @@ update_vxlan_header(struct gro_vxlan_tcp4_item *item)\n \n \t/* Update the outer IPv4 header. */\n \tlen = pkt->pkt_len - pkt->outer_l2_len;\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->outer_l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t pkt->outer_l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(len);\n \n \t/* Update the outer UDP header. */\ndiff --git a/lib/gro/gro_vxlan_udp4.c b/lib/gro/gro_vxlan_udp4.c\nindex b78a7ae89eef..ca8cee270d3d 100644\n--- a/lib/gro/gro_vxlan_udp4.c\n+++ b/lib/gro/gro_vxlan_udp4.c\n@@ -259,8 +259,8 @@ update_vxlan_header(struct gro_vxlan_udp4_item *item)\n \n \t/* Update the outer IPv4 header. */\n \tlen = pkt->pkt_len - pkt->outer_l2_len;\n-\tipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +\n-\t\t\tpkt->outer_l2_len);\n+\tipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,\n+\t\t\t\t\t pkt->outer_l2_len);\n \tipv4_hdr->total_length = rte_cpu_to_be_16(len);\n \n \t/* Update the outer UDP header. */\n", "prefixes": [ "v5", "01/11" ] }