Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129396/?format=api
{ "id": 129396, "url": "http://patchwork.dpdk.org/api/patches/129396/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230708015718.75565-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230708015718.75565-11-stephen@networkplumber.org", "date": "2023-07-08T01:57:17", "name": "[v5,10/11] examples/ptpclient: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e768726953e54cacddcfe8369b519e9a41f8bdfd", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 28878, "url": "http://patchwork.dpdk.org/api/series/28878/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28878", "date": "2023-07-08T01:57:07", "name": "use rte_pktmbuf_mto_offset", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28878/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129396/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7F5442DFC;\n\tSat, 8 Jul 2023 03:58:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1BEE642D4F;\n\tSat, 8 Jul 2023 03:57:36 +0200 (CEST)", "from mail-oa1-f50.google.com (mail-oa1-f50.google.com\n [209.85.160.50]) by mails.dpdk.org (Postfix) with ESMTP id CBC5842D37\n for <dev@dpdk.org>; Sat, 8 Jul 2023 03:57:31 +0200 (CEST)", "by mail-oa1-f50.google.com with SMTP id\n 586e51a60fabf-1b059dd7c0cso2503488fac.0\n for <dev@dpdk.org>; Fri, 07 Jul 2023 18:57:31 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n 24-20020a17090a035800b00263f5ac814esm2260269pjf.38.2023.07.07.18.57.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 18:57:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688781451;\n x=1691373451;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kCWRDMcwmvFF9ALe0kl8MmyAQw2GA717TEvW0vvHaVg=;\n b=jXPFaR9tUzvzqlOh90TT2unIIS1BWbgC4whEpTzD574Zz+gPqiYxAM6S2Ymv91nulb\n lvSnHPqrBOKmBXZ2SZ1qPz18Q9Jpb2oU/YjhIe9Mj9vvdSOGRSlZZJLhmfME1Qudl8ZY\n FGeukxVo7SOMXc3jAcyuxBXcluJfepPT8uHOS5rFl/h0ZXX0iSTTilusKXt6F2FP3BL8\n yoRcVt3Ae6oSR9B0Pmi5d2E5fAXrRwU0hsTflXHWR7mjGQ6AIv5oWKn6LASm2OrV83Ne\n qWFyM0zi3H0uWVU83UJKNGqRMoH8TN7vde3zVY8L0IzuYu7cDMOgGFE4f0VHQVjWYVyX\n dXbQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688781451; x=1691373451;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=kCWRDMcwmvFF9ALe0kl8MmyAQw2GA717TEvW0vvHaVg=;\n b=fnzva9NTfmMUiPeg+3NNv0edWrXwZF3K9aIh+j6nn5LxAOdG8zmt7OPSVfFVj/naMG\n xaxa+x0jfO4IeWSkhA2w/+MM7XdTjNn1keXC22paCQGaCyV9B7vo3VJPksyw1dqcoCPH\n D3PnYsbLfTX/ZkhEufYd9/hf+myCt/kxGQhVmxC92bV54NxgKpA8zLo3D/oc/mtIt2Zj\n MjOTenPzTDNHczZVnFfDZ0R6BYhO1LapgQUmTFnVgtxMts9c/IqoUfKvhPSiY0Yswx88\n y9dCh9LTs5T2sXLznbDqTgMrZfUiOepKisFzvek1IAoTMTb7iVZKz2SyCeWvyxqHrfQH\n u4NA==", "X-Gm-Message-State": "ABy/qLbU3hp1yTqX8R6KaLz5HYIFhOoc8xZdU9Z9VHZbXezpGVJBLH8g\n C8Oe8GqXf9cczaQGrMuvRQ3Zjw5xrj+RkEeqF6wKmCau", "X-Google-Smtp-Source": "\n APBJJlGlmL7V4pqzb7XKqcGxOjshGY4o91UpS3P+qHV/sZvlR4DvJG/aSoh/RKGWa05g3Qc6FC0SEw==", "X-Received": "by 2002:a05:6870:1702:b0:1b3:ce91:ba64 with SMTP id\n h2-20020a056870170200b001b3ce91ba64mr8533445oae.59.1688781450982;\n Fri, 07 Jul 2023 18:57:30 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Kirill Rybalchenko <kirill.rybalchenko@intel.com>", "Subject": "[PATCH v5 10/11] examples/ptpclient: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 18:57:17 -0700", "Message-Id": "<20230708015718.75565-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230708015718.75565-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230708015718.75565-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/ptpclient/ptpclient.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex cdf2da64dfee..2535d848a1e9 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -354,8 +354,8 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)\n {\n \tstruct ptp_header *ptp_hdr;\n \n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(ptp_data->m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(ptp_data->m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tptp_data->seqID_SYNC = rte_be_to_cpu_16(ptp_hdr->seq_id);\n \n \tif (ptp_data->ptpset == 0) {\n@@ -397,15 +397,15 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \tint ret;\n \n \teth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);\n-\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t+ sizeof(struct rte_ether_hdr));\n+\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tif (memcmp(&ptp_data->master_clock_id,\n \t\t\t&ptp_hdr->source_port_id.clock_id,\n \t\t\tsizeof(struct clock_id)) != 0)\n \t\treturn;\n \n \tptp_data->seqID_FOLLOWUP = rte_be_to_cpu_16(ptp_hdr->seq_id);\n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n \t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \torigin_tstamp = &ptp_msg->follow_up.precise_origin_tstamp;\n@@ -537,8 +537,8 @@ parse_drsp(struct ptpv2_data_slave_ordinary *ptp_data)\n \tstruct tstamp *rx_tstamp;\n \tuint16_t seq_id;\n \n-\tptp_msg = (struct ptp_message *) (rte_pktmbuf_mtod(m, char *) +\n-\t\t\t\t\tsizeof(struct rte_ether_hdr));\n+\tptp_msg = rte_pktmbuf_mtod_offset(m, struct ptp_message *,\n+\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \tseq_id = rte_be_to_cpu_16(ptp_msg->delay_resp.hdr.seq_id);\n \tif (memcmp(&ptp_data->client_clock_id,\n \t\t &ptp_msg->delay_resp.req_port_id.clock_id,\n@@ -585,8 +585,8 @@ parse_ptp_frames(uint16_t portid, struct rte_mbuf *m) {\n \tif (eth_type == PTP_PROTOCOL) {\n \t\tptp_data.m = m;\n \t\tptp_data.portid = portid;\n-\t\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n-\t\t\t\t\t+ sizeof(struct rte_ether_hdr));\n+\t\tptp_hdr = rte_pktmbuf_mtod_offset(m, struct ptp_header *,\n+\t\t\t\t\t\t sizeof(struct rte_ether_hdr));\n \n \t\tswitch (ptp_hdr->msg_type) {\n \t\tcase SYNC:\n", "prefixes": [ "v5", "10/11" ] }