Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129397/?format=api
{ "id": 129397, "url": "http://patchwork.dpdk.org/api/patches/129397/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230708015718.75565-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230708015718.75565-12-stephen@networkplumber.org", "date": "2023-07-08T01:57:18", "name": "[v5,11/11] examples/l2fwd-crypto: use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f87da9ba728e6d334db20a6a3dbf143fcf464d7c", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230708015718.75565-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 28878, "url": "http://patchwork.dpdk.org/api/series/28878/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28878", "date": "2023-07-08T01:57:07", "name": "use rte_pktmbuf_mto_offset", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28878/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129397/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3FE1042DFC;\n\tSat, 8 Jul 2023 03:58:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3C8A342D50;\n\tSat, 8 Jul 2023 03:57:37 +0200 (CEST)", "from mail-oo1-f46.google.com (mail-oo1-f46.google.com\n [209.85.161.46]) by mails.dpdk.org (Postfix) with ESMTP id B30EF42D39\n for <dev@dpdk.org>; Sat, 8 Jul 2023 03:57:32 +0200 (CEST)", "by mail-oo1-f46.google.com with SMTP id\n 006d021491bc7-5634db21a78so1921329eaf.0\n for <dev@dpdk.org>; Fri, 07 Jul 2023 18:57:32 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n 24-20020a17090a035800b00263f5ac814esm2260269pjf.38.2023.07.07.18.57.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 Jul 2023 18:57:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688781452;\n x=1691373452;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=39Ya5+TNd9mvRLympPVI5q7OCnpOPGc//DlPeojc5cI=;\n b=XbRXcw4W40Jp3HwvZOZMJP1MEMEslmf75XeaAkGZQAGU7eVLa7p6YRgnW9WDE7QEXR\n VQfSmG4kxIg82u02I9ddIZ6aqTyDlfTxuM9AzJf4I8g/sIv058wAgmoRV/xIQZd6nfUg\n /u7kD+qOcOw2OGxbUL1Zpsrkuu1cArRXQ2Xx8vivbWCacDik8ALmGX3LXNAm5/rXImvc\n 8WNfiKHW6JADR/o1qqBdtFauNo7EkIJGl3wK3rB8QpW+z7r0xJRFznc42v+WTo/+JXjO\n gPhz/LcdCDdxM0B6+D+7wVINvgYQemZ6AC6CnjOJqqnmmNtQ/EzZtjN3tUSIPJpynElC\n h8+A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688781452; x=1691373452;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=39Ya5+TNd9mvRLympPVI5q7OCnpOPGc//DlPeojc5cI=;\n b=IuZvdKvxITkssl+NkvhNBo2WWRH6g7J2yB1716yqyxePjRKAbiPs/v7Ws6mmYyShnM\n S/mLbbSHUTSBF60YqdbKJ6rrtxHbUbn3hJK2iQJdRQJADpfL89UCwj9pB2ZcRCqH3c2D\n fIHATw1bqTXR0f4eHHxapPbqGQBM4+KKmArz0DidudHqVZ6fcjUTPHgjGEfMKOiUhksg\n I2/AkTO9+Vpa4vDrDmq94XA17WTUy3Pg9FiMz630PqmGPA+vXb3E0esrR/bu8qr3ekD5\n 1VjCCN1vUJb35m/q9u9EnmJLl6p6L0PvuEKO9F65tQ7g28/P3dcHIQshcUqOks6FZfNk\n Oygg==", "X-Gm-Message-State": "ABy/qLYTJPTpI5qj3PM48cB+iqWAqa8dEMuMnOtBSDdu3yb/onCl4Nk8\n pim3qSZCoQMpVWa1Z5Qc8xFIuUb7GNdDph22w91Fukxr", "X-Google-Smtp-Source": "\n APBJJlExrVBsHGVobFkMNWbughIoC0j+bO8DeSxJ+2t1Gkqo2YPSPR3En8MzSzqdqIRkp7moKlnm6Q==", "X-Received": "by 2002:a05:6870:c18d:b0:1b3:f370:79c7 with SMTP id\n h13-20020a056870c18d00b001b3f37079c7mr8467000oad.37.1688781451797;\n Fri, 07 Jul 2023 18:57:31 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH v5 11/11] examples/l2fwd-crypto: use rte_pktmbuf_mtod_offset", "Date": "Fri, 7 Jul 2023 18:57:18 -0700", "Message-Id": "<20230708015718.75565-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230708015718.75565-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230708015718.75565-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace explicit packet offset computations with rte_pktmbuf_mtod_offset().\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/l2fwd-crypto/main.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex efe7eea2a768..19db0a280bf0 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -410,8 +410,8 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \n \tipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n-\t\t\tipdata_offset);\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n+\t\t\t\t\t ipdata_offset);\n \n \tipdata_offset += (ip_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK)\n \t\t\t* RTE_IPV4_IHL_MULTIPLIER;\n@@ -479,8 +479,8 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->auth.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->auth.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\tuint8_t *, ipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->auth.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -540,8 +540,8 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,\n \t\t\top->sym->aead.digest.data = (uint8_t *)rte_pktmbuf_append(m,\n \t\t\t\tcparams->digest_length);\n \t\t} else {\n-\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod(m,\n-\t\t\t\tuint8_t *) + ipdata_offset + data_len;\n+\t\t\top->sym->aead.digest.data = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\tuint8_t *, ipdata_offset + data_len);\n \t\t}\n \n \t\top->sym->aead.digest.phys_addr = rte_pktmbuf_iova_offset(m,\n@@ -631,7 +631,7 @@ l2fwd_simple_forward(struct rte_mbuf *m, uint16_t portid,\n \tstruct rte_ipv4_hdr *ip_hdr;\n \tuint32_t ipdata_offset = sizeof(struct rte_ether_hdr);\n \n-\tip_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(m, char *) +\n+\tip_hdr = rte_pktmbuf_mtod_offset(m, struct rte_ipv4_hdr *,\n \t\t\t\t\t ipdata_offset);\n \tdst_port = l2fwd_dst_ports[portid];\n \n", "prefixes": [ "v5", "11/11" ] }