Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129415/?format=api
{ "id": 129415, "url": "http://patchwork.dpdk.org/api/patches/129415/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230710071515.3143533-2-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230710071515.3143533-2-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230710071515.3143533-2-zhirun.yan@intel.com", "date": "2023-07-10T07:15:14", "name": "[v4,1/2] graph: fix graph functional tests with valid params", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "82e7a44b0eaee82e66ac3f504e575a0b2f59291f", "submitter": { "id": 1154, "url": "http://patchwork.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230710071515.3143533-2-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28883, "url": "http://patchwork.dpdk.org/api/series/28883/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28883", "date": "2023-07-10T07:15:13", "name": "fix graph issues", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28883/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129415/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129415/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 823AA42E38;\n\tMon, 10 Jul 2023 09:39:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6B97242B8C;\n\tMon, 10 Jul 2023 09:38:59 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 0DF13410EF\n for <dev@dpdk.org>; Mon, 10 Jul 2023 09:38:56 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jul 2023 00:38:56 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.138])\n by fmsmga004.fm.intel.com with ESMTP; 10 Jul 2023 00:38:54 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688974737; x=1720510737;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=xPY8RGKYv86qAitURVOywKitJbOasU1FZLbKVGwUjec=;\n b=V29q2v8aOXEV4cjWDkvpzW8Il9ck2PNHnhsjge+b1iCcz/zGOUxpgbvv\n s+/WN86vMNmoKy68/XEMWI/kWPhAAv1gtVsklAfcSRmI05gg1ONL57mpM\n Wkh0VJD1ktTOjsgJZbbya9jSQSGxtE9LG0FaPoDVdl37D3FI3YjVrEVNR\n +Rl0af5dunFXeTW29IU+ulnronCQyBlkfSYcHClx3XmiBvVf3SDjbGD/l\n V2zElrgXcELl2YFUkqhCkHK74ObRU3cHHAl69UGXP+zo5wtu2HJzGBYur\n rOdz3HAiUfzUFZsWWUevglOEL4BGpq9IHQQxfdeePscaoNUZS18sxFhYT g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10766\"; a=\"364314491\"", "E=Sophos;i=\"6.01,194,1684825200\"; d=\"scan'208\";a=\"364314491\"", "E=McAfee;i=\"6600,9927,10766\"; a=\"790696503\"", "E=Sophos;i=\"6.01,194,1684825200\"; d=\"scan'208\";a=\"790696503\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com", "Cc": "qi.fu@intel.com,\n\tZhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v4 1/2] graph: fix graph functional tests with valid params", "Date": "Mon, 10 Jul 2023 15:15:14 +0800", "Message-Id": "<20230710071515.3143533-2-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230710071515.3143533-1-zhirun.yan@intel.com>", "References": "<20230705015633.1465235-1-zhirun.yan@intel.com>\n <20230710071515.3143533-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "rte_graph_clone() should use valid param rather than NULL pointer, cause it\nneeds the param for alloc work queue memory for mcore dispatch model in\ngraph_sched_wq_create().\n\nFixes: 67e2303cd823 (\"test/graph: add functional tests for mcore dispatch model\")\n\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n app/test/test_graph.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_graph.c b/app/test/test_graph.c\nindex 8609c0b3a4..47f5ab8395 100644\n--- a/app/test/test_graph.c\n+++ b/app/test/test_graph.c\n@@ -665,7 +665,7 @@ test_graph_clone(void)\n {\n \trte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;\n \trte_graph_t main_graph_id = RTE_GRAPH_ID_INVALID;\n-\tstruct rte_graph_param graph_conf;\n+\tstruct rte_graph_param graph_conf = {0};\n \tint ret = 0;\n \n \tmain_graph_id = rte_graph_from_name(\"worker0\");\n@@ -700,6 +700,7 @@ test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)\n {\n \trte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;\n \tunsigned int worker_lcore = RTE_MAX_LCORE;\n+\tstruct rte_graph_param graph_conf = {0};\n \trte_node_t nid = RTE_NODE_ID_INVALID;\n \tchar node_name[64] = \"test_node00\";\n \tstruct rte_node *node;\n@@ -711,7 +712,7 @@ test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)\n \t\tprintf(\"Set node %s affinity to lcore %u\\n\", node_name, worker_lcore);\n \n \tnid = rte_node_from_name(node_name);\n-\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test1\", NULL);\n+\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test1\", &graph_conf);\n \tnode = rte_graph_node_get(cloned_graph_id, nid);\n \n \tif (node->dispatch.lcore_id != worker_lcore) {\n@@ -729,11 +730,12 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)\n {\n \trte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;\n \tunsigned int worker_lcore = RTE_MAX_LCORE;\n+\tstruct rte_graph_param graph_conf = {0};\n \tstruct rte_graph *graph;\n \tint ret = 0;\n \n \tworker_lcore = rte_get_next_lcore(worker_lcore, true, 1);\n-\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test2\", NULL);\n+\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test2\", &graph_conf);\n \n \tret = rte_graph_model_mcore_dispatch_core_bind(cloned_graph_id, worker_lcore);\n \tif (ret != 0) {\n@@ -765,10 +767,11 @@ static int\n test_graph_worker_model_set_get(void)\n {\n \trte_graph_t cloned_graph_id = RTE_GRAPH_ID_INVALID;\n+\tstruct rte_graph_param graph_conf = {0};\n \tstruct rte_graph *graph;\n \tint ret = 0;\n \n-\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test3\", NULL);\n+\tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test3\", &graph_conf);\n \tret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);\n \tif (ret != 0) {\n \t\tprintf(\"Set graph mcore dispatch model failed\\n\");\n", "prefixes": [ "v4", "1/2" ] }