Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129416/?format=api
{ "id": 129416, "url": "http://patchwork.dpdk.org/api/patches/129416/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230710071515.3143533-3-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230710071515.3143533-3-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230710071515.3143533-3-zhirun.yan@intel.com", "date": "2023-07-10T07:15:15", "name": "[v4,2/2] graph: fix graph model check in core binding", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "414c09b6f6c8d7e1f267ae1eada4616eb0519f68", "submitter": { "id": 1154, "url": "http://patchwork.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230710071515.3143533-3-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28883, "url": "http://patchwork.dpdk.org/api/series/28883/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28883", "date": "2023-07-10T07:15:13", "name": "fix graph issues", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28883/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129416/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D252642E38;\n\tMon, 10 Jul 2023 09:39:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9170642BAC;\n\tMon, 10 Jul 2023 09:39:01 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id E52A2410F1\n for <dev@dpdk.org>; Mon, 10 Jul 2023 09:38:58 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Jul 2023 00:38:58 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.138])\n by fmsmga004.fm.intel.com with ESMTP; 10 Jul 2023 00:38:56 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688974739; x=1720510739;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=FLewvDoxl1jYohzb29SyCYpA4HAurNNPNmrEo9wB9Ik=;\n b=BoIKOunioVIy0hvYys9NwkhIVZ/QaGGpGbg9/uqneQmQL6ZOf39L93nO\n K5p7MU/gqAaV1tJjYB2Xk0dDzNeRh+SvIXozN+xTigXflTqilVQEaf7lh\n I3pc92jy7NgBTKQZ8rtZd5YTtYxfuCC2NPJi8z7eyHtCa8E4K+CttTmcf\n NXAtpxc3TdMXSBDLk3gu+kTiSjBi26YgXTIQ20ng13PPpBCGCIxqSxzU5\n FNp2imMqlF2+BanQoomnDDTCm2/ZT6F/WMZRjZLV3VoMU9ni6W/UEzo+I\n DpzMeN3Mdb8r18XZ27M+QMcn8FvGaw+OdSOCGWLVJdrqlM2nAlgZgZMbw g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10766\"; a=\"364314497\"", "E=Sophos;i=\"6.01,194,1684825200\"; d=\"scan'208\";a=\"364314497\"", "E=McAfee;i=\"6600,9927,10766\"; a=\"790696509\"", "E=Sophos;i=\"6.01,194,1684825200\"; d=\"scan'208\";a=\"790696509\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com", "Cc": "qi.fu@intel.com,\n\tZhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v4 2/2] graph: fix graph model check in core binding", "Date": "Mon, 10 Jul 2023 15:15:15 +0800", "Message-Id": "<20230710071515.3143533-3-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230710071515.3143533-1-zhirun.yan@intel.com>", "References": "<20230705015633.1465235-1-zhirun.yan@intel.com>\n <20230710071515.3143533-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This function is used for mcore dispatch model only, correct the check to\nmake sure it is the expected model. And specific the model by\nrte_graph_worker_model_set() before call it in test. Update release notes\nfor new mcore dispatch model.\n\nFixes: ecb22a294980 (\"graph: introduce graph bind unbind API\")\n\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n app/test/test_graph.c | 6 ++++++\n doc/guides/rel_notes/release_23_07.rst | 10 ++++++++++\n lib/graph/graph.c | 2 +-\n 3 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_graph.c b/app/test/test_graph.c\nindex 47f5ab8395..af90ac07ec 100644\n--- a/app/test/test_graph.c\n+++ b/app/test/test_graph.c\n@@ -737,6 +737,12 @@ test_graph_model_mcore_dispatch_core_bind_unbind(void)\n \tworker_lcore = rte_get_next_lcore(worker_lcore, true, 1);\n \tcloned_graph_id = rte_graph_clone(graph_id, \"cloned-test2\", &graph_conf);\n \n+\tret = rte_graph_worker_model_set(RTE_GRAPH_MODEL_MCORE_DISPATCH);\n+\tif (ret != 0) {\n+\t\tprintf(\"Set graph mcore dispatch model failed\\n\");\n+\t\tret = -1;\n+\t}\n+\n \tret = rte_graph_model_mcore_dispatch_core_bind(cloned_graph_id, worker_lcore);\n \tif (ret != 0) {\n \t\tprintf(\"bind graph %d to lcore %u failed\\n\", graph_id, worker_lcore);\ndiff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex dcfd692425..7f1c2e66d5 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -185,6 +185,12 @@ New Features\n \n * Added SM2 algorithm support in asymmetric crypto operations.\n \n+* **Added mcore dispatch model in rte_graph library.**\n+\n+ * Added set, get and validate model APIs to enhance graph framework\n+ to chose different walk models.\n+ * Added mcore dispatch model to support cross-core dispatching mechanism.\n+\n * **Added PDCP Library.**\n \n Added an experimental library to provide PDCP UL and DL processing of packets.\n@@ -206,6 +212,10 @@ New Features\n \n See the :doc:`../tools/dmaperf` for more details.\n \n+* **Update l3fwd-graph sample application.**\n+\n+ Added a new cmdline option ``--model`` which can be used to chose\n+ RTC or mcore dispatch model.\n \n Removed Items\n -------------\ndiff --git a/lib/graph/graph.c b/lib/graph/graph.c\nindex 0c28d925bc..26f0968a97 100644\n--- a/lib/graph/graph.c\n+++ b/lib/graph/graph.c\n@@ -287,7 +287,7 @@ rte_graph_model_mcore_dispatch_core_bind(rte_graph_t id, int lcore)\n \t\tif (graph->id == id)\n \t\t\tbreak;\n \n-\tif (graph->graph->model == RTE_GRAPH_MODEL_MCORE_DISPATCH)\n+\tif (graph->graph->model != RTE_GRAPH_MODEL_MCORE_DISPATCH)\n \t\tgoto fail;\n \n \tgraph->lcore_id = lcore;\n", "prefixes": [ "v4", "2/2" ] }