Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129437/?format=api
{ "id": 129437, "url": "http://patchwork.dpdk.org/api/patches/129437/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230711055147.872889-1-abhijit.gangurde@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230711055147.872889-1-abhijit.gangurde@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230711055147.872889-1-abhijit.gangurde@amd.com", "date": "2023-07-11T05:51:47", "name": "[v3] bus/cdx: provide driver flag for optional resource mapping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "101cd1607f4d5ee3d58d20e6935cb8ccd5df0b97", "submitter": { "id": 3110, "url": "http://patchwork.dpdk.org/api/people/3110/?format=api", "name": "Abhijit Gangurde", "email": "abhijit.gangurde@amd.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230711055147.872889-1-abhijit.gangurde@amd.com/mbox/", "series": [ { "id": 28897, "url": "http://patchwork.dpdk.org/api/series/28897/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28897", "date": "2023-07-11T05:51:47", "name": "[v3] bus/cdx: provide driver flag for optional resource mapping", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28897/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129437/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38D9E42E40;\n\tTue, 11 Jul 2023 07:52:37 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B7E2340A7D;\n\tTue, 11 Jul 2023 07:52:36 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2067.outbound.protection.outlook.com [40.107.223.67])\n by mails.dpdk.org (Postfix) with ESMTP id EC8FE4003C\n for <dev@dpdk.org>; Tue, 11 Jul 2023 07:52:34 +0200 (CEST)", "from DS7PR05CA0019.namprd05.prod.outlook.com (2603:10b6:5:3b9::24)\n by DS7PR12MB6046.namprd12.prod.outlook.com (2603:10b6:8:85::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Tue, 11 Jul\n 2023 05:52:32 +0000", "from DM6NAM11FT107.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:3b9:cafe::28) by DS7PR05CA0019.outlook.office365.com\n (2603:10b6:5:3b9::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20 via Frontend\n Transport; Tue, 11 Jul 2023 05:52:32 +0000", "from SATLEXMB03.amd.com (165.204.84.17) by\n DM6NAM11FT107.mail.protection.outlook.com (10.13.172.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6588.20 via Frontend Transport; Tue, 11 Jul 2023 05:52:32 +0000", "from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Jul\n 2023 00:52:31 -0500", "from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.23 via\n Frontend Transport; Tue, 11 Jul 2023 00:52:29 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dwXyVDhlK0dfKNxdzCYDF/WZ6bM1WdSCvg7puFSBPWz918EvQKWEGFk+aJJU1O4CEihCgGrIykK0HErZ5fyZf6h5yfwlDmE04Fcec6B0AiKCHhUmpcu08rDDg7DS/BNqxaAOv10ZH5xkqbZxGD42dNkRFCgq6yLi44oVLz3tYCMc1UEnMLcqw6F5t5MtgP9nqcwES6r0A40Z0k4z6SM3nga3tzScSso263OdMNRlZOedHIfX0HiKIpsb5MxQzk7bMvR2mV1fR5E31AxQuf6YSE4T2IHp6RyRuiLBTRVrU2A1zpaLV7hw9NRVRUtn34WHoygVpud9ebqTMkHv+Dwpng==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=wYEu4trf+dpuB2nj7J/Q3z2LQ2EgrIUUAZY6Bp9Fss0=;\n b=ML15RfQTo/PiyXnTdIjah+VY+v6owRgnxt6OL5jPYydwHB0vrS/0gllRxYGQIIPumM/b0DYEyjKPKUponjOYbhOQqOz6ZEU7uMiJqxrm5ezXBXlT72v4C4FGJrpx7QBOcr2s3EKFp/IRa6xoK5FcVCWqfWnlarJP7CBc2+nKaGn3sI/QHFtIEbsjL492UUOjjOh743R6ACR2uC1Av5iYvmAUaAexNON++NiHRDpOhOpee7CZb5gLGBw74e5v601IEw6PpDA4M0Xrt6wXa+0i3MyOSgL9gPIiNBfDxFdmNW8moea0/lWJzk/tAVOx9Rqz40+PEuhhHQ/jIwYGa7JJVA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=wYEu4trf+dpuB2nj7J/Q3z2LQ2EgrIUUAZY6Bp9Fss0=;\n b=VxcNgss5Np3zOem1FxNYx5LKrDi0/OMB4W3/nU6+hdkx7X2kbZ07QbWXTGUqwRe5VI65ew3kkGW0WffPCyJlk23UZ6RxR363BpKdbpqC1VEhbcKrfuKgyqricPRMk4WFn1gAFSgffQAA+grcEAoQrslJYWYNmha6SVFdp5vcm4A=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C", "From": "Abhijit Gangurde <abhijit.gangurde@amd.com>", "To": "<Nipun.Gupta@amd.com>, <nikhil.agarwal@amd.com>", "CC": "<dev@dpdk.org>, <david.marchand@redhat.com>, <Ferruh.Yigit@amd.com>,\n <thomas@monjalon.net>, Abhijit Gangurde <abhijit.gangurde@amd.com>", "Subject": "[PATCH v3] bus/cdx: provide driver flag for optional resource mapping", "Date": "Tue, 11 Jul 2023 11:21:47 +0530", "Message-ID": "<20230711055147.872889-1-abhijit.gangurde@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230705065235.4767-1-abhijit.gangurde@amd.com>", "References": "<20230705065235.4767-1-abhijit.gangurde@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT107:EE_|DS7PR12MB6046:EE_", "X-MS-Office365-Filtering-Correlation-Id": "1f9fa873-b6a0-4786-1b67-08db81d30526", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +edG8lfQPsAzeIiuL/GaBm8SPGB4vMkRmOJrBHBq/I4rO5sXoGmWkzj8j/2dciQHb7ITKgLazA1/ujaTXCxG4XAf+gWtYGNFQkPGr1+m7FmrsadlEazL2GDcJaGMu4LTZGKxt6fkqvykeflXm35mFrvMvTOQ6Wq71XyYzAxuaO6guIGgxUsjcVTRpJCGcgulp/Q6sTc9WXquS/h9ZJXxX+m6xM1gHkPXTmcU7jQK3xD9cVgih7l1Xe9i+YszpB8nBYKYCpNMbTdIdaKTGePgM5Dhk4nLqGsXeoMTaX0Xgub1RkNsRs1UHjuyzae69viooAsR2B6ZQXPVjflLUwBH4e9r/NShtI6+jsisBw1jIUqNTHK3dI4V62V4+T2TxVXS/oKD/8sS2luP4jpkjIFkPt0a+6oXOO1+ki+U79GqY/jn4MNfO2uXXSOgVye4T8d897y4+5huwU7WLsAWH463fuTgt43KF8jo+UmJgWtWxA3f3lJklSiLlYeF6Y1LR/aOohNDPQRnVORGL8m9sbhwcovb69cV9DL2Q+KgfZwULrAAYwyBEf2T5Y6jL9HE6LBrREXowskbEfOKeBKQQXqOHvpL/vppqz38Y6a15FBGkPKnpFWWuFBLhaxFL2xETgyYFaVSsEc8faSSC5+ZOdXp4m73hDwQjmedQiU/yQXDuecwIYlArnfAXDBkPr3R+ffa4IoFsRimoDcNoaKqiRt6t1NZQol50GvnkMp1uU5I2/sdgR1k2JXeCwON5qfOjr379rFZOuVsXQcuCiauqOJD0g==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(478600001)(6666004)(110136005)(54906003)(36860700001)(47076005)(2616005)(426003)(83380400001)(36756003)(86362001)(40460700003)(40480700001)(2906002)(70206006)(82310400005)(70586007)(1076003)(26005)(186003)(336012)(81166007)(82740400003)(356005)(8936002)(6636002)(316002)(41300700001)(5660300002)(44832011)(8676002)(4326008)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Jul 2023 05:52:32.6741 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1f9fa873-b6a0-4786-1b67-08db81d30526", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB03.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT107.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS7PR12MB6046", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Provide driver flag which gives an option to map the cdx\ndevice resource before probing the device driver.\nAlso, make rte_cdx_map_device() API as public to map\ndevice resource separately.\n\nSigned-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>\n---\n v3:\n - Changed APIs to __rte_experimental.\n\n v2:\n - Corrected _RTE_BUS_CDX_H_ to RTE_BUS_CDX_H\n - Improved code comments.\n\n drivers/bus/cdx/bus_cdx_driver.h | 26 ++--------------\n drivers/bus/cdx/cdx.c | 11 ++++---\n drivers/bus/cdx/rte_bus_cdx.h | 52 ++++++++++++++++++++++++++++++++\n drivers/bus/cdx/version.map | 11 +++++--\n 4 files changed, 71 insertions(+), 29 deletions(-)\n create mode 100644 drivers/bus/cdx/rte_bus_cdx.h", "diff": "diff --git a/drivers/bus/cdx/bus_cdx_driver.h b/drivers/bus/cdx/bus_cdx_driver.h\nindex fcacdb5896..1571131417 100644\n--- a/drivers/bus/cdx/bus_cdx_driver.h\n+++ b/drivers/bus/cdx/bus_cdx_driver.h\n@@ -37,6 +37,9 @@ struct rte_cdx_bus;\n static const char DRV_EXP_TAG(name, cdx_tbl_export)[] __rte_used = \\\n RTE_STR(table)\n \n+/** Device needs resource mapping */\n+#define RTE_CDX_DRV_NEED_MAPPING 0x0001\n+\n /**\n * A structure describing an ID for a CDX driver. Each driver provides a\n * table of these IDs for each device that it supports.\n@@ -107,29 +110,6 @@ struct rte_cdx_driver {\n \tuint32_t drv_flags;\t\t\t/**< Flags RTE_CDX_DRV_*. */\n };\n \n-/**\n- * Map the CDX device resources in user space virtual memory address.\n- *\n- * @param dev\n- * A pointer to a rte_cdx_device structure describing the device\n- * to use.\n- *\n- * @return\n- * 0 on success, <0 on error.\n- */\n-__rte_internal\n-int rte_cdx_map_device(struct rte_cdx_device *dev);\n-\n-/**\n- * Unmap this device.\n- *\n- * @param dev\n- * A pointer to a rte_cdx_device structure describing the device\n- * to use.\n- */\n-__rte_internal\n-void rte_cdx_unmap_device(struct rte_cdx_device *dev);\n-\n /**\n * Register a CDX driver.\n *\ndiff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c\nindex f9526e08cc..fc8d3b668b 100644\n--- a/drivers/bus/cdx/cdx.c\n+++ b/drivers/bus/cdx/cdx.c\n@@ -74,6 +74,7 @@\n #include <rte_kvargs.h>\n #include <rte_malloc.h>\n #include <rte_vfio.h>\n+#include <rte_bus_cdx.h>\n \n #include <eal_filesystem.h>\n \n@@ -383,10 +384,12 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr,\n \tCDX_BUS_DEBUG(\" probe device %s using driver: %s\", dev_name,\n \t\tdr->driver.name);\n \n-\tret = cdx_vfio_map_resource(dev);\n-\tif (ret != 0) {\n-\t\tCDX_BUS_ERR(\"CDX map device failed: %d\", ret);\n-\t\tgoto error_map_device;\n+\tif (dr->drv_flags & RTE_CDX_DRV_NEED_MAPPING) {\n+\t\tret = cdx_vfio_map_resource(dev);\n+\t\tif (ret != 0) {\n+\t\t\tCDX_BUS_ERR(\"CDX map device failed: %d\", ret);\n+\t\t\tgoto error_map_device;\n+\t\t}\n \t}\n \n \t/* call the driver probe() function */\ndiff --git a/drivers/bus/cdx/rte_bus_cdx.h b/drivers/bus/cdx/rte_bus_cdx.h\nnew file mode 100644\nindex 0000000000..4ca12f90c4\n--- /dev/null\n+++ b/drivers/bus/cdx/rte_bus_cdx.h\n@@ -0,0 +1,52 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) 2023, Advanced Micro Devices, Inc.\n+ */\n+\n+#ifndef RTE_BUS_CDX_H\n+#define RTE_BUS_CDX_H\n+\n+/**\n+ * @file\n+ * CDX device & driver interface\n+ */\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/* Forward declarations */\n+struct rte_cdx_device;\n+\n+/**\n+ * Map the CDX device resources in user space virtual memory address.\n+ *\n+ * Note that driver should not call this function when flag\n+ * RTE_CDX_DRV_NEED_MAPPING is set, as EAL will do that for\n+ * you when it's on.\n+ *\n+ * @param dev\n+ * A pointer to a rte_cdx_device structure describing the device\n+ * to use.\n+ *\n+ * @return\n+ * 0 on success, negative on error and positive if no driver\n+ * is found for the device.\n+ */\n+__rte_experimental\n+int rte_cdx_map_device(struct rte_cdx_device *dev);\n+\n+/**\n+ * Unmap this device.\n+ *\n+ * @param dev\n+ * A pointer to a rte_cdx_device structure describing the device\n+ * to use.\n+ */\n+__rte_experimental\n+void rte_cdx_unmap_device(struct rte_cdx_device *dev);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* RTE_BUS_CDX_H */\ndiff --git a/drivers/bus/cdx/version.map b/drivers/bus/cdx/version.map\nindex 0a15d39ae8..4ce444572b 100644\n--- a/drivers/bus/cdx/version.map\n+++ b/drivers/bus/cdx/version.map\n@@ -1,9 +1,16 @@\n-INTERNAL {\n+EXPERIMENTAL {\n \tglobal:\n \n \trte_cdx_map_device;\n-\trte_cdx_register;\n \trte_cdx_unmap_device;\n+\n+\tlocal: *;\n+};\n+\n+INTERNAL {\n+\tglobal:\n+\n+\trte_cdx_register;\n \trte_cdx_unregister;\n \trte_cdx_vfio_intr_disable;\n \trte_cdx_vfio_intr_enable;\n", "prefixes": [ "v3" ] }