Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129443/?format=api
{ "id": 129443, "url": "http://patchwork.dpdk.org/api/patches/129443/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230711102448.11627-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230711102448.11627-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230711102448.11627-4-liudongdong3@huawei.com", "date": "2023-07-11T10:24:46", "name": "[3/5] net/hns3: optimize free mbuf code for SVE Tx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ff00e8a7cd3f1d6794659f13b0241938dfff8d3f", "submitter": { "id": 2718, "url": "http://patchwork.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230711102448.11627-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 28901, "url": "http://patchwork.dpdk.org/api/series/28901/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28901", "date": "2023-07-11T10:24:43", "name": "net/hns3: some performance optimizations", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28901/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129443/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4EF7F42E44;\n\tTue, 11 Jul 2023 12:28:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CE79942D1D;\n\tTue, 11 Jul 2023 12:27:59 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id BD386410DC;\n Tue, 11 Jul 2023 12:27:55 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R0cS54NX2zMqVJ;\n Tue, 11 Jul 2023 18:24:37 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.27; Tue, 11 Jul 2023 18:27:53 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>", "Subject": "[PATCH 3/5] net/hns3: optimize free mbuf code for SVE Tx", "Date": "Tue, 11 Jul 2023 18:24:46 +0800", "Message-ID": "<20230711102448.11627-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230711102448.11627-1-liudongdong3@huawei.com>", "References": "<20230711102448.11627-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, hns3 SVE Tx checks the valid bits of all descriptors\nin a batch and then determines whether to release the corresponding\nmbufs. Actually, once the valid bit of any descriptor in a batch\nisn't cleared, driver does not need to scan the rest of descriptors.\n\nIf we optimize SVE codes algorithm about this function, the performance\nof a single queue for 64B packet is improved by ~2% on txonly forwarding\nmode. And if use C code to scan all descriptors, the performance is\nimproved by ~8%.\n\nSo this patch selects C code to optimize this code to improve the SVE\nTx performance.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx_vec_sve.c | 42 +---------------------------\n 1 file changed, 1 insertion(+), 41 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c\nindex 8bfc3de049..5011544e07 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c\n@@ -337,46 +337,6 @@ hns3_recv_pkts_vec_sve(void *__restrict rx_queue,\n \treturn nb_rx;\n }\n \n-static inline void\n-hns3_tx_free_buffers_sve(struct hns3_tx_queue *txq)\n-{\n-#define HNS3_SVE_CHECK_DESCS_PER_LOOP\t8\n-#define TX_VLD_U8_ZIP_INDEX\t\tsvindex_u8(0, 4)\n-\tsvbool_t pg32 = svwhilelt_b32(0, HNS3_SVE_CHECK_DESCS_PER_LOOP);\n-\tsvuint32_t vld, vld2;\n-\tsvuint8_t vld_u8;\n-\tuint64_t vld_all;\n-\tstruct hns3_desc *tx_desc;\n-\tint i;\n-\n-\t/*\n-\t * All mbufs can be released only when the VLD bits of all\n-\t * descriptors in a batch are cleared.\n-\t */\n-\t/* do logical OR operation for all desc's valid field */\n-\tvld = svdup_n_u32(0);\n-\ttx_desc = &txq->tx_ring[txq->next_to_clean];\n-\tfor (i = 0; i < txq->tx_rs_thresh; i += HNS3_SVE_CHECK_DESCS_PER_LOOP,\n-\t\t\t\ttx_desc += HNS3_SVE_CHECK_DESCS_PER_LOOP) {\n-\t\tvld2 = svld1_gather_u32offset_u32(pg32, (uint32_t *)tx_desc,\n-\t\t\t\tsvindex_u32(BD_FIELD_VALID_OFFSET, BD_SIZE));\n-\t\tvld = svorr_u32_z(pg32, vld, vld2);\n-\t}\n-\t/* shift left and then right to get all valid bit */\n-\tvld = svlsl_n_u32_z(pg32, vld,\n-\t\t\t HNS3_UINT32_BIT - 1 - HNS3_TXD_VLD_B);\n-\tvld = svreinterpret_u32_s32(svasr_n_s32_z(pg32,\n-\t\tsvreinterpret_s32_u32(vld), HNS3_UINT32_BIT - 1));\n-\t/* use tbl to compress 32bit-lane to 8bit-lane */\n-\tvld_u8 = svtbl_u8(svreinterpret_u8_u32(vld), TX_VLD_U8_ZIP_INDEX);\n-\t/* dump compressed 64bit to variable */\n-\tsvst1_u64(PG64_64BIT, &vld_all, svreinterpret_u64_u8(vld_u8));\n-\tif (vld_all > 0)\n-\t\treturn;\n-\n-\thns3_tx_bulk_free_buffers(txq);\n-}\n-\n static inline void\n hns3_tx_fill_hw_ring_sve(struct hns3_tx_queue *txq,\n \t\t\t struct rte_mbuf **pkts,\n@@ -462,7 +422,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,\n \tuint16_t nb_tx = 0;\n \n \tif (txq->tx_bd_ready < txq->tx_free_thresh)\n-\t\thns3_tx_free_buffers_sve(txq);\n+\t\thns3_tx_free_buffers(txq);\n \n \tnb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts);\n \tif (unlikely(nb_pkts == 0)) {\n", "prefixes": [ "3/5" ] }