Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129457/?format=api
{ "id": 129457, "url": "http://patchwork.dpdk.org/api/patches/129457/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1689094157-16873-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1689094157-16873-3-git-send-email-roretzla@linux.microsoft.com", "date": "2023-07-11T16:49:05", "name": "[v9,02/14] eal: use rtm and xtest intrinsics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "29d878481ec7256244341d233662b8ab81a03151", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28906, "url": "http://patchwork.dpdk.org/api/series/28906/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28906", "date": "2023-07-11T16:49:04", "name": "msvc integration changes", "version": 9, "mbox": "http://patchwork.dpdk.org/series/28906/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129457/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56CFC42E48;\n\tTue, 11 Jul 2023 18:49:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F09A42B8C;\n\tTue, 11 Jul 2023 18:49:23 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 546F740A89\n for <dev@dpdk.org>; Tue, 11 Jul 2023 18:49:19 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 9A4EE21C3A8D; Tue, 11 Jul 2023 09:49:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 9A4EE21C3A8D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1689094158;\n bh=byPfLLUjMSJsBQ1JgxyTOR6ow5661BT1rTeQLtGbIts=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=VJm92sL5Cafkj2E7z5qp8z4s1sz6/SDiTClLh5+KacwKevsGOSLPHq6/CYmXEU9wW\n jZQpQu1ydhQFappOzCvFIcZC07XDNwDqC+5exh5/m7zUwvgV8pbKWALiQ2uIvZCQSG\n 3MgrmfDBQGHnBEW70CQkvEp5elq6/8vOcTxKeLM8=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Ciara Power <ciara.power@intel.com>, thomas@monjalon.net,\n david.marchand@redhat.com, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 02/14] eal: use rtm and xtest intrinsics", "Date": "Tue, 11 Jul 2023 09:49:05 -0700", "Message-Id": "<1689094157-16873-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inline assembly is not supported for MSVC x64. Convert code to use\n_xend, _xabort and _xtest intrinsics.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n config/x86/meson.build | 6 ++++++\n lib/eal/x86/include/rte_rtm.h | 18 +++++-------------\n 2 files changed, 11 insertions(+), 13 deletions(-)", "diff": "diff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 54345c4..4c0b06c 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -30,6 +30,12 @@ if cc.get_define('__SSE4_2__', args: machine_args) == ''\n machine_args += '-msse4'\n endif\n \n+# enable restricted transactional memory intrinsics\n+# https://gcc.gnu.org/onlinedocs/gcc/x86-transactional-memory-intrinsics.html\n+if cc.get_id() != 'msvc'\n+ machine_args += '-mrtm'\n+endif\n+\n base_flags = ['SSE', 'SSE2', 'SSE3','SSSE3', 'SSE4_1', 'SSE4_2']\n foreach f:base_flags\n compile_time_cpuflags += ['RTE_CPUFLAG_' + f]\ndiff --git a/lib/eal/x86/include/rte_rtm.h b/lib/eal/x86/include/rte_rtm.h\nindex 36bf498..b84e58e 100644\n--- a/lib/eal/x86/include/rte_rtm.h\n+++ b/lib/eal/x86/include/rte_rtm.h\n@@ -5,6 +5,7 @@\n #ifndef _RTE_RTM_H_\n #define _RTE_RTM_H_ 1\n \n+#include <immintrin.h>\n \n /* Official RTM intrinsics interface matching gcc/icc, but works\n on older gcc compatible compilers and binutils. */\n@@ -28,31 +29,22 @@\n static __rte_always_inline\n unsigned int rte_xbegin(void)\n {\n-\tunsigned int ret = RTE_XBEGIN_STARTED;\n-\n-\tasm volatile(\".byte 0xc7,0xf8 ; .long 0\" : \"+a\" (ret) :: \"memory\");\n-\treturn ret;\n+\treturn _xbegin();\n }\n \n static __rte_always_inline\n void rte_xend(void)\n {\n-\t asm volatile(\".byte 0x0f,0x01,0xd5\" ::: \"memory\");\n+\t_xend();\n }\n \n /* not an inline function to workaround a clang bug with -O0 */\n-#define rte_xabort(status) do { \\\n-\tasm volatile(\".byte 0xc6,0xf8,%P0\" :: \"i\" (status) : \"memory\"); \\\n-} while (0)\n+#define rte_xabort(status) _xabort(status)\n \n static __rte_always_inline\n int rte_xtest(void)\n {\n-\tunsigned char out;\n-\n-\tasm volatile(\".byte 0x0f,0x01,0xd6 ; setnz %0\" :\n-\t\t\"=r\" (out) :: \"memory\");\n-\treturn out;\n+\treturn _xtest();\n }\n \n #ifdef __cplusplus\n", "prefixes": [ "v9", "02/14" ] }