Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129458/?format=api
http://patchwork.dpdk.org/api/patches/129458/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1689094157-16873-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1689094157-16873-4-git-send-email-roretzla@linux.microsoft.com", "date": "2023-07-11T16:49:06", "name": "[v9,03/14] eal: use barrier intrinsics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba485964fe9cf1d480f7746e73353abe2ea3fe3b", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28906, "url": "http://patchwork.dpdk.org/api/series/28906/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28906", "date": "2023-07-11T16:49:04", "name": "msvc integration changes", "version": 9, "mbox": "http://patchwork.dpdk.org/series/28906/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129458/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 97CEC42E48;\n\tTue, 11 Jul 2023 18:49:37 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D0F442C4D;\n\tTue, 11 Jul 2023 18:49:24 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 593BE40C35\n for <dev@dpdk.org>; Tue, 11 Jul 2023 18:49:19 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id A91EA21C3A93; Tue, 11 Jul 2023 09:49:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A91EA21C3A93", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1689094158;\n bh=vY0QQgx3OOWa3+3NNuFfxU1b3j/IYPW0l1t9dJWYM7w=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=F7wB7lGekTDWOP+vbPk4xhLeEuCJpXDa49VH71Xy/Anr+afi9+Z0GwtNwRrz7X6S8\n 5XZMnua30GAB3ONAK3zS6IYVQoloBCOkLF7cuH8q6+Cfw9TPdWVbVNu0jvRL8+sveF\n 0q8vUJjsOrkx1ejbtH2DDHhqw+g1DbdY2FVPsgmQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Ciara Power <ciara.power@intel.com>, thomas@monjalon.net,\n david.marchand@redhat.com, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 03/14] eal: use barrier intrinsics", "Date": "Tue, 11 Jul 2023 09:49:06 -0700", "Message-Id": "<1689094157-16873-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inline assembly is not supported for MSVC x64 instead expand\nrte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb\n_m_mfence intrinsics.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/include/generic/rte_atomic.h | 4 ++++\n lib/eal/x86/include/rte_atomic.h | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex 58df843..6a6c394 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -116,9 +116,13 @@\n * Guarantees that operation reordering does not occur at compile time\n * for operations directly before and after the barrier.\n */\n+#ifdef RTE_TOOLCHAIN_MSVC\n+#define rte_compiler_barrier() _ReadWriteBarrier()\n+#else\n #define\trte_compiler_barrier() do {\t\t\\\n \tasm volatile (\"\" : : : \"memory\");\t\\\n } while(0)\n+#endif\n \n /**\n * Synchronization fence between threads based on the specified memory order.\ndiff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h\nindex f2ee1a9..7aba1c3 100644\n--- a/lib/eal/x86/include/rte_atomic.h\n+++ b/lib/eal/x86/include/rte_atomic.h\n@@ -66,11 +66,15 @@\n static __rte_always_inline void\n rte_smp_mb(void)\n {\n+#ifdef RTE_TOOLCHAIN_MSVC\n+\t_mm_mfence();\n+#else\n #ifdef RTE_ARCH_I686\n \tasm volatile(\"lock addl $0, -128(%%esp); \" ::: \"memory\");\n #else\n \tasm volatile(\"lock addl $0, -128(%%rsp); \" ::: \"memory\");\n #endif\n+#endif\n }\n \n #define rte_io_mb() rte_mb()\n", "prefixes": [ "v9", "03/14" ] }{ "id": 129458, "url": "