Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129460/?format=api
{ "id": 129460, "url": "http://patchwork.dpdk.org/api/patches/129460/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1689094157-16873-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1689094157-16873-7-git-send-email-roretzla@linux.microsoft.com", "date": "2023-07-11T16:49:09", "name": "[v9,06/14] eal: use prefetch intrinsics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "04c7a7070a40f654e03be2760dc97c68effc5f0a", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28906, "url": "http://patchwork.dpdk.org/api/series/28906/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28906", "date": "2023-07-11T16:49:04", "name": "msvc integration changes", "version": 9, "mbox": "http://patchwork.dpdk.org/series/28906/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129460/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DDFAE42E48;\n\tTue, 11 Jul 2023 18:49:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4CD6F42D1A;\n\tTue, 11 Jul 2023 18:49:26 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 0E5664003C\n for <dev@dpdk.org>; Tue, 11 Jul 2023 18:49:20 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id CF48C21C3F2C; Tue, 11 Jul 2023 09:49:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com CF48C21C3F2C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1689094158;\n bh=YPX3S+/nCL9ARjU2grly6sww6G3NMRVNvaByo0uTCb4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=NPyPGXEWh+U/Llrqwi9MGzMGt31vMqZJ6aWeRrVHWav06/yGYX7uVJ26Uwi1q95z6\n 2oSRta8aLxtTTLABlJ2I8X7lnNJbqRTAy+CoVXHEQwlMg6r8ZrScf61a7tRNYv4WiE\n wQJ3c1qorjJBFAmY8JTkcWrQOXOE9MtIfpGCyWhc=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Ciara Power <ciara.power@intel.com>, thomas@monjalon.net,\n david.marchand@redhat.com, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 06/14] eal: use prefetch intrinsics", "Date": "Tue, 11 Jul 2023 09:49:09 -0700", "Message-Id": "<1689094157-16873-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inline assembly is not supported for MSVC x64 instead use _mm_prefetch\nand _mm_cldemote intrinsics.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\n---\n lib/eal/x86/include/rte_prefetch.h | 25 +++++++++++++++++++++----\n 1 file changed, 21 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/x86/include/rte_prefetch.h b/lib/eal/x86/include/rte_prefetch.h\nindex 7fd01c4..7a6988e 100644\n--- a/lib/eal/x86/include/rte_prefetch.h\n+++ b/lib/eal/x86/include/rte_prefetch.h\n@@ -9,30 +9,38 @@\n extern \"C\" {\n #endif\n \n+#include <emmintrin.h>\n+\n #include <rte_compat.h>\n #include <rte_common.h>\n #include \"generic/rte_prefetch.h\"\n \n+#pragma GCC diagnostic push\n+#pragma GCC diagnostic ignored \"-Wcast-qual\"\n+\n static inline void rte_prefetch0(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht0 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n+\t_mm_prefetch((const void *)p, _MM_HINT_T0);\n }\n \n static inline void rte_prefetch1(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht1 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n+\t_mm_prefetch((const void *)p, _MM_HINT_T1);\n }\n \n static inline void rte_prefetch2(const volatile void *p)\n {\n-\tasm volatile (\"prefetcht2 %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n+\t_mm_prefetch((const void *)p, _MM_HINT_T2);\n }\n \n static inline void rte_prefetch_non_temporal(const volatile void *p)\n {\n-\tasm volatile (\"prefetchnta %[p]\" : : [p] \"m\" (*(const volatile char *)p));\n+\t_mm_prefetch((const void *)p, _MM_HINT_NTA);\n }\n \n+#pragma GCC diagnostic pop\n+\n+#ifdef RTE_TOOLCHAIN_MSVC\n /*\n * We use raw byte codes for now as only the newest compiler\n * versions support this instruction natively.\n@@ -41,8 +49,17 @@ static inline void rte_prefetch_non_temporal(const volatile void *p)\n static inline void\n rte_cldemote(const volatile void *p)\n {\n+\t_mm_cldemote(p);\n+}\n+#else\n+__rte_experimental\n+static inline void\n+rte_cldemote(const volatile void *p)\n+{\n \tasm volatile(\".byte 0x0f, 0x1c, 0x06\" :: \"S\" (p));\n }\n+#endif\n+\n \n #ifdef __cplusplus\n }\n", "prefixes": [ "v9", "06/14" ] }