Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129462/?format=api
{ "id": 129462, "url": "http://patchwork.dpdk.org/api/patches/129462/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-13-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1689094157-16873-13-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1689094157-16873-13-git-send-email-roretzla@linux.microsoft.com", "date": "2023-07-11T16:49:15", "name": "[v9,12/14] telemetry: avoid expanding versioned symbol macros on MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3208b142d438d93f1253d3eadd4b6d442177fd57", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1689094157-16873-13-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28906, "url": "http://patchwork.dpdk.org/api/series/28906/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28906", "date": "2023-07-11T16:49:04", "name": "msvc integration changes", "version": 9, "mbox": "http://patchwork.dpdk.org/series/28906/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129462/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129462/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB7D342E48;\n\tTue, 11 Jul 2023 18:50:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 871B142D33;\n\tTue, 11 Jul 2023 18:49:28 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 39065410E9\n for <dev@dpdk.org>; Tue, 11 Jul 2023 18:49:20 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 2843A21C4271; Tue, 11 Jul 2023 09:49:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 2843A21C4271", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1689094159;\n bh=PLuk/k0rF60gUozSw6zpv6b045cW1SU5joy8Ezn7qgA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=OXQQ2LXESzHFNXX8PYwTz9Uggefm1PrliEMVZAxtpOeKVoFAjeaazFUwQPau8nYz0\n CDeQZ6g0bwFS1iuUoZlq7AJZ0bTPPFCvv5pf2xcEN7wDMvojxAvdahJrskQ2pnYU4N\n k+yfnIRJa0gjeDUTDZfj2990sF9TFDylfw4RqTGw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Ciara Power <ciara.power@intel.com>, thomas@monjalon.net,\n david.marchand@redhat.com, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 12/14] telemetry: avoid expanding versioned symbol macros\n on MSVC", "Date": "Tue, 11 Jul 2023 09:49:15 -0700", "Message-Id": "<1689094157-16873-13-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1689094157-16873-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Windows does not support versioned symbols. Fortunately Windows also\ndoesn't have an exported stable ABI.\n\nExport rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24\nand rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24\nfunctions.\n\nWindows does have a way to achieve similar versioning for symbols but it\nis not a simple #define so it will be done as a work package later.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/telemetry/telemetry_data.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c\nindex 0c7187b..523287b 100644\n--- a/lib/telemetry/telemetry_data.c\n+++ b/lib/telemetry/telemetry_data.c\n@@ -83,8 +83,16 @@\n /* mark the v23 function as the older version, and v24 as the default version */\n VERSION_SYMBOL(rte_tel_data_add_array_int, _v23, 23);\n BIND_DEFAULT_SYMBOL(rte_tel_data_add_array_int, _v24, 24);\n+#ifdef RTE_TOOLCHAIN_MSVC\n+int\n+rte_tel_data_add_array_int(struct rte_tel_data *d, int64_t x)\n+{\n+\treturn rte_tel_data_add_array_int_v24(d, x);\n+}\n+#else\n MAP_STATIC_SYMBOL(int rte_tel_data_add_array_int(struct rte_tel_data *d,\n \t\tint64_t x), rte_tel_data_add_array_int_v24);\n+#endif\n \n int\n rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x)\n@@ -218,8 +226,16 @@\n /* mark the v23 function as the older version, and v24 as the default version */\n VERSION_SYMBOL(rte_tel_data_add_dict_int, _v23, 23);\n BIND_DEFAULT_SYMBOL(rte_tel_data_add_dict_int, _v24, 24);\n+#ifdef RTE_TOOLCHAIN_MSVC\n+int\n+rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int64_t val)\n+{\n+\treturn rte_tel_data_add_dict_int_v24(d, name, val);\n+}\n+#else\n MAP_STATIC_SYMBOL(int rte_tel_data_add_dict_int(struct rte_tel_data *d,\n \t\tconst char *name, int64_t val), rte_tel_data_add_dict_int_v24);\n+#endif\n \n int\n rte_tel_data_add_dict_uint(struct rte_tel_data *d,\n", "prefixes": [ "v9", "12/14" ] }