Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129492/?format=api
{ "id": 129492, "url": "http://patchwork.dpdk.org/api/patches/129492/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230712074215.3249336-3-qiming.yang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230712074215.3249336-3-qiming.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230712074215.3249336-3-qiming.yang@intel.com", "date": "2023-07-12T07:42:14", "name": "[2/3] net/igc: fix Rx and Tx queue status get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5c736e70761f6e4b527427be37004ac35c01e69b", "submitter": { "id": 522, "url": "http://patchwork.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230712074215.3249336-3-qiming.yang@intel.com/mbox/", "series": [ { "id": 28918, "url": "http://patchwork.dpdk.org/api/series/28918/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28918", "date": "2023-07-12T07:42:12", "name": "fix Rx and Tx queue status get", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28918/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129492/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129492/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF27C42E52;\n\tWed, 12 Jul 2023 10:00:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5C6C242BB1;\n\tWed, 12 Jul 2023 10:00:09 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 19E31406BA\n for <dev@dpdk.org>; Wed, 12 Jul 2023 10:00:05 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jul 2023 01:00:05 -0700", "from dpdk-qiming3.sh.intel.com ([10.67.111.4])\n by orsmga004.jf.intel.com with ESMTP; 12 Jul 2023 00:59:54 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1689148806; x=1720684806;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=6C1iwd/eZQ1DUY1gaePavfJxZ8s8XWAHqvvBKCsBh80=;\n b=UdooDWqqdMwjJ448Grimv4E3Mor7NgAr9CIUoTyM+uF0tZaLmOIArynO\n 7/I35uyDJlK44Q3JebfMbkFEunb6FHDVCAk0ZGg7GXEn6LAWWBbOQ2xCF\n +xA0h6nTifXmP7stb04ALcSgh2KqL/K2KuV57LL0UtoEOF/bZsbwA8irI\n 5QNkr6qAHDGynfVzFHPLgXhNAiG9nNRboFraO/s7BlL4mSNEBTI5ZVpeO\n yEQ6DCyw1xZVGhj4O7MpvK87wskuviOVz7RbwKovkRLBJGVfkf2qkvMkb\n p8CSHyP9Z+3nB7e2P3swWG4NnJFItKiNgp7DvASF/t6C6ESO7B+Y/0jJY g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10768\"; a=\"354736660\"", "E=Sophos;i=\"6.01,199,1684825200\"; d=\"scan'208\";a=\"354736660\"", "E=McAfee;i=\"6600,9927,10768\"; a=\"845564072\"", "E=Sophos;i=\"6.01,199,1684825200\"; d=\"scan'208\";a=\"845564072\"" ], "X-ExtLoop1": "1", "From": "Qiming Yang <qiming.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, qi.z.zhang@intel.com,\n Qiming Yang <qiming.yang@intel.com>, Mingjin Ye <mingjinx.ye@intel.com>", "Subject": "[PATCH 2/3] net/igc: fix Rx and Tx queue status get", "Date": "Wed, 12 Jul 2023 07:42:14 +0000", "Message-Id": "<20230712074215.3249336-3-qiming.yang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230712074215.3249336-1-qiming.yang@intel.com>", "References": "<20230712074215.3249336-1-qiming.yang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Igc driver don't enable queue start/stop functions, queue status is not\nupdated when the HW queue enabled or disabled. It caused application can't\nget correct queue status.\nThis patch fixes the issue by updating the queue states when the queue is\ndisabled or enabled.\n\nFixes: a5aeb2b9e225 (\"net/igc: support Rx and Tx\")\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\nSigned-off-by: Mingjin Ye <mingjinx.ye@intel.com>\n---\n drivers/net/igc/igc_txrx.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c\nindex c11b6f7f25..5c60e3e997 100644\n--- a/drivers/net/igc/igc_txrx.c\n+++ b/drivers/net/igc/igc_txrx.c\n@@ -1215,6 +1215,7 @@ igc_rx_init(struct rte_eth_dev *dev)\n \t\t\tdvmolr |= IGC_DVMOLR_STRCRC;\n \n \t\tIGC_WRITE_REG(hw, IGC_DVMOLR(rxq->reg_idx), dvmolr);\n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \n \treturn 0;\n@@ -1888,6 +1889,7 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)\n \t\tif (txq != NULL) {\n \t\t\tigc_tx_queue_release_mbufs(txq);\n \t\t\tigc_reset_tx_queue(txq);\n+\t\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t\t}\n \t}\n \n@@ -1896,6 +1898,7 @@ igc_dev_clear_queues(struct rte_eth_dev *dev)\n \t\tif (rxq != NULL) {\n \t\t\tigc_rx_queue_release_mbufs(rxq);\n \t\t\tigc_reset_rx_queue(rxq);\n+\t\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t\t}\n \t}\n }\n@@ -2143,6 +2146,7 @@ igc_tx_init(struct rte_eth_dev *dev)\n \t\t\t\tIGC_TXDCTL_WTHRESH_MSK;\n \t\ttxdctl |= IGC_TXDCTL_QUEUE_ENABLE;\n \t\tIGC_WRITE_REG(hw, IGC_TXDCTL(txq->reg_idx), txdctl);\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \n \tif (offloads & RTE_ETH_TX_OFFLOAD_SEND_ON_TIMESTAMP) {\n", "prefixes": [ "2/3" ] }