Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129518/?format=api
http://patchwork.dpdk.org/api/patches/129518/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230713102659.230606-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230713102659.230606-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230713102659.230606-3-maxime.coquelin@redhat.com", "date": "2023-07-13T10:26:59", "name": "[2/2] vhost: force vIOMMU enablement with VDUSE", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "043ec45eaa23ee541afdc77a6c48ea3d49a249e6", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230713102659.230606-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28929, "url": "http://patchwork.dpdk.org/api/series/28929/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28929", "date": "2023-07-13T10:26:57", "name": "vduse: TSO & vIOMMU fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28929/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129518/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/129518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCF7542DA6;\n\tThu, 13 Jul 2023 12:27:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 98A5141156;\n\tThu, 13 Jul 2023 12:27:13 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id C1F9141156\n for <dev@dpdk.org>; Thu, 13 Jul 2023 12:27:12 +0200 (CEST)", "from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-547-Wjaw3mK8NkCQxoP4Xygl8g-1; Thu, 13 Jul 2023 06:27:09 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8887E1C05EB2;\n Thu, 13 Jul 2023 10:27:08 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.24])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 611224CD0C6;\n Thu, 13 Jul 2023 10:27:07 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1689244032;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=3Tur4zVJZTfR2trWISKC8yWy9AgpA4dz1YtlnKSlVAM=;\n b=CUGHlGuy29zHUeprmj9t1IcBpXaBakwb05pSeRR3Prv4L2SUfBsAYAUN4uPwJgt9H8Jfqj\n MvHBDRr9wXXL7blEhViIFMemJoAnYYWIAigABR/2wdD4TbuR2XiB6Gw7fk/tXbZ38fWVfB\n pd63g1wpaY2OH/0x8/2Ii/d+ib04oAY=", "X-MC-Unique": "Wjaw3mK8NkCQxoP4Xygl8g-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,\n chenbo.xia@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH 2/2] vhost: force vIOMMU enablement with VDUSE", "Date": "Thu, 13 Jul 2023 12:26:59 +0200", "Message-ID": "<20230713102659.230606-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230713102659.230606-1-maxime.coquelin@redhat.com>", "References": "<20230713102659.230606-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Unlike Vhost-user, VDUSE requires vIOMMU support.\nThis patch ignores whether RTE_VHOST_USER_IOMMU_SUPPORT\nflag is passed at register time to avoid having application\nto pass it for having working VDUSE device creation.\n\nFixes: 0adb8eccc6a6 (\"vhost: add VDUSE device creation and destruction\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/socket.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c\nindex 57dfe3d2fe..79f2138f60 100644\n--- a/lib/vhost/socket.c\n+++ b/lib/vhost/socket.c\n@@ -932,7 +932,10 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \tvsocket->async_copy = flags & RTE_VHOST_USER_ASYNC_COPY;\n \tvsocket->net_compliant_ol_flags = flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;\n \tvsocket->stats_enabled = flags & RTE_VHOST_USER_NET_STATS_ENABLE;\n-\tvsocket->iommu_support = flags & RTE_VHOST_USER_IOMMU_SUPPORT;\n+\tif (vsocket->is_vduse)\n+\t\tvsocket->iommu_support = true;\n+\telse\n+\t\tvsocket->iommu_support = flags & RTE_VHOST_USER_IOMMU_SUPPORT;\n \n \tif (vsocket->async_copy &&\n \t\t(flags & (RTE_VHOST_USER_IOMMU_SUPPORT |\n@@ -986,7 +989,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \t\tvsocket->features &= ~seg_offload_features;\n \t}\n \n-\tif (!(flags & RTE_VHOST_USER_IOMMU_SUPPORT)) {\n+\tif (!vsocket->iommu_support) {\n \t\tvsocket->supported_features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t\tvsocket->features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t}\n", "prefixes": [ "2/2" ] }{ "id": 129518, "url": "