Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129526/?format=api
http://patchwork.dpdk.org/api/patches/129526/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230713135240.240453-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230713135240.240453-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230713135240.240453-2-maxime.coquelin@redhat.com", "date": "2023-07-13T13:52:39", "name": "[v3,1/2] vhost: fix net offload compliance", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c58c8f61b3775a14cfff976077d55e6edc6fe742", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230713135240.240453-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28933, "url": "http://patchwork.dpdk.org/api/series/28933/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28933", "date": "2023-07-13T13:52:38", "name": "vduse: TSO & vIOMMU fixes", "version": 3, "mbox": "http://patchwork.dpdk.org/series/28933/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129526/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA91442E5F;\n\tThu, 13 Jul 2023 15:52:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6F8B341156;\n\tThu, 13 Jul 2023 15:52:51 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id A167F40DDA\n for <dev@dpdk.org>; Thu, 13 Jul 2023 15:52:50 +0200 (CEST)", "from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-586-jlWvtodzP5W2uuqQuC1HTw-1; Thu, 13 Jul 2023 09:52:46 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 396E1293248B;\n Thu, 13 Jul 2023 13:52:46 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.24])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B27911454142;\n Thu, 13 Jul 2023 13:52:44 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1689256369;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=sLbw/bhLRKFLcrfie1PEQp4YUUCdrX7384C7LjFrq2s=;\n b=VAk/lMUJ+tFIeqKBA5Sz1nqSYp8qfTXCjWHzGS9QTVHS5Pr5W0FpgVkS/xLlWBcGMfoLaz\n Evv14JikwB+vzD/OPvrCG+LOx3wXkgSLUBZPQfYMcl+OmvolUr1aVbSea4wNcCWvnKVmE/\n CuNVaS4RoFP+zWF7Vl7kLr5Fv7KLoDE=", "X-MC-Unique": "jlWvtodzP5W2uuqQuC1HTw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,\n chenbo.xia@intel.com, aconole@redhat.com, ktraynor@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v3 1/2] vhost: fix net offload compliance", "Date": "Thu, 13 Jul 2023 15:52:39 +0200", "Message-ID": "<20230713135240.240453-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230713135240.240453-1-maxime.coquelin@redhat.com>", "References": "<20230713135240.240453-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Initial VDUSE support assumed the application always used\nthe net offload compliant mode, which is not the case for\nOVS.\n\nThis patch propagates the value set by the application.\n\nFixes: 0adb8eccc6a6 (\"vhost: add VDUSE device creation and destruction\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/socket.c | 2 +-\n lib/vhost/vduse.c | 4 ++--\n lib/vhost/vduse.h | 6 ++++--\n 3 files changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c\nindex f55fb299fd..57dfe3d2fe 100644\n--- a/lib/vhost/socket.c\n+++ b/lib/vhost/socket.c\n@@ -1233,7 +1233,7 @@ rte_vhost_driver_start(const char *path)\n \t\treturn -1;\n \n \tif (vsocket->is_vduse)\n-\t\treturn vduse_device_create(path);\n+\t\treturn vduse_device_create(path, vsocket->net_compliant_ol_flags);\n \n \tif (fdset_tid == 0) {\n \t\t/**\ndiff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex 5c595e3f94..73ed424232 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -412,7 +412,7 @@ vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n }\n \n int\n-vduse_device_create(const char *path)\n+vduse_device_create(const char *path, bool compliant_ol_flags)\n {\n \tint control_fd, dev_fd, vid, ret;\n \tpthread_t fdset_tid;\n@@ -538,7 +538,7 @@ vduse_device_create(const char *path)\n \tstrncpy(dev->ifname, path, IF_NAME_SZ - 1);\n \tdev->vduse_ctrl_fd = control_fd;\n \tdev->vduse_dev_fd = dev_fd;\n-\tvhost_setup_virtio_net(dev->vid, true, true, true, true);\n+\tvhost_setup_virtio_net(dev->vid, true, compliant_ol_flags, true, true);\n \n \tfor (i = 0; i < total_queues; i++) {\n \t\tstruct vduse_vq_config vq_cfg = { 0 };\ndiff --git a/lib/vhost/vduse.h b/lib/vhost/vduse.h\nindex d0142694a7..4879b1f900 100644\n--- a/lib/vhost/vduse.h\n+++ b/lib/vhost/vduse.h\n@@ -11,14 +11,16 @@\n \n #ifdef VHOST_HAS_VDUSE\n \n-int vduse_device_create(const char *path);\n+int vduse_device_create(const char *path, bool compliant_ol_flags);\n int vduse_device_destroy(const char *path);\n \n #else\n \n static inline int\n-vduse_device_create(const char *path)\n+vduse_device_create(const char *path, bool compliant_ol_flags)\n {\n+\tRTE_SET_USED(compliant_ol_flags);\n+\n \tVHOST_LOG_CONFIG(path, ERR, \"VDUSE support disabled at build time\\n\");\n \treturn -1;\n }\n", "prefixes": [ "v3", "1/2" ] }{ "id": 129526, "url": "