Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129652/?format=api
{ "id": 129652, "url": "http://patchwork.dpdk.org/api/patches/129652/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230718010047.456679-1-jonathan.erb@threatblockr.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230718010047.456679-1-jonathan.erb@threatblockr.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230718010047.456679-1-jonathan.erb@threatblockr.com", "date": "2023-07-18T01:00:46", "name": "eal/linux: prevent deadlocks on rte init and cleanup", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "ed5757dba00695df91805a0a2e8c48b1a5998980", "submitter": { "id": 3137, "url": "http://patchwork.dpdk.org/api/people/3137/?format=api", "name": "Jonathan Erb", "email": "jonathan.erb@threatblockr.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230718010047.456679-1-jonathan.erb@threatblockr.com/mbox/", "series": [ { "id": 28978, "url": "http://patchwork.dpdk.org/api/series/28978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28978", "date": "2023-07-18T01:00:46", "name": "eal/linux: prevent deadlocks on rte init and cleanup", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28978/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129652/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/129652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 37FEF42EC6;\n\tThu, 20 Jul 2023 07:19:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4EFBD42BB1;\n\tThu, 20 Jul 2023 07:18:54 +0200 (CEST)", "from mail-qk1-f178.google.com (mail-qk1-f178.google.com\n [209.85.222.178])\n by mails.dpdk.org (Postfix) with ESMTP id 41818406B3\n for <dev@dpdk.org>; Tue, 18 Jul 2023 03:01:02 +0200 (CEST)", "by mail-qk1-f178.google.com with SMTP id\n af79cd13be357-7659cb9c42aso419739485a.3\n for <dev@dpdk.org>; Mon, 17 Jul 2023 18:01:02 -0700 (PDT)", "from localhost.localdomain (dyn-170-246-97.myactv.net.\n [24.170.246.97]) by smtp.gmail.com with ESMTPSA id\n s2-20020a05620a030200b0076814f80d5asm238610qkm.4.2023.07.17.18.01.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 17 Jul 2023 18:01:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=threatblockr-com.20221208.gappssmtp.com; s=20221208; t=1689642061;\n x=1692234061;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=ftU5jVtwz+bAV2jqa2OHXPNHnR/6lrblDoaxG5GV5xA=;\n b=jaWT68oPT0AevaEcMKVHMpn2ILjAM46ngt6Mh55zqcVCsjoZR2WKuzZucCssiXvS06\n 3Y7AHnbU/+dCQ0k2oTa0uxR7vBX7Jn/BqGvW9Qp9tuYJQrzWOZrBSXcfe/B+ehN8BwvZ\n qAyelImRfuVOTLZJcGArTynEQQHOGOWu5PKWsQOt3Iz7zObHhlvdDqMvG7K10E/KeLT3\n Pbm42L9Sh+ziaoxhJcQCL75gwbzZxgosqo4fiAFfTRAAgnYw3Qxe5brnBuCI32XnTgld\n TDF0uCg5Ou8yqdXvsI8+RIxohPmxvhLM4G4cTk1XruT2ROTQVXiSh/DaBA3YEUwsKJEb\n ezrA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1689642061; x=1692234061;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ftU5jVtwz+bAV2jqa2OHXPNHnR/6lrblDoaxG5GV5xA=;\n b=Ym++AyDzg3h5ev4gMKv0IPi7FEz9HU7Oxotb5MsEyp527zv0I206D4ZuI/Wrd4NBGP\n i5KaU+yx2OU6Cn5AVlMXEWPe3m3sOQXsg4S2n0N9BOrMZLAg6wQpYIpovoxJGO1TPVaM\n c83byPRR/RKnpl8x/xN9XNRlME4TyHIea4mt0EK+iY7I4e2LvB6RFEnzD+wYPNRWoCG8\n P8T4dkxBwWaRs5tfkMVqntkCF6WQ/B7B7D6cIfeLg0qzLNEzRmU4I657TKaFffyjT+ki\n KUg4H73+S715QZ/tblX27UbF+bd3X305xC//nkuy9lXg8EQJLJFKTnISp2xPao8QYvB3\n 2Yag==", "X-Gm-Message-State": "ABy/qLaDeR1DwjXHU7Atqo3TdisdbWCLlR9Ep7gMpGDkrEQynBNVNcAF\n dFnhtZj9KQBZ8ZCDxbRxt55i5g==", "X-Google-Smtp-Source": "\n APBJJlEDrHtTs4XIP2D6ZtQeAgI32SRavrjngmH5feY9V9QZluL+POPU2kGv3+0gyWoyf38E0ndA7w==", "X-Received": "by 2002:a05:620a:2950:b0:75e:d895:6a46 with SMTP id\n n16-20020a05620a295000b0075ed8956a46mr14529037qkp.44.1689642061514;\n Mon, 17 Jul 2023 18:01:01 -0700 (PDT)", "From": "Jonathan Erb <jonathan.erb@threatblockr.com>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev@dpdk.org, Jonathan Erb <jonathan.erb@threatblockr.com>,\n stable@dpdk.org", "Subject": "[PATCH] eal/linux: prevent deadlocks on rte init and cleanup", "Date": "Mon, 17 Jul 2023 21:00:46 -0400", "Message-Id": "<20230718010047.456679-1-jonathan.erb@threatblockr.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 20 Jul 2023 07:18:50 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Resolves a deadlock that can occur when multiple secondary\nprocesses are starting and stopping. A deadlock can occur because\neal_memalloc_init() is taking a second unnecessary read lock.\nIf another DPDK process that is terminating enters rte_eal_memory_detach()\nand acquires a write lock wait state before the starting process can\nacquire it's second read lock then no process will be able to proceed.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Jonathan Erb <jonathan.erb@threatblockr.com>\n---\n .mailmap | 2 +-\n lib/eal/linux/eal_memalloc.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 6eccf0c555..a64bfcf1d2 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -663,7 +663,7 @@ John OLoughlin <john.oloughlin@intel.com>\n John Ousterhout <ouster@cs.stanford.edu>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n-Jonathan Erb <jonathan.erb@banduracyber.com>\n+Jonathan Erb <jonathan.erb@threatblockr.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\n Joongi Kim <joongi@an.kaist.ac.kr>\ndiff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c\nindex f8b1588cae..a34f1cf2f9 100644\n--- a/lib/eal/linux/eal_memalloc.c\n+++ b/lib/eal/linux/eal_memalloc.c\n@@ -1740,7 +1740,7 @@ eal_memalloc_init(void)\n \t\teal_get_internal_configuration();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n-\t\tif (rte_memseg_list_walk(secondary_msl_create_walk, NULL) < 0)\n+\t\tif (rte_memseg_list_walk_thread_unsafe(secondary_msl_create_walk, NULL) < 0)\n \t\t\treturn -1;\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY &&\n \t\t\tinternal_conf->in_memory) {\n@@ -1778,7 +1778,7 @@ eal_memalloc_init(void)\n \t}\n \n \t/* initialize all of the fd lists */\n-\tif (rte_memseg_list_walk(fd_list_create_walk, NULL))\n+\tif (rte_memseg_list_walk_thread_unsafe(fd_list_create_walk, NULL))\n \t\treturn -1;\n \treturn 0;\n }\n", "prefixes": [] }