Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129853/?format=api
{ "id": 129853, "url": "http://patchwork.dpdk.org/api/patches/129853/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230802232550.125487-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230802232550.125487-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230802232550.125487-4-stephen@networkplumber.org", "date": "2023-08-02T23:25:34", "name": "[v4,03/19] test: replace use word sanity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cf32e3f4d402d7c7949e340f1e44f1bb752a38b4", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230802232550.125487-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 29100, "url": "http://patchwork.dpdk.org/api/series/29100/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29100", "date": "2023-08-02T23:25:31", "name": "replace use of term \"sanity check\"", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29100/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129853/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1B8742FBA;\n\tThu, 3 Aug 2023 01:26:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5639243265;\n\tThu, 3 Aug 2023 01:26:08 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 4FE5E43256\n for <dev@dpdk.org>; Thu, 3 Aug 2023 01:26:05 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1bbf0f36ce4so3065625ad.0\n for <dev@dpdk.org>; Wed, 02 Aug 2023 16:26:05 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n jd20-20020a170903261400b001b8b0ac2258sm12960870plb.174.2023.08.02.16.26.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 02 Aug 2023 16:26:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691018764;\n x=1691623564;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EZybhrvpl/Xy/HZqdtT/nbew0GdrNfKY5w4u/i/Dk8Y=;\n b=tldRYo9GDiMM5iDZ8TdJ4Q4tEkq73gONG0herLyh8eoP7yjFMAzvGIhPntCMYQDdgH\n n/CQcPeEGuPm+kknLpBHCDgbv/B9UNRBAi512drZqq/iAZKSvwb+YaP7o0q9oC9q74jz\n b3YGQR/y847/O9reIAB7sVAiC9lU544b4FaYcjCWlhE/HllBXd4+scVWKbeYY0DXlbkW\n ahR221fgqErrL2cJIl/rbzLHNPFlj6UVej/djBxaIYx7T6fy0pDLWm3C9oGsOllbnD91\n rxh0KVPl95JSZdsGkbJ3HPUL4wXCTV7YbUsX4iULrR91gCSK5K+uPnxd3ZaG6MVW9lnQ\n vgEA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691018764; x=1691623564;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=EZybhrvpl/Xy/HZqdtT/nbew0GdrNfKY5w4u/i/Dk8Y=;\n b=beY7wCcLqvBxg2CjQeJhKYYexHlT1YPJYSz0WAaSgRYm5reyhtawIng/Fgf96+PXkU\n MWVNiqP0bj0EiFlHcGA5/XwTgY0R8RZnxg9Yd00jXSGgh3OGHpHkkbr9ZIaqHGdt1bBU\n W0ddKrm08XvuOyDHBtBYz9XHdqYUtVFAZfEPADeMFEWnNcwfAIY/dTwm85LC94a+kBIN\n /HW0wkAB2MDM6awiHeNZOY07hUXuA+69nT0fV5GmTVVEHOTw5Jw3ljEbCJoQDaH6JekD\n JgUE2L60tDXKuT8DctiWl03t8RTffk4r4K917yizlqQTZmeQ0UldLIKrHGs8E0NqR6G3\n gNMQ==", "X-Gm-Message-State": "ABy/qLbq9BQ5Z8RpgmtiCqQe1AHlg/tyb4XUN0UNEpf0z9NZUG/ivpDT\n SsOsoerVZuG7kGZ9tsa6xOgChLdKpEb4AM/3oC5+ww==", "X-Google-Smtp-Source": "\n APBJJlF6p7fCLW0Vj1hiMOr94uzYNdGH+YF4IdIrPA37zyQwupNWM8o04unBSScOON+046WqRFAO0g==", "X-Received": "by 2002:a17:902:cecb:b0:1bb:a922:4a1a with SMTP id\n d11-20020a170902cecb00b001bba9224a1amr18178984plg.6.1691018764134;\n Wed, 02 Aug 2023 16:26:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n David Hunt <david.hunt@intel.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Harman Kalra <hkalra@marvell.com>, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>", "Subject": "[PATCH v4 03/19] test: replace use word sanity", "Date": "Wed, 2 Aug 2023 16:25:34 -0700", "Message-Id": "<20230802232550.125487-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230802232550.125487-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>\n <20230802232550.125487-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The word \"sanity\" is on the not-allowed inclusive naming\nlist. Replace the unnecessary usage in tests.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_bitmap.c | 4 +--\n app/test/test_bpf.c | 6 ++--\n app/test/test_common.c | 2 +-\n app/test/test_distributor.c | 46 +++++++++++++++---------------\n app/test/test_dmadev.c | 2 +-\n app/test/test_eal_flags.c | 20 ++++++-------\n app/test/test_hash.c | 2 +-\n app/test/test_interrupts.c | 9 +++---\n app/test/test_link_bonding_mode4.c | 2 +-\n app/test/test_mbuf.c | 2 +-\n app/test/test_rawdev.c | 2 +-\n app/test/test_timer.c | 10 +++----\n 12 files changed, 54 insertions(+), 53 deletions(-)", "diff": "diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c\nindex e9c61590aef7..8cb5d0954a2b 100644\n--- a/app/test/test_bitmap.c\n+++ b/app/test/test_bitmap.c\n@@ -33,7 +33,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp)\n \t}\n \n \tif (slab1_magic != out_slab) {\n-\t\tprintf(\"Scan operation sanity failed.\\n\");\n+\t\tprintf(\"Scan operation magic number check failed.\\n\");\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -43,7 +43,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp)\n \t}\n \n \tif (slab2_magic != out_slab) {\n-\t\tprintf(\"Scan operation sanity failed.\\n\");\n+\t\tprintf(\"Scan operation magic number check failed.\\n\");\n \t\treturn TEST_FAILED;\n \t}\n \ndiff --git a/app/test/test_bpf.c b/app/test/test_bpf.c\nindex f5af5e8a3f4a..347b672ac211 100644\n--- a/app/test/test_bpf.c\n+++ b/app/test/test_bpf.c\n@@ -3329,9 +3329,9 @@ test_bpf_match(pcap_t *pcap, const char *str,\n \treturn ret;\n }\n \n-/* Basic sanity test can we match a IP packet */\n+/* Basic test can we match a IP packet */\n static int\n-test_bpf_filter_sanity(pcap_t *pcap)\n+test_bpf_filter_match(pcap_t *pcap)\n {\n \tconst uint32_t plen = 100;\n \tstruct rte_mbuf mb, *m;\n@@ -3463,7 +3463,7 @@ test_bpf_convert(void)\n \t\treturn -1;\n \t}\n \n-\trc = test_bpf_filter_sanity(pcap);\n+\trc = test_bpf_filter_match(pcap);\n \tfor (i = 0; i < RTE_DIM(sample_filters); i++)\n \t\trc |= test_bpf_filter(pcap, sample_filters[i]);\n \ndiff --git a/app/test/test_common.c b/app/test/test_common.c\nindex f89e1eb7ee0d..c7ce8ea32a77 100644\n--- a/app/test/test_common.c\n+++ b/app/test/test_common.c\n@@ -18,7 +18,7 @@\n \t{printf(x \"() test failed!\\n\");\\\n \treturn -1;}\n \n-/* this is really a sanity check */\n+/* this is really a consistency check */\n static int\n test_macros(int __rte_unused unused_parm)\n {\ndiff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex 3efa4af10439..36e246927aac 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -80,7 +80,7 @@ clear_packet_count(void)\n \t\t\t__ATOMIC_RELAXED);\n }\n \n-/* this is the basic worker function for sanity test\n+/* this is the basic worker function\n * it does nothing but return packets and count them.\n */\n static int\n@@ -105,7 +105,7 @@ handle_work(void *arg)\n \treturn 0;\n }\n \n-/* do basic sanity testing of the distributor. This test tests the following:\n+/* do basic testing of the distributor. This test tests the following:\n * - send 32 packets through distributor with the same tag and ensure they\n * all go to the one worker\n * - send 32 packets through the distributor with two different tags and\n@@ -117,7 +117,7 @@ handle_work(void *arg)\n * not necessarily in the same order (as different flows).\n */\n static int\n-sanity_test(struct worker_params *wp, struct rte_mempool *p)\n+basic_test(struct worker_params *wp, struct rte_mempool *p)\n {\n \tstruct rte_distributor *db = wp->dist;\n \tstruct rte_mbuf *bufs[BURST];\n@@ -126,7 +126,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \tunsigned int retries;\n \tunsigned int processed;\n \n-\tprintf(\"=== Basic distributor sanity tests ===\\n\");\n+\tprintf(\"=== Basic distributor tests ===\\n\");\n \tclear_packet_count();\n \tif (rte_mempool_get_bulk(p, (void *)bufs, BURST) != 0) {\n \t\tprintf(\"line %d: Error getting mbufs from pool\\n\", __LINE__);\n@@ -163,7 +163,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \t\tprintf(\"Worker %u handled %u packets\\n\", i,\n \t\t\t__atomic_load_n(&worker_stats[i].handled_packets,\n \t\t\t\t\t__ATOMIC_RELAXED));\n-\tprintf(\"Sanity test with all zero hashes done.\\n\");\n+\tprintf(\"Test with all zero hashes done.\\n\");\n \n \t/* pick two flows and check they go correctly */\n \tif (rte_lcore_count() >= 3) {\n@@ -191,7 +191,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \t\t\t\t__atomic_load_n(\n \t\t\t\t\t&worker_stats[i].handled_packets,\n \t\t\t\t\t__ATOMIC_RELAXED));\n-\t\tprintf(\"Sanity test with two hash values done\\n\");\n+\t\tprintf(\"Test with two hash values done\\n\");\n \t}\n \n \t/* give a different hash value to each packet,\n@@ -219,11 +219,11 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \t\tprintf(\"Worker %u handled %u packets\\n\", i,\n \t\t\t__atomic_load_n(&worker_stats[i].handled_packets,\n \t\t\t\t\t__ATOMIC_RELAXED));\n-\tprintf(\"Sanity test with non-zero hashes done\\n\");\n+\tprintf(\"Test with non-zero hashes done\\n\");\n \n \trte_mempool_put_bulk(p, (void *)bufs, BURST);\n \n-\t/* sanity test with BIG_BATCH packets to ensure they all arrived back\n+\t/* test with BIG_BATCH packets to ensure they all arrived back\n \t * from the returned packets function */\n \tclear_packet_count();\n \tstruct rte_mbuf *many_bufs[BIG_BATCH], *return_bufs[BIG_BATCH];\n@@ -288,7 +288,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool *p)\n \t\t\treturn -1;\n \t\t}\n \t}\n-\tprintf(\"Sanity test of returned packets done\\n\");\n+\tprintf(\"Test of returned packets done\\n\");\n \n \trte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH);\n \n@@ -326,20 +326,20 @@ handle_work_with_free_mbufs(void *arg)\n \treturn 0;\n }\n \n-/* Perform a sanity test of the distributor with a large number of packets,\n+/* Perform a test of the distributor with a large number of packets,\n * where we allocate a new set of mbufs for each burst. The workers then\n * free the mbufs. This ensures that we don't have any packet leaks in the\n * library.\n */\n static int\n-sanity_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p)\n+basic_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p)\n {\n \tstruct rte_distributor *d = wp->dist;\n \tunsigned i;\n \tstruct rte_mbuf *bufs[BURST];\n \tunsigned int processed;\n \n-\tprintf(\"=== Sanity test with mbuf alloc/free (%s) ===\\n\", wp->name);\n+\tprintf(\"=== Test with mbuf alloc/free (%s) ===\\n\", wp->name);\n \n \tclear_packet_count();\n \tfor (i = 0; i < ((1<<ITER_POWER)); i += BURST) {\n@@ -367,7 +367,7 @@ sanity_test_with_mbuf_alloc(struct worker_params *wp, struct rte_mempool *p)\n \t\treturn -1;\n \t}\n \n-\tprintf(\"Sanity test with mbuf alloc/free passed\\n\\n\");\n+\tprintf(\"Test with mbuf alloc/free passed\\n\\n\");\n \treturn 0;\n }\n \n@@ -433,13 +433,13 @@ handle_work_for_shutdown_test(void *arg)\n }\n \n \n-/* Perform a sanity test of the distributor with a large number of packets,\n+/* Perform a test of the distributor with a large number of packets,\n * where we allocate a new set of mbufs for each burst. The workers then\n * free the mbufs. This ensures that we don't have any packet leaks in the\n * library.\n */\n static int\n-sanity_test_with_worker_shutdown(struct worker_params *wp,\n+basic_test_with_worker_shutdown(struct worker_params *wp,\n \t\tstruct rte_mempool *p)\n {\n \tstruct rte_distributor *d = wp->dist;\n@@ -449,7 +449,7 @@ sanity_test_with_worker_shutdown(struct worker_params *wp,\n \tunsigned int failed = 0;\n \tunsigned int processed = 0;\n \n-\tprintf(\"=== Sanity test of worker shutdown ===\\n\");\n+\tprintf(\"=== Test of worker shutdown ===\\n\");\n \n \tclear_packet_count();\n \n@@ -515,7 +515,7 @@ sanity_test_with_worker_shutdown(struct worker_params *wp,\n \tif (failed)\n \t\treturn -1;\n \n-\tprintf(\"Sanity test with worker shutdown passed\\n\\n\");\n+\tprintf(\"Test with worker shutdown passed\\n\\n\");\n \treturn 0;\n }\n \n@@ -611,13 +611,13 @@ handle_and_mark_work(void *arg)\n \treturn 0;\n }\n \n-/* sanity_mark_test sends packets to workers which mark them.\n+/* mark_test sends packets to workers which mark them.\n * Every packet has also encoded sequence number.\n * The returned packets are sorted and verified if they were handled\n * by proper workers.\n */\n static int\n-sanity_mark_test(struct worker_params *wp, struct rte_mempool *p)\n+mark_test(struct worker_params *wp, struct rte_mempool *p)\n {\n \tconst unsigned int buf_count = 24;\n \tconst unsigned int burst = 8;\n@@ -898,13 +898,13 @@ test_distributor(void)\n \n \t\trte_eal_mp_remote_launch(handle_work,\n \t\t\t\t&worker_params, SKIP_MAIN);\n-\t\tif (sanity_test(&worker_params, p) < 0)\n+\t\tif (basic_test(&worker_params, p) < 0)\n \t\t\tgoto err;\n \t\tquit_workers(&worker_params, p);\n \n \t\trte_eal_mp_remote_launch(handle_work_with_free_mbufs,\n \t\t\t\t&worker_params, SKIP_MAIN);\n-\t\tif (sanity_test_with_mbuf_alloc(&worker_params, p) < 0)\n+\t\tif (basic_test_with_mbuf_alloc(&worker_params, p) < 0)\n \t\t\tgoto err;\n \t\tquit_workers(&worker_params, p);\n \n@@ -912,7 +912,7 @@ test_distributor(void)\n \t\t\trte_eal_mp_remote_launch(handle_work_for_shutdown_test,\n \t\t\t\t\t&worker_params,\n \t\t\t\t\tSKIP_MAIN);\n-\t\t\tif (sanity_test_with_worker_shutdown(&worker_params,\n+\t\t\tif (basic_test_with_worker_shutdown(&worker_params,\n \t\t\t\t\tp) < 0)\n \t\t\t\tgoto err;\n \t\t\tquit_workers(&worker_params, p);\n@@ -927,7 +927,7 @@ test_distributor(void)\n \n \t\t\trte_eal_mp_remote_launch(handle_and_mark_work,\n \t\t\t\t\t&worker_params, SKIP_MAIN);\n-\t\t\tif (sanity_mark_test(&worker_params, p) < 0)\n+\t\t\tif (mark_test(&worker_params, p) < 0)\n \t\t\t\tgoto err;\n \t\t\tquit_workers(&worker_params, p);\n \ndiff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c\nindex 0736ff2a1867..b54319f763f4 100644\n--- a/app/test/test_dmadev.c\n+++ b/app/test/test_dmadev.c\n@@ -927,7 +927,7 @@ test_dma(void)\n {\n \tint i;\n \n-\t/* basic sanity on dmadev infrastructure */\n+\t/* basic validation on dmadev infrastructure */\n \tif (test_apis() < 0)\n \t\tERR_RETURN(\"Error performing API tests\\n\");\n \ndiff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 148e9098e819..0fe2989d0a58 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -314,7 +314,7 @@ get_number_of_sockets(void)\n \n /*\n * Test that the app doesn't run with invalid allow option.\n- * Final tests ensures it does run with valid options as sanity check (one\n+ * Final tests ensures it does run with valid options as basic test (one\n * test for with Domain+BDF, second for just with BDF)\n */\n static int\n@@ -382,7 +382,7 @@ test_allow_flag(void)\n \n /*\n * Test that the app doesn't run with invalid blocklist option.\n- * Final test ensures it does run with valid options as sanity check\n+ * Final test ensures it does run with valid options as basic check.\n */\n static int\n test_invalid_b_flag(void)\n@@ -429,7 +429,7 @@ test_invalid_b_flag(void)\n \n /*\n * Test that the app doesn't run with invalid vdev option.\n- * Final test ensures it does run with valid options as sanity check\n+ * Final test ensures it does run with valid options basic check.\n */\n static int\n test_invalid_vdev_flag(void)\n@@ -554,7 +554,7 @@ test_missing_c_flag(void)\n \t/* bad coremask value */\n \tconst char *argv3[] = { prgname, prefix, mp_flag,\n \t\t\t\t\"-c\", \"error\" };\n-\t/* sanity check of tests - valid coremask value */\n+\t/* check of tests - valid coremask value */\n \tconst char *argv4[] = { prgname, prefix, mp_flag,\n \t\t\t\t\"-c\", \"1\" };\n \t/* -l flag but no corelist value */\n@@ -581,7 +581,7 @@ test_missing_c_flag(void)\n \t\t\t\t\"-l\", RTE_STR(RTE_MAX_LCORE) };\n \tconst char * const argv14[] = { prgname, prefix, mp_flag,\n \t\t\t\t\"-l\", \"1-\"RTE_STR(RTE_MAX_LCORE) };\n-\t/* sanity check test - valid corelist value */\n+\t/* check test - valid corelist value */\n \tconst char * const argv15[] = { prgname, prefix, mp_flag,\n \t\t\t\t \"-l\", \"1-2,3\" };\n \n@@ -613,7 +613,7 @@ test_missing_c_flag(void)\n \t\t\t\t \"--lcores\", \"(4-7)=(1,3)\" };\n \tconst char * const argv28[] = { prgname, prefix, mp_flag,\n \t\t\t\t \"--lcores\", \"[4-7]@(1,3)\" };\n-\t/* sanity check of tests - valid lcores value */\n+\t/* more complex valid lcores value */\n \tconst char * const argv29[] = { prgname, prefix, mp_flag,\n \t\t\t\t \"--lcores\",\n \t\t\t\t \"0-1,2@(5-7),(3-5)@(0,2),(0,6),7\"};\n@@ -744,7 +744,7 @@ test_main_lcore_flag(void)\n \n /*\n * Test that the app doesn't run with invalid -n flag option.\n- * Final test ensures it does run with valid options as sanity check\n+ * Final test ensures it does run with valid options as basic check.\n * Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf\n * flags.\n */\n@@ -772,10 +772,10 @@ test_invalid_n_flag(void)\n \t/* zero is invalid */\n \tconst char *argv3[] = { prgname, prefix, no_huge, no_shconf,\n \t\t\t\t\"-n\", \"0\" };\n-\t/* sanity test - check with good value */\n+\t/* check with good value */\n \tconst char *argv4[] = { prgname, prefix, no_huge, no_shconf,\n \t\t\t\t\"-n\", \"2\" };\n-\t/* sanity test - check with no -n flag */\n+\t/* check with no -n flag */\n \tconst char *argv5[] = { prgname, prefix, no_huge, no_shconf};\n \n \tif (launch_proc(argv1) == 0\n@@ -977,7 +977,7 @@ test_misc_flags(void)\n \t * All cases, apart from the first, app should run.\n \t * No further testing of output done.\n \t */\n-\t/* sanity check - failure with invalid option */\n+\t/* failure with invalid option */\n \tconst char *argv0[] = {prgname, prefix, mp_flag, \"--invalid-opt\"};\n \n \t/* With --no-pci */\ndiff --git a/app/test/test_hash.c b/app/test/test_hash.c\nindex 3e45afaa67fc..f521ce7f679a 100644\n--- a/app/test/test_hash.c\n+++ b/app/test/test_hash.c\n@@ -1088,7 +1088,7 @@ fbk_hash_unit_test(void)\n \t\t.socket_id = 0,\n \t};\n \n-\t/* this is a sanity check for \"same name\" test\n+\t/* this is a check for \"same name\" test\n \t * creating this hash will check if we are actually able to create\n \t * multiple hashes with different names (instead of having just one).\n \t */\ndiff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c\nindex b59ab426999c..88105b78a455 100644\n--- a/app/test/test_interrupts.c\n+++ b/app/test/test_interrupts.c\n@@ -48,7 +48,7 @@ static union intr_pipefds pfds;\n * Check if the interrupt handle is valid.\n */\n static inline int\n-test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle)\n+test_interrupt_handle_check(struct rte_intr_handle *intr_handle)\n {\n \tif (!intr_handle || rte_intr_fd_get(intr_handle) < 0)\n \t\treturn -1;\n@@ -164,7 +164,7 @@ test_interrupt_handle_compare(struct rte_intr_handle *intr_handle_l,\n #else\n /* to be implemented for bsd later */\n static inline int\n-test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle)\n+test_interrupt_handle_check(struct rte_intr_handle *intr_handle)\n {\n \tRTE_SET_USED(intr_handle);\n \n@@ -215,7 +215,7 @@ test_interrupt_callback(void *arg)\n \t\treturn;\n \t}\n \n-\tif (test_interrupt_handle_sanity_check(intr_handle) < 0) {\n+\tif (test_interrupt_handle_check(intr_handle) < 0) {\n \t\tprintf(\"null or invalid intr_handle for %s\\n\", __func__);\n \t\tflag = -1;\n \t\treturn;\n@@ -241,7 +241,8 @@ static void\n test_interrupt_callback_1(void *arg)\n {\n \tstruct rte_intr_handle *intr_handle = arg;\n-\tif (test_interrupt_handle_sanity_check(intr_handle) < 0) {\n+\n+\tif (test_interrupt_handle_check(intr_handle) < 0) {\n \t\tprintf(\"null or invalid intr_handle for %s\\n\", __func__);\n \t\tflag = -1;\n \t\treturn;\ndiff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex 21c512c94b89..95dd52848fb9 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -224,7 +224,7 @@ add_slave(struct slave_conf *slave, uint8_t start)\n \tstruct rte_ether_addr addr, addr_check;\n \tint retval;\n \n-\t/* Some sanity check */\n+\t/* Some basic tests. */\n \tRTE_VERIFY(test_params.slave_ports <= slave &&\n \t\tslave - test_params.slave_ports < (int)RTE_DIM(test_params.slave_ports));\n \tRTE_VERIFY(slave->bonded == 0);\ndiff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex f3f5400e2eca..9c97b95268d7 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1701,7 +1701,7 @@ test_mbuf_validate_tx_offload(const char *test_name,\n \tstruct rte_mbuf *m = NULL;\n \tint ret = 0;\n \n-\t/* alloc a mbuf and do sanity check */\n+\t/* alloc a mbuf and do some basic checks */\n \tm = rte_pktmbuf_alloc(pktmbuf_pool);\n \tif (m == NULL)\n \t\tGOTO_FAIL(\"%s: mbuf allocation failed!\\n\", __func__);\ndiff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c\nindex 3c780e3f9e96..c807bf90d9c3 100644\n--- a/app/test/test_rawdev.c\n+++ b/app/test/test_rawdev.c\n@@ -47,7 +47,7 @@ test_rawdev_selftests(void)\n \tint ret = 0;\n \tint i;\n \n-\t/* basic sanity on rawdev infrastructure */\n+\t/* basic check on rawdev infrastructure */\n \tif (test_rawdev_selftest_skeleton() < 0)\n \t\treturn -1;\n \ndiff --git a/app/test/test_timer.c b/app/test/test_timer.c\nindex 0c36dc9010b0..6615ce536443 100644\n--- a/app/test/test_timer.c\n+++ b/app/test/test_timer.c\n@@ -491,11 +491,11 @@ timer_basic_main_loop(__rte_unused void *arg)\n }\n \n static int\n-timer_sanity_check(void)\n+timer_check(void)\n {\n #ifdef RTE_LIBEAL_USE_HPET\n \tif (eal_timer_source != EAL_TIMER_HPET) {\n-\t\tprintf(\"Not using HPET, can't sanity check timer sources\\n\");\n+\t\tprintf(\"Not using HPET, can't check timer sources\\n\");\n \t\treturn 0;\n \t}\n \n@@ -539,9 +539,9 @@ test_timer(void)\n \t\treturn TEST_SKIPPED;\n \t}\n \n-\t/* sanity check our timer sources and timer config values */\n-\tif (timer_sanity_check() < 0) {\n-\t\tprintf(\"Timer sanity checks failed\\n\");\n+\t/* check our timer sources and timer config values */\n+\tif (timer_check() < 0) {\n+\t\tprintf(\"Timer checks failed\\n\");\n \t\treturn TEST_FAILED;\n \t}\n \n", "prefixes": [ "v4", "03/19" ] }