Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129869/?format=api
{ "id": 129869, "url": "http://patchwork.dpdk.org/api/patches/129869/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230802232550.125487-20-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230802232550.125487-20-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230802232550.125487-20-stephen@networkplumber.org", "date": "2023-08-02T23:25:50", "name": "[v4,19/19] drivers: remove use of term sanity check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b4e37ccea44f27cbef3ae9e5726a1f4426fda4f2", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230802232550.125487-20-stephen@networkplumber.org/mbox/", "series": [ { "id": 29100, "url": "http://patchwork.dpdk.org/api/series/29100/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29100", "date": "2023-08-02T23:25:31", "name": "replace use of term \"sanity check\"", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29100/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129869/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A53542FBA;\n\tThu, 3 Aug 2023 01:27:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B9DB7432BB;\n\tThu, 3 Aug 2023 01:26:23 +0200 (CEST)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id D4672432A0\n for <dev@dpdk.org>; Thu, 3 Aug 2023 01:26:19 +0200 (CEST)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1bc0d39b52cso3191715ad.2\n for <dev@dpdk.org>; Wed, 02 Aug 2023 16:26:19 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n jd20-20020a170903261400b001b8b0ac2258sm12960870plb.174.2023.08.02.16.26.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 02 Aug 2023 16:26:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691018779;\n x=1691623579;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=o3fitFnMFwJjHQQ+OUM16q78oYNignigqNhnyvERns4=;\n b=PdniutE7bQrXD0B5leS1knDT36RgfdF9LzqL5V0X3Qcom+0/vh8DTWW6e5TgIzxli7\n DUpaSwdwzm/7Im16ap6oIs2y+9sWcscL3EVdBK+hueuAffrb/OoqfYlIwIvLE6dcKk4f\n dbjsNpPfwZBz7OLHI+ALT5ibGJvo+BCN7hUhiM8/8IvAaQOOtnMMjN9OWzJKxBFiJFc4\n VQwhMnGDy3/rmsLnzGzpivY58nNfrv+ewXc7up+F270drCEXL5fhCY+fznIT1cQgQ20G\n edVLFsPrb7Am3/nZnsPrRq1Rsv5PaEhZEMqHd3AWVqvNrZx+DQZdIy1i0xxEVy8hsyt7\n 6qyw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691018779; x=1691623579;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=o3fitFnMFwJjHQQ+OUM16q78oYNignigqNhnyvERns4=;\n b=LIG/MISgylspFsy+4dcJUgB0g/SJmhcGM8zjhOkBt7wMh8Gx+7oJT+hb3jlhsc9r4y\n NCN1Tn5noDjCJqPlEN6/ODaMPXsr2d6MnNhHMqjBQs9jKj181vNow9pVxd0Ps3XOAVGx\n knDSkvce+xgRTlP49pZY2O8ThOzx5iTEKmpiPT3ZHJ72xlWEIOKVztM+7bKbrPv3/70T\n RDaW6njAVreE0Cv0exPkIhVgaIh36a9QabEWmzOHwD7UJamZQgxMQJ0DiBZl/NsI3gne\n KWHrGaZAXTk26OE8Hi6Noa4BGvIcUcZSJzbui7sPItSVnzUcMfAo3xX16CUJwCDDQzGU\n hkiQ==", "X-Gm-Message-State": "ABy/qLajt6zS0/0d8/c2C2bsaqANctg2RAwIdv2kUEXHbfYplKphcSPa\n QjjEkGLrAKnhzruaqCR4XRbcIeNTv7hlnhYI58gdib5l", "X-Google-Smtp-Source": "\n APBJJlGM66nBoklP0vnfa2pIv1MbhTiY2afmYy1nUjakicysQz0mPqOz+4SSTzvOtx/kYqMgIBi0NQ==", "X-Received": "by 2002:a17:902:e804:b0:1b8:3786:3344 with SMTP id\n u4-20020a170902e80400b001b837863344mr16971653plg.49.1691018778895;\n Wed, 02 Aug 2023 16:26:18 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>, Liron Himi <lironh@marvell.com>,\n Chaoyong He <chaoyong.he@corigine.com>,\n =?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>", "Subject": "[PATCH v4 19/19] drivers: remove use of term sanity check", "Date": "Wed, 2 Aug 2023 16:25:50 -0700", "Message-Id": "<20230802232550.125487-20-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230802232550.125487-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>\n <20230802232550.125487-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace non-inclusive language with better comments.\nCovers multiple drivers\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +-\n drivers/common/cnxk/roc_npa.c | 2 +-\n drivers/common/dpaax/caamflib/desc.h | 2 +-\n drivers/common/sfc_efx/base/ef10_nvram.c | 4 ++--\n drivers/common/sfc_efx/base/efx_rx.c | 2 +-\n drivers/dma/idxd/idxd_pci.c | 2 +-\n drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-\n drivers/net/mvpp2/mrvl_qos.c | 2 +-\n drivers/net/nfp/nfp_flow.c | 2 +-\n drivers/net/qede/qede_rxtx.c | 6 +++---\n 10 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\nindex caaae417773c..2b6162d0ceaf 100644\n--- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n+++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n@@ -9,7 +9,7 @@\n #include <compat.h>\n #include <fsl_qbman_base.h>\n \n-/* Sanity check */\n+/* Byte order check */\n #if (__BYTE_ORDER__ != __ORDER_BIG_ENDIAN__) && \\\n \t(__BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__)\n #error \"Unknown endianness!\"\ndiff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c\nindex e796878ba634..1db78631a185 100644\n--- a/drivers/common/cnxk/roc_npa.c\n+++ b/drivers/common/cnxk/roc_npa.c\n@@ -614,7 +614,7 @@ npa_aura_alloc(struct npa_lf *lf, const uint32_t block_count, int pool_id,\n {\n \tint rc, aura_id;\n \n-\t/* Sanity check */\n+\t/* parameter check */\n \tif (!lf || !aura || !aura_handle)\n \t\treturn NPA_ERR_PARAM;\n \ndiff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/caamflib/desc.h\nindex 635d6bad071f..feb6a5d7bb2d 100644\n--- a/drivers/common/dpaax/caamflib/desc.h\n+++ b/drivers/common/dpaax/caamflib/desc.h\n@@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era;\n \n /*\n * ONE - should always be set. Combination of ONE (always\n- * set) and ZRO (always clear) forms an endianness sanity check\n+ * set) and ZRO (always clear) forms an endianness check\n */\n #define HDR_ONE\t\t\tBIT(23)\n #define HDR_ZRO\t\t\tBIT(15)\ndiff --git a/drivers/common/sfc_efx/base/ef10_nvram.c b/drivers/common/sfc_efx/base/ef10_nvram.c\nindex ce8357fa94ce..fad9f0f507f3 100644\n--- a/drivers/common/sfc_efx/base/ef10_nvram.c\n+++ b/drivers/common/sfc_efx/base/ef10_nvram.c\n@@ -595,13 +595,13 @@ tlv_update_partition_len_and_cks(\n \n \t/*\n \t * We just modified the partition, so the total length may not be\n-\t * valid. Don't use tlv_find(), which performs some sanity checks\n+\t * valid. Don't use tlv_find(), which performs some checks\n \t * that may fail here.\n \t */\n \tpartition.data = cursor->block;\n \tmemcpy(&partition.tlv_cursor, cursor, sizeof (*cursor));\n \theader = (struct tlv_partition_header *)partition.data;\n-\t/* Sanity check. */\n+\t/* Header check */\n \tif (__LE_TO_CPU_32(header->tag) != TLV_TAG_PARTITION_HEADER) {\n \t\trc = EFAULT;\n \t\tgoto fail1;\ndiff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c\nindex dce9ada55d28..28676c5a5b99 100644\n--- a/drivers/common/sfc_efx/base/efx_rx.c\n+++ b/drivers/common/sfc_efx/base/efx_rx.c\n@@ -930,7 +930,7 @@ efx_rx_qcreate_internal(\n \t ndescs, id, flags, eep, erp)) != 0)\n \t\tgoto fail4;\n \n-\t/* Sanity check queue creation result */\n+\t/* Check queue creation result */\n \tif (flags & EFX_RXQ_FLAG_RSS_HASH) {\n \t\tconst efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout;\n \t\tconst efx_rx_prefix_field_info_t *rss_hash_field;\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 3696c7f452fc..633065aa4577 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -196,7 +196,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,\n \tpci->portals = dev->mem_resource[2].addr;\n \tpci->wq_cfg_sz = (pci->regs->wqcap >> 24) & 0x0F;\n \n-\t/* sanity check device status */\n+\t/* check device status */\n \tif (pci->regs->gensts & GENSTS_DEV_STATE_MASK) {\n \t\t/* need function-level-reset (FLR) or is enabled */\n \t\tIDXD_PMD_ERR(\"Device status is not disabled, cannot init\");\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 4a266bb2caf1..56972f06c045 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -1477,7 +1477,7 @@ bond_8023ad_setup_validate(uint16_t port_id,\n \t\treturn -EINVAL;\n \n \tif (conf != NULL) {\n-\t\t/* Basic sanity check */\n+\t\t/* Basic input check */\n \t\tif (conf->slow_periodic_ms == 0 ||\n \t\t\t\tconf->fast_periodic_ms >= conf->slow_periodic_ms ||\n \t\t\t\tconf->long_timeout_ms == 0 ||\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex f43217bc589c..db5052a9ab6f 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab,\n \t\t\tif (nb_rng_tokens != 2)\n \t\t\t\treturn -3;\n \n-\t\t\t/* Range and sanity checks. */\n+\t\t\t/* Range and input checks. */\n \t\t\tif (get_val_securely(rng_tokens[0], &token_val) < 0)\n \t\t\t\treturn -4;\n \t\t\tbeg = (char)token_val;\ndiff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c\nindex 3ed78eab5706..6342d6cbfbd0 100644\n--- a/drivers/net/nfp/nfp_flow.c\n+++ b/drivers/net/nfp/nfp_flow.c\n@@ -1956,7 +1956,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr,\n \t\t\tbreak;\n \t\t}\n \n-\t\t/* Perform basic sanity checks */\n+\t\t/* Perform basic checks */\n \t\tret = nfp_flow_item_check(item, proc);\n \t\tif (ret != 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"nfp flow item %d check failed\", item->type);\ndiff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c\nindex c35585f5fdd6..8b89841e03b1 100644\n--- a/drivers/net/qede/qede_rxtx.c\n+++ b/drivers/net/qede/qede_rxtx.c\n@@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev,\n \t\t\t\t\t cqe->len_list[0]);\n \t/* Update total length and frags based on end TPA */\n \trx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head;\n-\t/* TODO: Add Sanity Checks */\n+\t/* TODO: Add more checks */\n \trx_mb->nb_segs = cqe->num_of_bds;\n \trx_mb->pkt_len = cqe->total_packet_len;\n \n@@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,\n \n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n static inline void\n-qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf,\n+qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf,\n \t\t\t struct qede_tx_queue *txq)\n {\n \tif (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff)\n@@ -2473,7 +2473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_MPLSINUDP) {\n \t\t\t\tmplsoudp_flg = true;\n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n-\t\t\t\tqede_mpls_tunn_tx_sanity_check(mbuf, txq);\n+\t\t\t\tqede_mpls_tunn_tx_basic_check(mbuf, txq);\n #endif\n \t\t\t\t/* Outer L4 offset in two byte words */\n \t\t\t\ttunn_l4_hdr_start_offset =\n", "prefixes": [ "v4", "19/19" ] }