Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129935/?format=api
{ "id": 129935, "url": "http://patchwork.dpdk.org/api/patches/129935/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230807133601.164018-1-tshmilovich@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230807133601.164018-1-tshmilovich@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230807133601.164018-1-tshmilovich@nvidia.com", "date": "2023-08-07T13:36:01", "name": "[RFC] ethdev: add group set miss actions API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "478daf1f2ef2447ad698154c1c88984a7d204394", "submitter": { "id": 3144, "url": "http://patchwork.dpdk.org/api/people/3144/?format=api", "name": "Tomer Shmilovich", "email": "tshmilovich@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230807133601.164018-1-tshmilovich@nvidia.com/mbox/", "series": [ { "id": 29123, "url": "http://patchwork.dpdk.org/api/series/29123/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29123", "date": "2023-08-07T13:36:01", "name": "[RFC] ethdev: add group set miss actions API", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29123/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129935/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129935/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D97B542FFE;\n\tMon, 7 Aug 2023 15:37:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 64D22410D3;\n\tMon, 7 Aug 2023 15:37:04 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49])\n by mails.dpdk.org (Postfix) with ESMTP id 4237540A8B\n for <dev@dpdk.org>; Mon, 7 Aug 2023 15:37:02 +0200 (CEST)", "from MW4PR04CA0362.namprd04.prod.outlook.com (2603:10b6:303:81::7)\n by DM4PR12MB6399.namprd12.prod.outlook.com (2603:10b6:8:b7::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug\n 2023 13:36:57 +0000", "from MWH0EPF000971E2.namprd02.prod.outlook.com\n (2603:10b6:303:81:cafe::78) by MW4PR04CA0362.outlook.office365.com\n (2603:10b6:303:81::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend\n Transport; Mon, 7 Aug 2023 13:36:59 +0000", "from mail.nvidia.com (216.228.117.161) by\n MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6652.20 via Frontend Transport; Mon, 7 Aug 2023 13:36:59 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 7 Aug 2023\n 06:36:31 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 7 Aug 2023\n 06:36:29 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NbLIeGW47oyHss4H/HUVk0kAytEotLunI5viHtlP0oL/JS6kIVKf4ZdNb3zJzlKd/kk5PYVFIS1XukCiEysLVBCeZI27WrJopvoJMFWJJAGKfP3xQ38Bj3sSyowt5SCCa0KkN/yqjNyHv6y7W3ixz4o1yuMtk1VLI+lkmLZUG/AMhvEV1YfLlQLXcwLkZlRwomVQK17cgwVypf6eZtZfXPDg33r5hkCUb9j834hMql9lq/gTrL4LESpXnxNwbIapJaKwJIfEtpZZsa/GpBuWaRGkhW8LnQgjQrWqw6WEYwQob/D+93fE6eXRMLr6xGPbYJ+bAkZEW3XI78dEqzZ+ng==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6bWF9xKIdiR0gBaNLLH2S3f9Q8Hz1+c+scdR5LRTQXA=;\n b=eP9k68I1x88YC1Xc2QmIfsGX/gjT6G3NuCL1uDCLVNNbsk0P5NRsXldZaAmDYaR1rzYjQnKjIjJ8Ot5CCy5F/Z5JDi/yndoCMu2siY2JL/FH0qrLRAUeCNNj5k02DiOHfPYV0Ff9lxBiGMOyeC4QJrPUYD2XvD66dX1XTO/dvXf5kQIK0EPslwjHfarF2cgUPlyeMrHoc/7QWztHH/J5Ux+JmTI7poHFHWQERvq5CPQNgr+QNzv4xJChf4i/HJnTIH8m1hB6atdXV8pk2gQ1cBVjYDgXDEKIJrt1Qfs5KMDRk3O+mqLNzm8JEg4MtVq+NLmqbOTAp+7nNuvfAnFV3A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6bWF9xKIdiR0gBaNLLH2S3f9Q8Hz1+c+scdR5LRTQXA=;\n b=MnYeM47jjbsWOpN1FORW8IZz4Uimj0NyoeEFsnoHd8GzOkZigfcSeX4r9hemNZPc+v/MkxLdGTizJtXXG/mqAH++Lml6PAAF27vsnjGiu4qt30fl9HIAJIpa7BCK51e7+JTQrmvD6FqvEi2yY3J6MUwuBfpUZLjonC6gHwwU4Xi5GiBr8+N2a5fKqXOzETOeQsfEuzci2jRKasjFUxzqJoYAVNhNNp3MXZWui1sXVBsCPWAKHr5zsZLmiTO6S7Is+wN8ll6o4qWW/eBfUraIDCbuDDP76YMA1I0vLi+7581q5rlCHDGXAfzDD7S2L2BfElG76ERMrQJxV9ZIzSoy9Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Tomer Shmilovich <tshmilovich@nvidia.com>", "To": "Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, \"Ferruh\n Yigit\" <ferruh.yigit@amd.com>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>", "Subject": "[RFC] ethdev: add group set miss actions API", "Date": "Mon, 7 Aug 2023 13:36:01 +0000", "Message-ID": "<20230807133601.164018-1-tshmilovich@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MWH0EPF000971E2:EE_|DM4PR12MB6399:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3d2fa523-4b81-469f-8ed9-08db974b6054", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n te+qDhjqaH5pkeFn8d6z5nVlODjtVjLPnBBXFhwRyOh9bqVJzn1N1RYyXbWs/dOogAHooHSgUYnLhWIbpP18n3rHhWvrpBXd4HgMKPNtql7FxtzUaVzE588xomG7XKoe0OZH1elac4xWFCcoIU8lRvvdSeLhnn5LPJXIdiCj0ztILTiC3Nl0bA1/cPYcXcSrWGLxnDvFx2izwPkofGFq9aaICD4E/1tHwS0pRPAYwvRihjrPN64HgMAWM38QB9BbCFu4TY4KNjxrkmLRMFnoLp9m3+I93dkupS2FAubBZQc79EQ816LDeKjvGAGF7+LoTMHkFSWVlOGw8eaHJ+eAdo9iFnU9kn3VpigJvfkOc3sXjoXDh8k4llYjj2o9mB4wvc6MH9VwtCW3Ss4loamfuDnKAqvj/8A7qTJW4se9WIBtZcFqagGtOzh08cuhY27iPJ8XBXxCIckom61W5ztmp8pMmkPPW6iKMXDg3AAkTpMOtju/amaEFpnFnRc34HGaOr6S+mSAI5e1vYAbSvGAd9Ol78iKUB2epcHt1cteLC5BtNesytc35W7lEAArAzIpeoyw7w/lNUIrz4xri6yxblO5z76smFsw8Rwg3Bm6FJXTAcb4gBqZDc6WUymL5kQFJp51Ojl3gOj41jZIXohTshfa7bvbue0gLO91S9LJ/MJlpINqu2YWWguRhS9MdyZ+m8U1VVx56t/8yUghvTimmJlTRGSUebR/vn8lfsjt61RTZZ9ifY/d94DlnYViBGSm", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(1800799003)(186006)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(83380400001)(426003)(47076005)(36860700001)(2616005)(40460700003)(55016003)(40480700001)(110136005)(2906002)(4326008)(8936002)(316002)(5660300002)(8676002)(336012)(70586007)(70206006)(6286002)(16526019)(86362001)(478600001)(82740400003)(6666004)(7636003)(7696005)(356005)(41300700001)(36756003)(1076003)(26005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Aug 2023 13:36:59.6146 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3d2fa523-4b81-469f-8ed9-08db974b6054", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MWH0EPF000971E2.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB6399", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Introduce new group set miss actions API:\nrte_flow_group_set_miss_actions().\n\nA group's miss actions are a set of actions to be performed\nin case of a miss on a group, i.e. when a packet didn't hit any flow\nrules in the group.\n\nCurrently, the expected behavior in this case is undefined.\nIn order to achieve such functionality, a user can add a flow rule\nthat matches on all traffic with the lowest priority in the group -\nthis is not explicit however, and can be overridden by another flow rule\nwith a lower priority.\n\nThis new API function allows a user to set a group's miss actions in an\nexplicit way.\n\nSigned-off-by: Tomer Shmilovich <tshmilovich@nvidia.com>\n---\n doc/guides/prog_guide/rte_flow.rst | 30 +++++++++++++++++++++++++\n lib/ethdev/rte_flow.c | 22 +++++++++++++++++++\n lib/ethdev/rte_flow.h | 35 ++++++++++++++++++++++++++++++\n lib/ethdev/rte_flow_driver.h | 7 ++++++\n lib/ethdev/version.map | 3 +++\n 5 files changed, 97 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex 5bc998a433..590d2a770e 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -3758,6 +3758,36 @@ Information about the number of available resources can be retrieved via\n struct rte_flow_queue_info *queue_info,\n struct rte_flow_error *error);\n \n+Group Miss Actions\n+~~~~~~~~~~~~~~~~~~\n+\n+In an application, many flow rules share common group attributes, meaning they can be grouped and\n+classified together. A user can explicitly specify a set of actions performed on a packet when it\n+did not match any flows rules in a group using the following API:\n+\n+.. code-block:: c\n+\n+ int\n+ rte_flow_group_set_miss_actions(uint16_t port_id,\n+ uint32_t group_id,\n+ const struct rte_flow_group_attr *attr,\n+ const struct rte_flow_action actions[],\n+ struct rte_flow_error *error);\n+\n+For example, to configure a RTE_FLOW_TYPE_JUMP action as a miss action for ingress group 1:\n+\n+.. code-block:: c\n+\n+ struct rte_flow_group_attr attr = {.ingress = 1};\n+ struct rte_flow_action act[] = {\n+ /* Setting miss actions to jump to group 3 */\n+ [0] = {.type = RTE_FLOW_ACTION_TYPE_JUMP,\n+ .conf = &(struct rte_flow_action_jump){.group = 3}},\n+ [1] = {.type = RTE_FLOW_ACTION_TYPE_END},\n+ };\n+ struct rte_flow_error err;\n+ rte_flow_group_set_miss_actions(port, 1, &attr, act, &err);\n+\n Flow templates\n ~~~~~~~~~~~~~~\n \ndiff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c\nindex 271d854f78..a98d87265f 100644\n--- a/lib/ethdev/rte_flow.c\n+++ b/lib/ethdev/rte_flow.c\n@@ -1973,6 +1973,28 @@ rte_flow_template_table_destroy(uint16_t port_id,\n \t\t\t\t NULL, rte_strerror(ENOTSUP));\n }\n \n+int\n+rte_flow_group_set_miss_actions(uint16_t port_id,\n+\t\t\t\tuint32_t group_id,\n+\t\t\t\tconst struct rte_flow_group_attr *attr,\n+\t\t\t\tconst struct rte_flow_action actions[],\n+\t\t\t\tstruct rte_flow_error *error)\n+{\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\tconst struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);\n+\n+\tif (unlikely(!ops))\n+\t\treturn -rte_errno;\n+\tif (likely(!!ops->group_set_miss_actions)) {\n+\t\treturn flow_err(port_id,\n+\t\t\t\tops->group_set_miss_actions(dev, group_id, attr, actions, error),\n+\t\t\t\terror);\n+\t}\n+\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t NULL, rte_strerror(ENOTSUP));\n+}\n+\n struct rte_flow *\n rte_flow_async_create(uint16_t port_id,\n \t\t uint32_t queue_id,\ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex 86ed98c562..2d4fd49eb7 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -129,6 +129,12 @@ struct rte_flow_attr {\n \tuint32_t reserved:29; /**< Reserved, must be zero. */\n };\n \n+struct rte_flow_group_attr {\n+\tuint32_t ingress:1;\n+\tuint32_t egress:1;\n+\tuint32_t transfer:1;\n+};\n+\n /**\n * Matching pattern item types.\n *\n@@ -5839,6 +5845,35 @@ rte_flow_template_table_destroy(uint16_t port_id,\n \t\tstruct rte_flow_template_table *template_table,\n \t\tstruct rte_flow_error *error);\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Set group miss actions.\n+ *\n+ * @param port_id\n+ * Port identifier of Ethernet device.\n+ * @param group_id\n+ * Identifier of a group to set miss actions for.\n+ * @param attr\n+ * Group attributes.\n+ * @param actions\n+ * List of group miss actions.\n+ * @param[out] error\n+ * Perform verbose error reporting if not NULL.\n+ * PMDs initialize this structure in case of error only.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+__rte_experimental\n+int\n+rte_flow_group_set_miss_actions(uint16_t port_id,\n+\t\t\t\tuint32_t group_id,\n+\t\t\t\tconst struct rte_flow_group_attr *attr,\n+\t\t\t\tconst struct rte_flow_action actions[],\n+\t\t\t\tstruct rte_flow_error *error);\n+\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice.\ndiff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h\nindex f9fb01b8a2..3ced086c47 100644\n--- a/lib/ethdev/rte_flow_driver.h\n+++ b/lib/ethdev/rte_flow_driver.h\n@@ -227,6 +227,13 @@ struct rte_flow_ops {\n \t\t(struct rte_eth_dev *dev,\n \t\t struct rte_flow_template_table *template_table,\n \t\t struct rte_flow_error *err);\n+\t/** See rte_flow_group_set_miss_actions() */\n+\tint (*group_set_miss_actions)\n+\t\t(struct rte_eth_dev *dev,\n+\t\t uint32_t group_id,\n+\t\t const struct rte_flow_group_attr *attr,\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *err);\n \t/** See rte_flow_async_create() */\n \tstruct rte_flow *(*async_create)\n \t\t(struct rte_eth_dev *dev,\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex fc492ee839..bdd41ecb5e 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -312,6 +312,9 @@ EXPERIMENTAL {\n \trte_flow_async_action_list_handle_query_update;\n \trte_flow_async_actions_update;\n \trte_flow_restore_info_dynflag;\n+\n+\t# added in 23.11\n+\trte_flow_group_set_miss_actions;\n };\n \n INTERNAL {\n", "prefixes": [ "RFC" ] }