Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129976/?format=api
{ "id": 129976, "url": "http://patchwork.dpdk.org/api/patches/129976/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809001017.293037-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809001017.293037-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809001017.293037-12-stephen@networkplumber.org", "date": "2023-08-09T00:09:59", "name": "[v2,11/29] hash: remove experimental from toeplitz hash", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "131fe586a30f10f6b64bd98c76f129d2f8c5519c", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809001017.293037-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 29134, "url": "http://patchwork.dpdk.org/api/series/29134/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29134", "date": "2023-08-09T00:09:48", "name": "promote many API's to stable", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29134/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129976/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/129976/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D221743011;\n\tWed, 9 Aug 2023 02:11:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A0F5E43291;\n\tWed, 9 Aug 2023 02:10:44 +0200 (CEST)", "from mail-pj1-f41.google.com (mail-pj1-f41.google.com\n [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 047964327E\n for <dev@dpdk.org>; Wed, 9 Aug 2023 02:10:40 +0200 (CEST)", "by mail-pj1-f41.google.com with SMTP id\n 98e67ed59e1d1-26928c430b2so2558390a91.0\n for <dev@dpdk.org>; Tue, 08 Aug 2023 17:10:39 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n ix11-20020a170902f80b00b001bc676df6a9sm5745629plb.132.2023.08.08.17.10.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 08 Aug 2023 17:10:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691539839;\n x=1692144639;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=t5AlA7nzhd4H83EJnT5N/ejWXLuEBGaE6gYS/1Ocb3g=;\n b=G2po8ib3uF67ODHJX3oPZut5FhF7G0MuMbOXYJ58/LlvHz4FChwiM+7hCHuaSxA3j3\n 0z5nYltY1gzMKnWdO0+8B4p4LBj2+Vjz1nh55viTTAiBFn1HGX9jN4smrWiIoMk6iYRY\n Fgp80JCFaPMYKaV7zg/YH85jnqkD9zFIcSgXuusajbO9BmQacz1HhsaJv2ltrRefbBV9\n cXoHSEE/pC8lzJqEvwQ/VLuItRlpInwbr/5khExdv7dsTyR0icRkd7UKAACapZ7bh8V5\n 5CaZ6q6Zdz8TfwPFo0OQAiUAjERfcOW6cPje2WTirHgTdIcgoA/5RWi3BE70QjH2R0IR\n AdrQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691539839; x=1692144639;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=t5AlA7nzhd4H83EJnT5N/ejWXLuEBGaE6gYS/1Ocb3g=;\n b=LwUmwfvMDHkl81CjkbT6i7abedrfFGcPlpv3rXVcsAZamhscHaazCbf0nnUQpuVPuT\n AQICwdNna9SBY4ejN/7tPZlN85uViF0tnQ/Y64ATzTUVoWmRrTSDCLM1rIZgNEajxA+u\n zyCCTeVwCMEtunkmY/LHUb4x4HmhwPuNQ9VgUCgSLXe5xPZ6u3H3PxAJfnzGMEO5kiWv\n e2+9PBp7862fpG35SM+gnVgJZAw8c3TECzt8s60PQqm2CtnPbkBUTR0LTnWtxB6hCL1l\n M8E2C1D7WVCSJKIUe0WvsC5XmZ8I1+o4enS4wyY4ItiGj/rxJirJIF4x8MZDBX3KeOXg\n NZyQ==", "X-Gm-Message-State": "AOJu0Yx4z+x1Eq1H3iceUE8Oxvuf1KiAhLndH+t0fwTZTtPtxTIlFSU5\n yrQyEI2KRLzDKp5zEH+fN7pGYOgw8uyG/q3A4U5E8A==", "X-Google-Smtp-Source": "\n AGHT+IHT17ZESbkycYNXh72gRKlz0NC9zfRY4RyAcZm4S0YqOjKoTgRv8nnGoH5/ZqGh7LutFeEZLw==", "X-Received": "by 2002:a17:90a:5646:b0:269:13f0:4b9a with SMTP id\n d6-20020a17090a564600b0026913f04b9amr927251pji.7.1691539838901;\n Tue, 08 Aug 2023 17:10:38 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH v2 11/29] hash: remove experimental from toeplitz hash", "Date": "Tue, 8 Aug 2023 17:09:59 -0700", "Message-Id": "<20230809001017.293037-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230809001017.293037-1-stephen@networkplumber.org>", "References": "<20230808173527.186042-1-stephen@networkplumber.org>\n <20230809001017.293037-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_thash_ functions have been around since 2020.\nRemove experimental tag.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/hash/rte_thash.h | 44 -----------------------------------\n lib/hash/rte_thash_gfni.h | 8 -------\n lib/hash/rte_thash_x86_gfni.h | 8 -------\n lib/hash/version.map | 16 ++++---------\n 4 files changed, 4 insertions(+), 72 deletions(-)", "diff": "diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h\nindex 7b1d1547863e..84673c06762c 100644\n--- a/lib/hash/rte_thash.h\n+++ b/lib/hash/rte_thash.h\n@@ -223,14 +223,10 @@ rte_softrss_be(uint32_t *input_tuple, uint32_t input_len,\n /**\n * Indicates if GFNI implementations of the Toeplitz hash are supported.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @return\n * 1 if GFNI is supported\n * 0 otherwise\n */\n-__rte_experimental\n int\n rte_thash_gfni_supported(void);\n \n@@ -238,9 +234,6 @@ rte_thash_gfni_supported(void);\n * Converts Toeplitz hash key (RSS key) into matrixes required\n * for GFNI implementation\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param matrixes\n * pointer to the memory where matrices will be written.\n * Note: the size of this memory must be equal to size * 8\n@@ -249,7 +242,6 @@ rte_thash_gfni_supported(void);\n * @param size\n * Size of the rss_key in bytes.\n */\n-__rte_experimental\n void\n rte_thash_complete_matrix(uint64_t *matrixes, const uint8_t *rss_key,\n \tint size);\n@@ -278,9 +270,6 @@ struct rte_thash_subtuple_helper;\n /**\n * Create a new thash context.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param name\n * Context name\n * @param key_len\n@@ -300,7 +289,6 @@ struct rte_thash_subtuple_helper;\n * A pointer to the created context on success\n * NULL otherwise\n */\n-__rte_experimental\n struct rte_thash_ctx *\n rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n \tuint8_t *key, uint32_t flags);\n@@ -308,9 +296,6 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n /**\n * Find an existing thash context and return a pointer to it.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param name\n * Name of the thash context\n * @return\n@@ -318,20 +303,15 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n * set appropriately. Possible rte_errno values include:\n * - ENOENT - required entry not available to return.\n */\n-__rte_experimental\n struct rte_thash_ctx *\n rte_thash_find_existing(const char *name);\n \n /**\n * Free a thash context object\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n */\n-__rte_experimental\n void\n rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n \n@@ -341,9 +321,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n * to calculate toeplitz hash collisions.\n * This function is not multi-thread safe.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param name\n@@ -357,7 +334,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n * 0 on success\n * negative on error\n */\n-__rte_experimental\n int\n rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n \tuint32_t offset);\n@@ -365,9 +341,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n /**\n * Find a helper in the context by the given name\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param name\n@@ -375,7 +348,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n * @return\n * Pointer to the thash helper or NULL if it was not found.\n */\n-__rte_experimental\n struct rte_thash_subtuple_helper *\n rte_thash_get_helper(struct rte_thash_ctx *ctx, const char *name);\n \n@@ -394,7 +366,6 @@ rte_thash_get_helper(struct rte_thash_ctx *ctx, const char *name);\n * @return\n * A complementary value which must be xored with the corresponding subtuple\n */\n-__rte_experimental\n uint32_t\n rte_thash_get_complement(struct rte_thash_subtuple_helper *h,\n \tuint32_t hash, uint32_t desired_hash);\n@@ -404,15 +375,11 @@ rte_thash_get_complement(struct rte_thash_subtuple_helper *h,\n * It changes after each addition of a helper. It should be installed to\n * the NIC.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @return\n * A pointer to the toeplitz hash key\n */\n-__rte_experimental\n const uint8_t *\n rte_thash_get_key(struct rte_thash_ctx *ctx);\n \n@@ -422,16 +389,12 @@ rte_thash_get_key(struct rte_thash_ctx *ctx);\n * CPU supports GFNI.\n * Matrices changes after each addition of a helper.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @return\n * A pointer to the toeplitz hash key matrices on success\n * NULL if GFNI is not supported.\n */\n-__rte_experimental\n const uint64_t *\n rte_thash_get_gfni_matrices(struct rte_thash_ctx *ctx);\n \n@@ -441,9 +404,6 @@ rte_thash_get_gfni_matrices(struct rte_thash_ctx *ctx);\n * Generally it is some kind of lookup function to check\n * if adjusted tuple is already in use.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param userdata\n * Pointer to the userdata. It could be a pointer to the\n * table with used tuples to search.\n@@ -461,9 +421,6 @@ typedef int (*rte_thash_check_tuple_t)(void *userdata, uint8_t *tuple);\n * desired least significant bits.\n * This function is multi-thread safe.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param h\n@@ -485,7 +442,6 @@ typedef int (*rte_thash_check_tuple_t)(void *userdata, uint8_t *tuple);\n * 0 on success\n * negative otherwise\n */\n-__rte_experimental\n int\n rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,\n \tstruct rte_thash_subtuple_helper *h,\ndiff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h\nindex ef90faa302d1..67d0fa4da988 100644\n--- a/lib/hash/rte_thash_gfni.h\n+++ b/lib/hash/rte_thash_gfni.h\n@@ -24,9 +24,6 @@ extern \"C\" {\n * Calculate Toeplitz hash.\n * Dummy implementation.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -37,7 +34,6 @@ extern \"C\" {\n * @return\n * Calculated Toeplitz hash value.\n */\n-__rte_experimental\n static inline uint32_t\n rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n \tconst uint8_t *key __rte_unused, int len __rte_unused)\n@@ -50,9 +46,6 @@ rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n * Bulk implementation for Toeplitz hash.\n * Dummy implementation.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -66,7 +59,6 @@ rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n * @param num\n * Number of tuples to hash.\n */\n-__rte_experimental\n static inline void\n rte_thash_gfni_bulk(const uint64_t *mtrx __rte_unused,\n \tint len __rte_unused, uint8_t *tuple[] __rte_unused,\ndiff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h\nindex 7bb76ac1bb5f..f263c1eeec06 100644\n--- a/lib/hash/rte_thash_x86_gfni.h\n+++ b/lib/hash/rte_thash_x86_gfni.h\n@@ -161,9 +161,6 @@ __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,\n /**\n * Calculate Toeplitz hash.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -175,7 +172,6 @@ __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,\n * @return\n * Calculated Toeplitz hash value.\n */\n-__rte_experimental\n static inline uint32_t\n rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n {\n@@ -190,9 +186,6 @@ rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n /**\n * Bulk implementation for Toeplitz hash.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -207,7 +200,6 @@ rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n * @param num\n * Number of tuples to hash.\n */\n-__rte_experimental\n static inline void\n rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],\n \tuint32_t val[], uint32_t num)\ndiff --git a/lib/hash/version.map b/lib/hash/version.map\nindex daaa9a8901db..b98b64a1638a 100644\n--- a/lib/hash/version.map\n+++ b/lib/hash/version.map\n@@ -30,25 +30,17 @@ DPDK_24 {\n \trte_hash_rcu_qsbr_add;\n \trte_hash_reset;\n \trte_hash_set_cmp_func;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n-\t# added in 21.05\n \trte_thash_add_helper;\n \trte_thash_adjust_tuple;\n+\trte_thash_complete_matrix;\n \trte_thash_find_existing;\n \trte_thash_free_ctx;\n \trte_thash_get_complement;\n+\trte_thash_get_gfni_matrices;\n \trte_thash_get_helper;\n \trte_thash_get_key;\n+\trte_thash_gfni_supported;\n \trte_thash_init_ctx;\n \n-\t# added in 21.11\n-\trte_thash_complete_matrix;\n-\trte_thash_get_gfni_matrices;\n-\trte_thash_gfni_supported;\n+\tlocal: *;\n };\n", "prefixes": [ "v2", "11/29" ] }