Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130004/?format=api
{ "id": 130004, "url": "http://patchwork.dpdk.org/api/patches/130004/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809013308.1449103-11-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809013308.1449103-11-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809013308.1449103-11-wenjing.qiao@intel.com", "date": "2023-08-09T01:33:04", "name": "[10/14] common/idpf/base: use 'void' return type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "69c88142a4b824ea16de6d4ccab89f79476e1028", "submitter": { "id": 2680, "url": "http://patchwork.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809013308.1449103-11-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 29135, "url": "http://patchwork.dpdk.org/api/series/29135/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29135", "date": "2023-08-09T01:32:54", "name": "update idpf base code", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29135/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130004/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130004/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DEC9043011;\n\tWed, 9 Aug 2023 03:34:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 30DC84327C;\n\tWed, 9 Aug 2023 03:33:50 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 8816143255\n for <dev@dpdk.org>; Wed, 9 Aug 2023 03:33:48 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Aug 2023 18:33:48 -0700", "from dpdk-wenjing-02.sh.intel.com ([10.67.119.75])\n by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2023 18:33:45 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1691544828; x=1723080828;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=VDbyNaUO5GhvsEFsXsFjma1dse4hOcuq0fAJbv8pmX4=;\n b=WtlHabM1trNUtyNyufXlpD6VtIjnszGi2SfkLTQK8g9eGtOw6tXL/jL+\n DOC+VYHyvoVcPC2a8R4aj6z0yBdT39BZerpRYHEqRpwedLWIyotNRF3KI\n N3qvjIHcV+zrLOmgZFdRk25KlWHTNEBppEp/dNLMOrB+WzuhgZ6NJlwFy\n Xd3xBO9BCvuBCPrW6bZGFwtP9kZ62dlm/67fEzSFSVc43bmn6Oc4Ib93Y\n hNXlUC46j1jDxmV0Lp5x/Wxx+gNHWG/m8Am8irnE1sXpAwF3/X1jyaQ19\n BJEh4COZrzd/d4gAb19DvFQLrq+KMLyM8iLDDLt78Fp9uNIIUPZBLKgS4 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10795\"; a=\"374704507\"", "E=Sophos;i=\"6.01,157,1684825200\"; d=\"scan'208\";a=\"374704507\"", "E=McAfee;i=\"6600,9927,10795\"; a=\"845735143\"", "E=Sophos;i=\"6.01,157,1684825200\"; d=\"scan'208\";a=\"845735143\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com,\n Simei Su <simei.su@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH 10/14] common/idpf/base: use 'void' return type", "Date": "Wed, 9 Aug 2023 01:33:04 +0000", "Message-Id": "<20230809013308.1449103-11-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230809013308.1449103-1-wenjing.qiao@intel.com>", "References": "<20230809013308.1449103-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Simei Su <simei.su@intel.com>\n\nAs idpf_ctlq_deinit always returns success, make it 'void' instead\nof returning only success. This also changes the return type for\nidpf_deinit_hw as 'void'.\n\nBased on the upstream comments, explicit __le16 typecasting is not\nnecessary as CPU_TO_LE16 is already being used.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/common/idpf/base/idpf_common.c | 4 ++--\n drivers/common/idpf/base/idpf_controlq.c | 7 ++-----\n drivers/common/idpf/base/idpf_controlq_api.h | 2 +-\n drivers/common/idpf/base/idpf_prototype.h | 2 +-\n 4 files changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c\nindex 9610916aa9..7181a7f14c 100644\n--- a/drivers/common/idpf/base/idpf_common.c\n+++ b/drivers/common/idpf/base/idpf_common.c\n@@ -262,12 +262,12 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n * idpf_deinit_hw - shutdown routine\n * @hw: pointer to the hardware structure\n */\n-int idpf_deinit_hw(struct idpf_hw *hw)\n+void idpf_deinit_hw(struct idpf_hw *hw)\n {\n \thw->asq = NULL;\n \thw->arq = NULL;\n \n-\treturn idpf_ctlq_deinit(hw);\n+\tidpf_ctlq_deinit(hw);\n }\n \n /**\ndiff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c\nindex b84a1ea046..7b12dfab18 100644\n--- a/drivers/common/idpf/base/idpf_controlq.c\n+++ b/drivers/common/idpf/base/idpf_controlq.c\n@@ -75,7 +75,7 @@ static void idpf_ctlq_init_rxq_bufs(struct idpf_ctlq_info *cq)\n \t\tdesc->flags =\n \t\t\tCPU_TO_LE16(IDPF_CTLQ_FLAG_BUF | IDPF_CTLQ_FLAG_RD);\n \t\tdesc->opcode = 0;\n-\t\tdesc->datalen = (__le16)CPU_TO_LE16(bi->size);\n+\t\tdesc->datalen = CPU_TO_LE16(bi->size);\n \t\tdesc->ret_val = 0;\n \t\tdesc->cookie_high = 0;\n \t\tdesc->cookie_low = 0;\n@@ -264,16 +264,13 @@ int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q,\n * idpf_ctlq_deinit - destroy all control queues\n * @hw: pointer to hw struct\n */\n-int idpf_ctlq_deinit(struct idpf_hw *hw)\n+void idpf_ctlq_deinit(struct idpf_hw *hw)\n {\n \tstruct idpf_ctlq_info *cq = NULL, *tmp = NULL;\n-\tint ret_code = 0;\n \n \tLIST_FOR_EACH_ENTRY_SAFE(cq, tmp, &hw->cq_list_head,\n \t\t\t\t idpf_ctlq_info, cq_list)\n \t\tidpf_ctlq_remove(hw, cq);\n-\n-\treturn ret_code;\n }\n \n /**\ndiff --git a/drivers/common/idpf/base/idpf_controlq_api.h b/drivers/common/idpf/base/idpf_controlq_api.h\nindex f4e7b53ac9..78a54f6b4c 100644\n--- a/drivers/common/idpf/base/idpf_controlq_api.h\n+++ b/drivers/common/idpf/base/idpf_controlq_api.h\n@@ -205,6 +205,6 @@ int idpf_ctlq_post_rx_buffs(struct idpf_hw *hw,\n \t\t\t struct idpf_dma_mem **buffs);\n \n /* Will destroy all q including the default mb */\n-int idpf_ctlq_deinit(struct idpf_hw *hw);\n+void idpf_ctlq_deinit(struct idpf_hw *hw);\n \n #endif /* _IDPF_CONTROLQ_API_H_ */\ndiff --git a/drivers/common/idpf/base/idpf_prototype.h b/drivers/common/idpf/base/idpf_prototype.h\nindex 988ff00506..e2f090a9e3 100644\n--- a/drivers/common/idpf/base/idpf_prototype.h\n+++ b/drivers/common/idpf/base/idpf_prototype.h\n@@ -20,7 +20,7 @@\n #define APF\n \n int idpf_init_hw(struct idpf_hw *hw, struct idpf_ctlq_size ctlq_size);\n-int idpf_deinit_hw(struct idpf_hw *hw);\n+void idpf_deinit_hw(struct idpf_hw *hw);\n \n int idpf_clean_arq_element(struct idpf_hw *hw,\n \t\t\t struct idpf_arq_event_info *e,\n", "prefixes": [ "10/14" ] }