Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130011/?format=api
{ "id": 130011, "url": "http://patchwork.dpdk.org/api/patches/130011/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809050700.271534-3-simei.su@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809050700.271534-3-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809050700.271534-3-simei.su@intel.com", "date": "2023-08-09T05:06:59", "name": "[2/3] examples/ptpclient: refine application", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7d3d50aefa28d03fc68981fbe1c39b34cbaf4c1c", "submitter": { "id": 1298, "url": "http://patchwork.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809050700.271534-3-simei.su@intel.com/mbox/", "series": [ { "id": 29137, "url": "http://patchwork.dpdk.org/api/series/29137/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29137", "date": "2023-08-09T05:06:57", "name": "add frequency adjustment support for PTP timesync", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29137/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130011/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/130011/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 83B0243014;\n\tWed, 9 Aug 2023 06:59:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0193D43259;\n\tWed, 9 Aug 2023 06:58:53 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 0DBF143258\n for <dev@dpdk.org>; Wed, 9 Aug 2023 06:58:51 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Aug 2023 21:58:51 -0700", "from unknown (HELO npg-dpdk-simeisu-cvl-119d218.sh.intel.com)\n ([10.67.119.108])\n by FMSMGA003.fm.intel.com with ESMTP; 08 Aug 2023 21:58:49 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1691557132; x=1723093132;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=HDq555mK4EuzjhEPRoDom8uNW9fLrYn0Z9z8SIiAZ6k=;\n b=RjQAirbL3mb2EBUMTO4mbu4rXpJYdUeIfwDXTZuC5LsLM9Zjltf5P5zr\n /7T7l0BRxoLDH/L3sWJZ5S2yWWVksRKHZRmI41ZrB8idn7VBj2Vfib3VQ\n 6MY2vq84u4ItZ+xP2u1KwOK0qR3FsBMEkTseZrr2tG0qLuOrvsLsodS6Q\n oVBsecTRL1lojefhKIzW2papor+0mGpwI+hv/sKAP38oWHF587szIyTvf\n nspO0hacSeZ/qYqs7a552ftFtEeZG0Ol3gi8jkE8/+VlRCCIOU0loJBTo\n YrOyOIhlHsYonef69BgX4bPBGAB9NTCNtgrEPO44f+zkqiaLxmIOQ1iGt g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10795\"; a=\"351329517\"", "E=Sophos;i=\"6.01,158,1684825200\"; d=\"scan'208\";a=\"351329517\"", "E=McAfee;i=\"6600,9927,10795\"; a=\"821684811\"", "E=Sophos;i=\"6.01,158,1684825200\"; d=\"scan'208\";a=\"821684811\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,\n kirill.rybalchenko@intel.com, qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\twenjun1.wu@intel.com,\n\tSimei Su <simei.su@intel.com>", "Subject": "[PATCH 2/3] examples/ptpclient: refine application", "Date": "Wed, 9 Aug 2023 13:06:59 +0800", "Message-Id": "<20230809050700.271534-3-simei.su@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20230809050700.271534-1-simei.su@intel.com>", "References": "<20230809050700.271534-1-simei.su@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch reworks code to split delay request message parsing\nfrom follow up message parsing which doesn't break original logic.\n\nSigned-off-by: Simei Su <simei.su@intel.com>\nSigned-off-by: Wenjun Wu <wenjun1.wu@intel.com>\n---\n examples/ptpclient/ptpclient.c | 48 ++++++++++++++++++++++++++++--------------\n 1 file changed, 32 insertions(+), 16 deletions(-)", "diff": "diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex cdf2da6..74a1bf5 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -382,21 +382,11 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)\n static void\n parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n {\n-\tstruct rte_ether_hdr *eth_hdr;\n-\tstruct rte_ether_addr eth_addr;\n \tstruct ptp_header *ptp_hdr;\n-\tstruct clock_id *client_clkid;\n \tstruct ptp_message *ptp_msg;\n-\tstruct delay_req_msg *req_msg;\n-\tstruct rte_mbuf *created_pkt;\n \tstruct tstamp *origin_tstamp;\n-\tstruct rte_ether_addr eth_multicast = ether_multicast;\n-\tsize_t pkt_size;\n-\tint wait_us;\n \tstruct rte_mbuf *m = ptp_data->m;\n-\tint ret;\n \n-\teth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);\n \tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n \t\t\t+ sizeof(struct rte_ether_hdr));\n \tif (memcmp(&ptp_data->master_clock_id,\n@@ -413,6 +403,26 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \tptp_data->tstamp1.tv_sec =\n \t\t((uint64_t)ntohl(origin_tstamp->sec_lsb)) |\n \t\t(((uint64_t)ntohs(origin_tstamp->sec_msb)) << 32);\n+}\n+\n+static void\n+send_delay_request(struct ptpv2_data_slave_ordinary *ptp_data)\n+{\n+\tstruct rte_ether_hdr *eth_hdr;\n+\tstruct rte_ether_addr eth_addr;\n+\tstruct ptp_header *ptp_hdr;\n+\tstruct clock_id *client_clkid;\n+\tstruct delay_req_msg *req_msg;\n+\tstruct rte_mbuf *created_pkt;\n+\tstruct rte_ether_addr eth_multicast = ether_multicast;\n+\tsize_t pkt_size;\n+\tint wait_us;\n+\tstruct rte_mbuf *m = ptp_data->m;\n+\tint ret;\n+\n+\teth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);\n+\tptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)\n+\t\t\t+ sizeof(struct rte_ether_hdr));\n \n \tif (ptp_data->seqID_FOLLOWUP == ptp_data->seqID_SYNC) {\n \t\tret = rte_eth_macaddr_get(ptp_data->portid, ð_addr);\n@@ -550,12 +560,6 @@ parse_drsp(struct ptpv2_data_slave_ordinary *ptp_data)\n \t\t\t\t((uint64_t)ntohl(rx_tstamp->sec_lsb)) |\n \t\t\t\t(((uint64_t)ntohs(rx_tstamp->sec_msb)) << 32);\n \n-\t\t\t/* Evaluate the delta for adjustment. */\n-\t\t\tptp_data->delta = delta_eval(ptp_data);\n-\n-\t\t\trte_eth_timesync_adjust_time(ptp_data->portid,\n-\t\t\t\t\t\t ptp_data->delta);\n-\n \t\t\tptp_data->current_ptp_port = ptp_data->portid;\n \n \t\t\t/* Update kernel time if enabled in app parameters. */\n@@ -568,6 +572,16 @@ parse_drsp(struct ptpv2_data_slave_ordinary *ptp_data)\n \t}\n }\n \n+static void\n+ptp_adjust_time(struct ptpv2_data_slave_ordinary *ptp_data)\n+{\n+\t/* Evaluate the delta for adjustment. */\n+\tptp_data->delta = delta_eval(ptp_data);\n+\n+\trte_eth_timesync_adjust_time(ptp_data->portid,\n+\t\t\t\t ptp_data->delta);\n+}\n+\n /* This function processes PTP packets, implementing slave PTP IEEE1588 L2\n * functionality.\n */\n@@ -594,9 +608,11 @@ parse_ptp_frames(uint16_t portid, struct rte_mbuf *m) {\n \t\t\tbreak;\n \t\tcase FOLLOW_UP:\n \t\t\tparse_fup(&ptp_data);\n+\t\t\tsend_delay_request(&ptp_data);\n \t\t\tbreak;\n \t\tcase DELAY_RESP:\n \t\t\tparse_drsp(&ptp_data);\n+\t\t\tptp_adjust_time(&ptp_data);\n \t\t\tprint_clock_info(&ptp_data);\n \t\t\tbreak;\n \t\tdefault:\n", "prefixes": [ "2/3" ] }