Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130038/?format=api
{ "id": 130038, "url": "http://patchwork.dpdk.org/api/patches/130038/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809053843.3698537-1-jhascoet@kalray.eu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809053843.3698537-1-jhascoet@kalray.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809053843.3698537-1-jhascoet@kalray.eu", "date": "2023-08-09T05:38:43", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06e293f8e3eca5e0ca0702675b1f62b0b598cb6f", "submitter": { "id": 3147, "url": "http://patchwork.dpdk.org/api/people/3147/?format=api", "name": "jhascoet", "email": "ju.hascoet@gmail.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809053843.3698537-1-jhascoet@kalray.eu/mbox/", "series": [ { "id": 29141, "url": "http://patchwork.dpdk.org/api/series/29141/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29141", "date": "2023-08-09T05:38:43", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29141/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130038/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/130038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08C3342FBE;\n\tWed, 9 Aug 2023 11:07:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D510943259;\n\tWed, 9 Aug 2023 11:07:25 +0200 (CEST)", "from mail-ed1-f44.google.com (mail-ed1-f44.google.com\n [209.85.208.44]) by mails.dpdk.org (Postfix) with ESMTP id C3D2B400D6\n for <dev@dpdk.org>; Wed, 9 Aug 2023 07:39:18 +0200 (CEST)", "by mail-ed1-f44.google.com with SMTP id\n 4fb4d7f45d1cf-5231f439968so6823103a12.0\n for <dev@dpdk.org>; Tue, 08 Aug 2023 22:39:18 -0700 (PDT)", "from coolup54.lin.mbt.kalray.eu ([217.181.231.53])\n by smtp.gmail.com with ESMTPSA id\n t18-20020aa7d712000000b0051e0be09297sm7566700edq.53.2023.08.08.22.39.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 08 Aug 2023 22:39:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1691559558; x=1692164358;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=82Weh1aOmyZ1VZC8wr3Apn8Fcn/Alqk+KmDWQV0boCM=;\n b=Xs5NLAHS8DzAXj3kZhBID9w9dPjwGro4iLWWcOu52RJDtfoe4Bvw9lCeU+HSHapdiA\n iSs9x3Qaef//jnA0dALx8qNXeQGQRTE2yzXnfg4esafoXhFH3JhSwE1pCndlvhA9RX9b\n MQbEGrWN51AmazG0rautBdS8KIYn18ctgZGdUC2tqmwgVNet9QUp1RWpFHpfCwNynJPQ\n +pE6zjKgb4IMJFu3LBkmN6p94HLWmaYAkbb9RQrOGbqmhckEOWgU2UtCbjziF1t0bg4R\n LpbWXKIR5FT+uMQdzPEMPq0p4VdqmpqGgU5r6NJ19FBg86ypb0oio2/rL+bz9+1P2GrQ\n Wc7g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691559558; x=1692164358;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=82Weh1aOmyZ1VZC8wr3Apn8Fcn/Alqk+KmDWQV0boCM=;\n b=kCaEq4CdWY1tgf/eBEPm5QRGRVQECfDLZVzKDTDmNJursTEumLOK26GFGqkeWiOkTd\n /vB4jU88JH2m/UL2DuGnfPuSn353xv741cndA4O4uMQrj/tp94bf6wCDyonR6qzRiCiX\n orleXzueGKiMYS6lUz6NocHnJM2JZE6jaLQDrDcHF8q6vmXI7azelLCrOGrdluo752au\n wEo8RFxzMxlDM710NvldVAoZEHXurvmW5ApQnbQ6xin5EUHXK8Ej18fH2+RbEhWVHfZ9\n VMzzsK+6MdSHFZxEnWlW5sbDzINwqPO70rhLK1EZiqV/btUSiXfyp1SXI40IkDnOsaz9\n n0oA==", "X-Gm-Message-State": "AOJu0Yx6Xkg293zcQPs6jK+0KFcNLtn6Odd1IXSqOC6/j42Wbn6JjRCK\n mFe8RGL3+S+LF0wqIUevzUA=", "X-Google-Smtp-Source": "\n AGHT+IHa5H/oGxuqEkV0dRYoQnhjlqyrycN7abRjHoMDFJ0DrU+3puU1SHWUzKDTqR+piO4neFmlMg==", "X-Received": "by 2002:aa7:d754:0:b0:523:2da2:1ec4 with SMTP id\n a20-20020aa7d754000000b005232da21ec4mr1649132eds.11.1691559558122;\n Tue, 08 Aug 2023 22:39:18 -0700 (PDT)", "From": "jhascoet <ju.hascoet@gmail.com>", "X-Google-Original-From": "jhascoet <jhascoet@kalray.eu>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org, jhascoet <jhascoet@kalray.eu>,\n Julien Hascoet <jhascoet@kalrayinc.com>", "Subject": "[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "Date": "Wed, 9 Aug 2023 07:38:43 +0200", "Message-Id": "<20230809053843.3698537-1-jhascoet@kalray.eu>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 09 Aug 2023 11:07:23 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In case of ring full state, we retry the enqueue\noperation in order to avoid mbuf loss.\n\nFixes: af75078fece (\"first public release\")\n\nSigned-off-by: Julien Hascoet <jhascoet@kalrayinc.com>\n---\n app/test/test_mbuf.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex efac01806b..be114e3302 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n \t\ttref += ref;\n \t\tif ((ref & 1) != 0) {\n \t\t\trte_pktmbuf_refcnt_update(m, ref);\n-\t\t\twhile (ref-- != 0)\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\twhile (ref-- != 0) {\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n+\t\t\t}\n \t\t} else {\n \t\t\twhile (ref-- != 0) {\n \t\t\t\trte_pktmbuf_refcnt_update(m, 1);\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n \t\t\t}\n \t\t}\n \t\trte_pktmbuf_free(m);\n", "prefixes": [] }