Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130043/?format=api
{ "id": 130043, "url": "http://patchwork.dpdk.org/api/patches/130043/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809133553.1396119-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809133553.1396119-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809133553.1396119-4-bruce.richardson@intel.com", "date": "2023-08-09T13:35:53", "name": "[v8,3/3] telemetry: use standard logging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "038ddbf3a5c9ac4134bb425451b280eb7104bdbe", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809133553.1396119-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29143, "url": "http://patchwork.dpdk.org/api/series/29143/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29143", "date": "2023-08-09T13:35:50", "name": "Split logging functionality out of EAL", "version": 8, "mbox": "http://patchwork.dpdk.org/series/29143/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130043/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/130043/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D067643018;\n\tWed, 9 Aug 2023 15:36:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A0D541151;\n\tWed, 9 Aug 2023 15:36:37 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id A04BB40DFB\n for <dev@dpdk.org>; Wed, 9 Aug 2023 15:36:34 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Aug 2023 06:36:12 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.156])\n by fmsmga001.fm.intel.com with ESMTP; 09 Aug 2023 06:36:14 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1691588195; x=1723124195;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=9u5Xav9/VDLpmSonCrUEBIKeoyUq3j3n1p5Zajo+UJQ=;\n b=buQqBGwscwllq2Tr18MgZzQPeanTQKPl2vT8ZDN+dIB0jnRxy032AlLY\n kPgVmi7xTFpJqo9RCzzpyEKHAjs7GrT52Q6MfNTVqCuGdQq0b3H0pXK1v\n pAqY6UldiIKYwcg2C5AZmxGzdBC39knylDSlHkdF6zl7HvE2KV7wajSIF\n u9ztWDApgvAEHBglBQfzBTM1Y71jtLrfIngOYM5AFJQ6cme+lTLzdM97F\n X7vg9I7ISFnWRTEi5xSID4p+zKXoujRCmyACoIZAeeePM9mKmlAv1J1dw\n j+xLMYj3aGz5bNPOW3sWVjwyHRiAiLqxyixH8ayMuCBF+Ap50O6HAJSDr w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10795\"; a=\"435015708\"", "E=Sophos;i=\"6.01,159,1684825200\"; d=\"scan'208\";a=\"435015708\"", "E=Sophos;i=\"6.01,202,1684825200\"; d=\"scan'208\";a=\"875261571\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v8 3/3] telemetry: use standard logging", "Date": "Wed, 9 Aug 2023 14:35:53 +0100", "Message-Id": "<20230809133553.1396119-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230809133553.1396119-1-bruce.richardson@intel.com>", "References": "<20220829151901.376754-1-bruce.richardson@intel.com>\n <20230809133553.1396119-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now that logging is moved out of EAL, we don't need injection of the\nlogtype and logging function from EAL to telemetry library, simplifying\nthings.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/freebsd/eal.c | 6 +-----\n lib/eal/linux/eal.c | 6 +-----\n lib/telemetry/telemetry.c | 11 +++--------\n lib/telemetry/telemetry_internal.h | 3 +--\n 4 files changed, 6 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex dfe973e6fd..0175d89e4b 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -898,13 +898,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 477ad03d38..ed50576d99 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -1314,13 +1314,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 590720bfa6..7d0488a6d7 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -54,11 +54,9 @@ static struct socket v1_socket; /* socket for v1 telemetry */\n static const char *telemetry_version; /* save rte_version */\n static const char *socket_dir; /* runtime directory */\n static rte_cpuset_t *thread_cpuset;\n-static rte_log_fn rte_log_ptr;\n-static uint32_t logtype;\n \n-#define TMTY_LOG(l, ...) \\\n- rte_log_ptr(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n+RTE_LOG_REGISTER_DEFAULT(logtype, WARNING);\n+#define TMTY_LOG(l, ...) rte_log(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n \n /* list of command callbacks, with one command registered by default */\n static struct cmd_callback *callbacks;\n@@ -627,14 +625,11 @@ telemetry_v2_init(void)\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n int32_t\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype)\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset)\n {\n \ttelemetry_version = rte_version;\n \tsocket_dir = runtime_dir;\n \tthread_cpuset = cpuset;\n-\trte_log_ptr = log_fn;\n-\tlogtype = registered_logtype;\n \n #ifndef RTE_EXEC_ENV_WINDOWS\n \tif (telemetry_v2_init() != 0)\ndiff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h\nindex 80e2bd3a49..b331e9458f 100644\n--- a/lib/telemetry/telemetry_internal.h\n+++ b/lib/telemetry/telemetry_internal.h\n@@ -108,7 +108,6 @@ typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format,\n */\n __rte_internal\n int\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype);\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset);\n \n #endif\n", "prefixes": [ "v8", "3/3" ] }