Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130044/?format=api
{ "id": 130044, "url": "http://patchwork.dpdk.org/api/patches/130044/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230809141401.3702943-1-jhascoet@kalray.eu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230809141401.3702943-1-jhascoet@kalray.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/20230809141401.3702943-1-jhascoet@kalray.eu", "date": "2023-08-09T14:14:01", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06e293f8e3eca5e0ca0702675b1f62b0b598cb6f", "submitter": { "id": 3147, "url": "http://patchwork.dpdk.org/api/people/3147/?format=api", "name": "jhascoet", "email": "ju.hascoet@gmail.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230809141401.3702943-1-jhascoet@kalray.eu/mbox/", "series": [ { "id": 29144, "url": "http://patchwork.dpdk.org/api/series/29144/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29144", "date": "2023-08-09T14:14:01", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29144/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130044/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 91E3143019;\n\tWed, 9 Aug 2023 16:15:29 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3802A40691;\n\tWed, 9 Aug 2023 16:15:29 +0200 (CEST)", "from mail-lf1-f50.google.com (mail-lf1-f50.google.com\n [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id E847E400D6\n for <dev@dpdk.org>; Wed, 9 Aug 2023 16:14:04 +0200 (CEST)", "by mail-lf1-f50.google.com with SMTP id\n 2adb3069b0e04-4fe0e34f498so11402897e87.2\n for <dev@dpdk.org>; Wed, 09 Aug 2023 07:14:04 -0700 (PDT)", "from coolup54.lin.mbt.kalray.eu ([217.181.231.53])\n by smtp.gmail.com with ESMTPSA id\n dy9-20020a05640231e900b0052284228e3bsm8043705edb.8.2023.08.09.07.14.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Aug 2023 07:14:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1691590444; x=1692195244;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=;\n b=DK6gr8zfcYiXqF8t08LxdqiLpPIGOCrPEFA0FWR1OPcKqwERb4iKxR5IXQI4P0qlQB\n oXZfqt/ODHrv25Ky3l5sXnydWCjqUSZpG0zM1fa/Tv46tw/o9BZpU9EXtfICjH/fiTbP\n aILQAANBa1DgHuY1s/OPqmvjipyrTXqZSqxbpgxp4IrBIfwIqyT90EpQtKk2axL6+fHw\n 4ekvFPGZGrKTPHBVfBxhc+7zVkY8xbeM2BDKYniovXVjlJckFjivNdHCRmkQChX7MsPi\n TkBllj0w2C3MZ9rVlluR7hmpNxpuo+/gnaF9DLSRT7Mi5LfMOZ+S7SFsad0VMmIkFopJ\n 5DeQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691590444; x=1692195244;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=;\n b=EiZ576wJkz1dKbU994CptHqx0x75fM3nooZecfJ8n/6ieiogrohZlBt8AhzztRHwdU\n jC+/hFoNS3f03k2tcLLC5xwYe+wHyEM8tbSA4T1rPi1Sbiuq4SUGyf2qzuZxr0dPKeTQ\n KN8VOK3cQ3IJya+xc0f3URP9GeaFCQCcG7X+A962maaYIw2UdTAB78A+DkcoUkfyZioS\n UvPUBCmbZxAkiraLzv89nOuUpBejYNVgvDQJ70Qq9z4KrI29eCZYNynyTJhPaeYYuO2Z\n IrKOa2RjyK3E4Eh3z9F5QiXwlv94NQMpuMZXxkENrV5+t48pBXb+klEDqK1pgvD/rnRq\n euWg==", "X-Gm-Message-State": "AOJu0YzrcZBO8LFV06lYVwE8nOZpyTfDlaJT3aYzK8wkmedq36l/PMxR\n vgDfFVAOanlPKnN407Mu/7s=", "X-Google-Smtp-Source": "\n AGHT+IFLwKuLrih5SqBvpnefmNmE+8pMNC6rdkup61UuUwiQguqDEOzerZzy6YMrG32mHxU2jMf+yQ==", "X-Received": "by 2002:ac2:5f4e:0:b0:4fb:81f2:4228 with SMTP id\n 14-20020ac25f4e000000b004fb81f24228mr1695739lfz.31.1691590443875;\n Wed, 09 Aug 2023 07:14:03 -0700 (PDT)", "From": "jhascoet <ju.hascoet@gmail.com>", "X-Google-Original-From": "jhascoet <jhascoet@kalray.eu>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tJulien Hascoet <ju.hascoet@gmail.com>", "Subject": "[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "Date": "Wed, 9 Aug 2023 16:14:01 +0200", "Message-Id": "<20230809141401.3702943-1-jhascoet@kalray.eu>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 09 Aug 2023 16:15:28 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Julien Hascoet <ju.hascoet@gmail.com>\n\nIn case of ring full state, we retry the enqueue\noperation in order to avoid mbuf loss.\n\nFixes: af75078fece (\"first public release\")\n\nSigned-off-by: Julien Hascoet <ju.hascoet@gmail.com>\n---\n app/test/test_mbuf.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex efac01806b..be114e3302 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n \t\ttref += ref;\n \t\tif ((ref & 1) != 0) {\n \t\t\trte_pktmbuf_refcnt_update(m, ref);\n-\t\t\twhile (ref-- != 0)\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\twhile (ref-- != 0) {\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n+\t\t\t}\n \t\t} else {\n \t\t\twhile (ref-- != 0) {\n \t\t\t\trte_pktmbuf_refcnt_update(m, 1);\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n \t\t\t}\n \t\t}\n \t\trte_pktmbuf_free(m);\n", "prefixes": [] }